[PATCH 10/15] block: fix partial read() of /proc/{partitions,diskstats}

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-kernel@...>
Cc: Kay Sievers <kay.sievers@...>, Greg Kroah-Hartman <gregkh@...>
Date: Thursday, August 21, 2008 - 1:32 pm

From: Kay Sievers <kay.sievers@vrfy.org>

The proc files get truncated if they do not fit into the buffer with
a single read(). We need to move the seq_file index from the callback
of class_find_device() to the caller of class_find_device(), to keep
its value across multiple invocations of the callback.

Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 block/genhd.c |   14 ++++++++------
 1 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/block/genhd.c b/block/genhd.c
index c13cc77..f34befc 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -293,25 +293,26 @@ void __init printk_all_partitions(void)
 /* iterator */
 static int find_start(struct device *dev, void *data)
 {
-	loff_t k = *(loff_t *)data;
+	loff_t *k = data;
 
 	if (dev->type != &disk_type)
 		return 0;
-	if (!k--)
+	if (!*k)
 		return 1;
+	(*k)--;
 	return 0;
 }
 
 static void *part_start(struct seq_file *part, loff_t *pos)
 {
 	struct device *dev;
-	loff_t n = *pos;
+	loff_t k = *pos;
 
-	if (!n)
+	if (!k)
 		seq_puts(part, "major minor  #blocks  name\n\n");
 
 	mutex_lock(&block_class_lock);
-	dev = class_find_device(&block_class, NULL, (void *)pos, find_start);
+	dev = class_find_device(&block_class, NULL, &k, find_start);
 	if (dev)
 		return dev_to_disk(dev);
 	return NULL;
@@ -568,9 +569,10 @@ static struct device_type disk_type = {
 static void *diskstats_start(struct seq_file *part, loff_t *pos)
 {
 	struct device *dev;
+	loff_t k = *pos;
 
 	mutex_lock(&block_class_lock);
-	dev = class_find_device(&block_class, NULL, (void *)pos, find_start);
+	dev = class_find_device(&block_class, NULL, &k, find_start);
 	if (dev)
 		return dev_to_disk(dev);
 	return NULL;
-- 
1.5.6.5

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 15/15] pnp: fix "add acpi:* modalias entries", Greg Kroah-Hartman, (Thu Aug 21, 1:33 pm)
[PATCH 14/15] UIO: generic irq handling for some uio platfor..., Greg Kroah-Hartman, (Thu Aug 21, 1:33 pm)
[PATCH 13/15] UIO: uio_pdrv: fix license specification, Greg Kroah-Hartman, (Thu Aug 21, 1:33 pm)
[PATCH 12/15] UIO: uio_pdrv: fix memory leak, Greg Kroah-Hartman, (Thu Aug 21, 1:33 pm)
[PATCH 11/15] block: drop references taken by class_find_dev..., Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
[PATCH 10/15] block: fix partial read() of /proc/{partitions..., Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
[PATCH 09/15] PM: Remove WARN_ON from device_pm_add, Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
[PATCH 08/15] driver core: add init_name to struct device, Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
[PATCH 07/15] PM: don't skip device PM init when CONFIG_PM_S..., Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
[PATCH 06/15] driver model: anti-oopsing medicine, Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
Re: [PATCH 06/15] driver model: anti-oopsing medicine, David Brownell, (Thu Aug 21, 2:24 pm)
[PATCH 05/15] dev_printk(): constify the `dev' argument, Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
[PATCH 04/15] drivers/base/driver.c: remove unused to_dev() ..., Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
[PATCH 03/15] Documentation: HOWTO-ja_JP-sync patch, Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
[PATCH 02/15] Japanese translation of Documentation/SubmitCh..., Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)
[PATCH 01/15] kobject: Replace ALL occurrences of '/' with '..., Greg Kroah-Hartman, (Thu Aug 21, 1:32 pm)