[PATCH 05/15] dev_printk(): constify the `dev' argument

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Greg Kroah-Hartman
Date: Thursday, August 21, 2008 - 10:32 am

From: Jean Delvare <khali@linux-fr.org>

Add const markings to dev_name and dev_driver_string to make it clear that
dev_printk doesn't modify dev.  This is a prerequisite to adding more
const markings to other functions make it clearer, which functions can
modify dev and which can't.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/base/core.c    |    2 +-
 include/linux/device.h |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 068aa1c..44bad73 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -53,7 +53,7 @@ static inline int device_is_not_partition(struct device *dev)
  * it is attached to.  If it is not attached to a bus either, an empty
  * string will be returned.
  */
-const char *dev_driver_string(struct device *dev)
+const char *dev_driver_string(const struct device *dev)
 {
 	return dev->driver ? dev->driver->name :
 			(dev->bus ? dev->bus->name :
diff --git a/include/linux/device.h b/include/linux/device.h
index d24a47f..a701c1b 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -406,7 +406,7 @@ struct device {
 /* Get the wakeup routines, which depend on struct device */
 #include <linux/pm_wakeup.h>
 
-static inline const char *dev_name(struct device *dev)
+static inline const char *dev_name(const struct device *dev)
 {
 	/* will be changed into kobject_name(&dev->kobj) in the near future */
 	return dev->bus_id;
@@ -518,7 +518,7 @@ extern void device_shutdown(void);
 extern void sysdev_shutdown(void);
 
 /* debugging and troubleshooting/diagnostic helpers. */
-extern const char *dev_driver_string(struct device *dev);
+extern const char *dev_driver_string(const struct device *dev);
 #define dev_printk(level, dev, format, arg...)	\
 	printk(level "%s %s: " format , dev_driver_string(dev) , \
 	       dev_name(dev) , ## arg)
-- 
1.5.6.5

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 01/15] kobject: Replace ALL occurrences of '/' with ..., Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 02/15] Japanese translation of Documentation/Submit ..., Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 03/15] Documentation: HOWTO-ja_JP-sync patch, Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 04/15] drivers/base/driver.c: remove unused to_dev( ..., Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 05/15] dev_printk(): constify the `dev' argument, Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 06/15] driver model: anti-oopsing medicine, Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 07/15] PM: don't skip device PM init when CONFIG_PM ..., Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 08/15] driver core: add init_name to struct device, Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 09/15] PM: Remove WARN_ON from device_pm_add, Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 10/15] block: fix partial read() of /proc/{partitio ..., Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 11/15] block: drop references taken by class_find_d ..., Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 12/15] UIO: uio_pdrv: fix memory leak, Greg Kroah-Hartman, (Thu Aug 21, 10:33 am)
[PATCH 13/15] UIO: uio_pdrv: fix license specification, Greg Kroah-Hartman, (Thu Aug 21, 10:33 am)
[PATCH 14/15] UIO: generic irq handling for some uio platf ..., Greg Kroah-Hartman, (Thu Aug 21, 10:33 am)
[PATCH 15/15] pnp: fix &quot;add acpi:* modalias entries&quot;, Greg Kroah-Hartman, (Thu Aug 21, 10:33 am)
Re: [PATCH 06/15] driver model: anti-oopsing medicine, David Brownell, (Thu Aug 21, 11:24 am)