Home » Mailing list archives » linux-kernel » 2008 » August » 21

[PATCH 01/15] kobject: Replace ALL occurrences of '/' with '!' instead of only the first one.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Greg Kroah-Hartman
Subject: [PATCH 01/15] kobject: Replace ALL occurrences of '/' with '!' instead of only the first one.
Date: Thursday, August 21, 2008 - 10:32 am

From: Ingo Oeser <ioe-lkml@rameria.de>

A recent patch from Kay Sievers <kay.sievers@vrfy.org>
replaced the first occurrence of '/' with '!' as needed for block devices.

Now do some cheap defensive coding and replace all of them to avoid future
issues in this area.

Signed-off-by: Ingo Oeser <ioe-lkml@rameria.de>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 lib/kobject.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/lib/kobject.c b/lib/kobject.c
index bd732ff..fbf0ae2 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -223,8 +223,7 @@ static int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
 		return -ENOMEM;
 
 	/* ewww... some of these buggers have '/' in the name ... */
-	s = strchr(kobj->name, '/');
-	if (s)
+	while ((s = strchr(kobj->name, '/')))
 		s[0] = '!';
 
 	kfree(old_name);
-- 
1.5.6.5

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[GIT PATCH] driver core patches against 2.6.26-rc4, Greg KH, (Thu Aug 21, 10:30 am)
[PATCH 01/15] kobject: Replace ALL occurrences of '/' with ..., Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 02/15] Japanese translation of Documentation/Submit ..., Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 03/15] Documentation: HOWTO-ja_JP-sync patch, Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 04/15] drivers/base/driver.c: remove unused to_dev( ..., Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 05/15] dev_printk(): constify the `dev' argument, Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 06/15] driver model: anti-oopsing medicine, Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 07/15] PM: don't skip device PM init when CONFIG_PM ..., Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 08/15] driver core: add init_name to struct device, Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 09/15] PM: Remove WARN_ON from device_pm_add, Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 10/15] block: fix partial read() of /proc/{partitio ..., Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 11/15] block: drop references taken by class_find_d ..., Greg Kroah-Hartman, (Thu Aug 21, 10:32 am)
[PATCH 12/15] UIO: uio_pdrv: fix memory leak, Greg Kroah-Hartman, (Thu Aug 21, 10:33 am)
[PATCH 13/15] UIO: uio_pdrv: fix license specification, Greg Kroah-Hartman, (Thu Aug 21, 10:33 am)
[PATCH 14/15] UIO: generic irq handling for some uio platf ..., Greg Kroah-Hartman, (Thu Aug 21, 10:33 am)
[PATCH 15/15] pnp: fix &quot;add acpi:* modalias entries&quot;, Greg Kroah-Hartman, (Thu Aug 21, 10:33 am)
Re: [PATCH 06/15] driver model: anti-oopsing medicine, David Brownell, (Thu Aug 21, 11:24 am)
Re: [PATCH 06/15] driver model: anti-oopsing medicine, Greg KH, (Thu Aug 21, 1:04 pm)
Re: [PATCH 01/15] kobject: Replace ALL occurrences of '/' ..., Ville , (Fri Aug 22, 5:41 am)
Re: [PATCH 01/15] kobject: Replace ALL occurrences of '/' ..., Greg KH, (Fri Aug 22, 7:14 pm)