Re: [PATCH] Move sysctl check into debugging section and don't make it default y

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andi Kleen
Date: Wednesday, August 20, 2008 - 11:40 pm

> What is a feature change like this doing coming in after the

I considered it a "anti bloat bugfix". Adding 30k of 
object code to allno was a bit too much. 


Because it depends on EMBEDDED and EMBEDDED is not y. Yes it's not
intuitive, on the other hand the end result is reasonable.


My assumption is that they will be run at least once during
a release cycle by someone and then the messages will appear
and be reported. We do the same thing with a lot of other
debug options (lockdep, slab debug, sleep debug etc.,). There's no 
need for this one to be special.

Also I'm not sure the check is all that useful anyways. We
should just not accept any new binary numbered sysctl, and
that's nearly the case anyways.

-Andi

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] Move sysctl check into debugging section and d ..., Eric W. Biederman, (Wed Aug 20, 11:14 pm)
Re: [PATCH] Move sysctl check into debugging section and d ..., Andi Kleen, (Wed Aug 20, 11:40 pm)
Re: [PATCH] Move sysctl check into debugging section and d ..., Eric W. Biederman, (Thu Aug 21, 1:14 am)
Re: [PATCH] Move sysctl check into debugging section and d ..., Eric W. Biederman, (Thu Aug 21, 11:15 am)
Re: [PATCH] Move sysctl check into debugging section and d ..., Eric W. Biederman, (Thu Aug 21, 7:17 pm)