Hi,
Sean MacLennan <smaclennan@pikatech.com> writes:
quoted text > If CONFIG_NEED_MULTIPLE_NODES is *not* set, then you get a section
> mismatch in reference from the variable contig_page_data to the
> variable __initdata bootmem_node_data.
>
> The simple solution is to just remove the __initdata from
> bootmem_node_data. We could also put an ifdef around the __initdata.
>
> Signed-off-by: Sean MacLennan <smaclennan@pikatech.com>
> ---
> diff --git a/mm/bootmem.c b/mm/bootmem.c
> index e023c68..a968ae2 100644
> --- a/mm/bootmem.c
> +++ b/mm/bootmem.c
> @@ -31,7 +31,7 @@ unsigned long max_pfn;
> unsigned long saved_max_pfn;
> #endif
>
> -bootmem_data_t bootmem_node_data[MAX_NUMNODES] __initdata;
> +bootmem_data_t bootmem_node_data[MAX_NUMNODES];
It is totally valid to be init data as it does not get referenced after
bootup and should therefor be freed.
The statically defined pointer from contig_page_data is the problem and
the fix should be on this end rather than worsening code to suppress a
warning.
NAK,
Hannes
--
unsubscribe notice To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Messages in current thread:
Re: [PATCH] Section mismatch contig_page_data and bootmem_ ... , Johannes Weiner , (Wed Aug 20, 2:53 pm)