Home » Mailing list archives » linux-kernel » 2008 » August » 20

Re: [PATCH] fbdefio: add set_page_dirty handler to deferred IO FB

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andrew Morton
Subject: Re: [PATCH] fbdefio: add set_page_dirty handler to deferred IO FB
Date: Wednesday, August 20, 2008 - 1:37 am

On Wed, 20 Aug 2008 09:13:23 +0100 Ian Campbell <ijc@hellion.org.uk> wrote:


That would be less racy, I expect.  Implement fb_ops.fb_open() within
drivers/video/fb_defio.c and do the address_space_operations overwrite
there.  Hopefully that will ensure that the address_space_operations
instance is stable before anyone uses it for anything serious.

It'd be better to hook in at inode creation time but afaict that's not
available for the /dev/fb0 node.

<tries to write a patch>

OK, seems that fb_ops.fb_open() has no way of getting at the `struct
file *' which is being opened (wtf?).  Screwed.  Need to change
fb_ops.fb_open(), or add a new fb_ops.fb_open_sane().




--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] fbdefio: add set_page_dirty handler to deferred IO FB, Ian Campbell, (Mon Aug 18, 11:02 pm)
Re: [PATCH] fbdefio: add set_page_dirty handler to deferre ..., Andrew Morton, (Mon Aug 18, 11:38 pm)
Re: [PATCH] fbdefio: add set_page_dirty handler to deferre ..., Peter Zijlstra, (Tue Aug 19, 12:13 am)
Re: [PATCH] fbdefio: add set_page_dirty handler to deferre ..., Ian Campbell, (Wed Aug 20, 1:13 am)
Re: [PATCH] fbdefio: add set_page_dirty handler to deferre ..., Andrew Morton, (Wed Aug 20, 1:37 am)
Re: [PATCH] fbdefio: add set_page_dirty handler to deferre ..., Jaya Kumar, (Wed Aug 20, 1:46 am)
Re: [PATCH] fbdefio: add set_page_dirty handler to deferre ..., Markus Armbruster, (Wed Aug 20, 5:27 am)
Re: [PATCH] fbdefio: add set_page_dirty handler to deferre ..., Jeremy Fitzhardinge, (Wed Aug 20, 11:47 am)
Re: [PATCH] fbdefio: add set_page_dirty handler to deferre ..., Ian Campbell, (Wed Aug 20, 11:57 am)
Re: [PATCH] fbdefio: add set_page_dirty handler to deferre ..., Andrew Morton, (Wed Aug 20, 12:30 pm)
Re: [PATCH] fbdefio: add set_page_dirty handler to deferre ..., Ian Campbell, (Wed Aug 20, 12:40 pm)
Re: [PATCH] fbdefio: add set_page_dirty handler to deferre ..., Andrew Morton, (Wed Aug 20, 12:50 pm)
Re: [PATCH] fbdefio: add set_page_dirty handler to deferre ..., Jaya Kumar, (Wed Aug 20, 4:11 pm)