Re: [PATCH v2 2/2] eeepc-laptop: Use standard interfaces

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Henrique de Moraes Holschuh
Date: Tuesday, August 19, 2008 - 4:09 pm

Looks fine to me at first glance.  I do wonder if there are no events at all
you could hook to rfkill_force_state() instead of (or in addition to) using
the get_state()?

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/2] eeepc-laptop: Fix user after free, Matthew Garrett, (Mon Aug 4, 10:08 am)
[PATCH 2/2] eeepc-laptop: Use standard interfaces, Matthew Garrett, (Mon Aug 4, 10:15 am)
Re: [PATCH 2/2] eeepc-laptop: Use standard interfaces, Matthew Garrett, (Mon Aug 4, 10:36 am)
Re: [PATCH 2/2] eeepc-laptop: Use standard interfaces, Ivo van Doorn, (Mon Aug 4, 10:53 am)
Re: [PATCH 2/2] eeepc-laptop: Use standard interfaces, Henrique de Moraes H ..., (Mon Aug 4, 2:21 pm)
Re: [PATCH 2/2] eeepc-laptop: Use standard interfaces, Henrique de Moraes H ..., (Mon Aug 4, 2:29 pm)
[PATCH v2 1/2] eeepc-laptop: Fix user after free, Matthew Garrett, (Wed Aug 6, 2:23 am)
[PATCH v2 2/2] eeepc-laptop: Use standard interfaces, Matthew Garrett, (Wed Aug 6, 2:25 am)
Re: [PATCH v2 2/2] eeepc-laptop: Use standard interfaces, Andrew Morton, (Tue Aug 19, 2:58 am)
Re: [PATCH v2 2/2] eeepc-laptop: Use standard interfaces, Matthew Garrett, (Tue Aug 19, 4:13 am)
Re: [PATCH v2 2/2] eeepc-laptop: Use standard interfaces, Henrique de Moraes H ..., (Tue Aug 19, 4:09 pm)
Re: [PATCH v2 2/2] eeepc-laptop: Use standard interfaces, Matthew Garrett, (Tue Aug 19, 4:24 pm)
Re: [PATCH v2 2/2] eeepc-laptop: Use standard interfaces, Henrique de Moraes H ..., (Tue Aug 19, 6:18 pm)
Re: [PATCH v2 2/2] eeepc-laptop: Use standard interfaces, Matthew Garrett, (Tue Aug 19, 6:28 pm)
Re: [PATCH v2 2/2] eeepc-laptop: Use standard interfaces, Henrique de Moraes H ..., (Tue Aug 19, 6:32 pm)
Awkward rfkill corner cases, Matthew Garrett, (Tue Aug 19, 6:42 pm)
Re: Awkward rfkill corner cases, Henrique de Moraes H ..., (Tue Aug 19, 7:30 pm)