Re: [PATCH -tip] rcuclassic: fix compilation NG

Previous thread: Re: HPET regression in 2.6.26 versus 2.6.25 -- connection between HPET and lockups found by David Witbrodt on Monday, August 18, 2008 - 8:51 pm. (2 messages)

Next thread: Confirmation of methods for calculating requested pathname. by Kentaro Takeda on Monday, August 18, 2008 - 9:19 pm. (9 messages)
From: Hiroshi Shimamoto
Date: Monday, August 18, 2008 - 9:49 pm

From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>

  CC      kernel/rcuclassic.o
kernel/rcuclassic.c: In function '__rcu_process_callbacks':
kernel/rcuclassic.c:561: error: 'flags' undeclared (first use in this function)
kernel/rcuclassic.c:561: error: (Each undeclared identifier is reported only once
kernel/rcuclassic.c:561: error: for each function it appears in.)
kernel/rcuclassic.c:561: warning: type defaults to 'int' in declaration of '__dummy2'
kernel/rcuclassic.c:561: warning: comparison of distinct pointer types lacks a cast
kernel/rcuclassic.c:561: warning: type defaults to 'int' in declaration of '__dummy2'
kernel/rcuclassic.c:561: warning: comparison of distinct pointer types lacks a cast
kernel/rcuclassic.c:566: warning: type defaults to 'int' in declaration of '__dummy2'
kernel/rcuclassic.c:566: warning: comparison of distinct pointer types lacks a cast
kernel/rcuclassic.c:566: warning: type defaults to 'int' in declaration of '__dummy2'
kernel/rcuclassic.c:566: warning: comparison of distinct pointer types lacks a cast

Declare missing variable flagas.

Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
---
 kernel/rcuclassic.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel/rcuclassic.c b/kernel/rcuclassic.c
index c6b6cf5..01e761a 100644
--- a/kernel/rcuclassic.c
+++ b/kernel/rcuclassic.c
@@ -557,6 +557,8 @@ static void __rcu_process_callbacks(struct rcu_ctrlblk *rcp,
 		local_irq_enable();
 
 		if (rcu_batch_after(rdp->batch, rcp->pending)) {
+			unsigned long flags;
+
 			/* and start it/schedule start if it's a new batch */
 			spin_lock_irqsave(&rcp->lock, flags);
 			if (rcu_batch_after(rdp->batch, rcp->pending)) {
--

From: Ingo Molnar
Date: Tuesday, August 19, 2008 - 2:02 am

applied, thanks!

	Ingo
--

Previous thread: Re: HPET regression in 2.6.26 versus 2.6.25 -- connection between HPET and lockups found by David Witbrodt on Monday, August 18, 2008 - 8:51 pm. (2 messages)

Next thread: Confirmation of methods for calculating requested pathname. by Kentaro Takeda on Monday, August 18, 2008 - 9:19 pm. (9 messages)