[PATCH] atl1: disable TSO by default

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jay Cliburn
Date: Monday, August 18, 2008 - 5:28 pm

The atl1 driver is causing stalled connections and file corruption
whenever TSO is enabled.  Two examples are here:

http://lkml.org/lkml/2008/7/15/325
http://lkml.org/lkml/2008/8/18/543

Disable TSO by default until we can determine the source of the
problem.

Signed-off-by: Jay Cliburn <jacliburn@bellsouth.net>
cc: stable@kernel.org
---

Jeff, I've been trying to find the source of this problem in my
spare time for a few weeks now, but haven't been successful.  We
turned on TSO by default in 2.6.26 after fixing a nasty performance
bug in it, but there's apparently another bug lurking.

This patch needs to be also applied to 2.6.26, hence the cc to
stable.

 drivers/net/atlx/atl1.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c
index e6a7bb7..e23ce77 100644
--- a/drivers/net/atlx/atl1.c
+++ b/drivers/net/atlx/atl1.c
@@ -3022,7 +3022,6 @@ static int __devinit atl1_probe(struct pci_dev *pdev,
 	netdev->features = NETIF_F_HW_CSUM;
 	netdev->features |= NETIF_F_SG;
 	netdev->features |= (NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX);
-	netdev->features |= NETIF_F_TSO;
 	netdev->features |= NETIF_F_LLTX;
 
 	/*
-- 
1.5.5.1
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] atl1: disable TSO by default, Jay Cliburn, (Mon Aug 18, 5:28 pm)
Re: [PATCH] atl1: disable TSO by default, Herbert Xu, (Tue Aug 19, 6:10 am)
Re: [PATCH] atl1: disable TSO by default, Jay Cliburn, (Tue Aug 19, 3:53 pm)
Re: [PATCH] atl1: disable TSO by default, David Miller, (Tue Aug 19, 3:58 pm)
Re: [PATCH] atl1: disable TSO by default, Herbert Xu, (Tue Aug 19, 4:17 pm)
Re: [PATCH] atl1: disable TSO by default, Jeff Garzik, (Wed Aug 27, 2:37 am)