[PATCH 2/2] pvrusb2: use proper byteorder interface

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>
Cc: LKML <linux-kernel@...>, Mauro Carvalho Chehab <mchehab@...>, v4l-maintainer <v4l-dvb-maintainer@...>
Date: Monday, August 18, 2008 - 4:38 pm

___swab32 is an internal detail of the implementation.

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
I really suspect this should be something like be32_to_cpu...if this code
was written on an x86.

 drivers/media/video/pvrusb2/pvrusb2-hdw.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/media/video/pvrusb2/pvrusb2-hdw.c b/drivers/media/video/pvrusb2/pvrusb2-hdw.c
index f051c6a..7fa903a 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-hdw.c
+++ b/drivers/media/video/pvrusb2/pvrusb2-hdw.c
@@ -1314,8 +1314,7 @@ int pvr2_upload_firmware2(struct pvr2_hdw *hdw)
 		memcpy(fw_ptr, fw_entry->data + fw_done, bcnt);
 		/* Usbsnoop log shows that we must swap bytes... */
 		for (icnt = 0; icnt < bcnt/4 ; icnt++)
-			((u32 *)fw_ptr)[icnt] =
-				___swab32(((u32 *)fw_ptr)[icnt]);
+			((u32 *)fw_ptr)[icnt] = swab32(((u32 *)fw_ptr)[icnt]);
 
 		ret |= usb_bulk_msg(hdw->usb_dev, pipe, fw_ptr,bcnt,
 				    &actual_length, HZ);
-- 
1.6.0.274.g8aacc

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 2/2] pvrusb2: use proper byteorder interface, Harvey Harrison, (Mon Aug 18, 4:38 pm)