[PATCH 1/2] acpi_pm.c: use proper read function also in errata mode.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Dominik Brodowski
Date: Monday, August 18, 2008 - 12:05 pm

When acpi_pm is used in errata mode (three reads instead of one), also the
acpi_pm init functions need to use three reads instead of just one.

Thanks to Andreas Mohr for spotting this issue.

CC: John Stultz <johnstul@us.ibm.com>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
---
 drivers/clocksource/acpi_pm.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/clocksource/acpi_pm.c b/drivers/clocksource/acpi_pm.c
index 5ca1d80..2c00edd 100644
--- a/drivers/clocksource/acpi_pm.c
+++ b/drivers/clocksource/acpi_pm.c
@@ -151,13 +151,13 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_LE,
  */
 static int verify_pmtmr_rate(void)
 {
-	u32 value1, value2;
+	cycle_t value1, value2;
 	unsigned long count, delta;
 
 	mach_prepare_counter();
-	value1 = read_pmtmr();
+	value1 = clocksource_acpi_pm.read()
 	mach_countup(&count);
-	value2 = read_pmtmr();
+	value2 = clocksource_acpi_pm.read()
 	delta = (value2 - value1) & ACPI_PM_MASK;
 
 	/* Check that the PMTMR delta is within 5% of what we expect */
@@ -177,7 +177,7 @@ static int verify_pmtmr_rate(void)
 
 static int __init init_acpi_pm_clocksource(void)
 {
-	u32 value1, value2;
+	cycle_t value1, value2;
 	unsigned int i;
 
 	if (!pmtmr_ioport)
@@ -187,9 +187,9 @@ static int __init init_acpi_pm_clocksource(void)
 						clocksource_acpi_pm.shift);
 
 	/* "verify" this timing source: */
-	value1 = read_pmtmr();
+	value1 = clocksource_acpi_pm.read();
 	for (i = 0; i < 10000; i++) {
-		value2 = read_pmtmr();
+		value2 = clocksource_acpi_pm.read();
 		if (value2 == value1)
 			continue;
 		if (value2 > value1)
@@ -197,11 +197,11 @@ static int __init init_acpi_pm_clocksource(void)
 		if ((value2 < value1) && ((value2) < 0xFFF))
 			goto pm_good;
 		printk(KERN_INFO "PM-Timer had inconsistent results:"
-			" 0x%#x, 0x%#x - aborting.\n", value1, value2);
+			" 0x%#llx, 0x%#llx - aborting.\n", value1, value2);
 		return -EINVAL;
 	}
 	printk(KERN_INFO "PM-Timer had no reasonable result:"
-			" 0x%#x - aborting.\n", value1);
+			" 0x%#llx - aborting.\n", value1);
 	return -ENODEV;
 
 pm_good:
-- 
1.5.4.3

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
ACPI PM-Timer on K6-3 SiS5591: Houston..., Andreas Mohr, (Sun Aug 10, 3:17 am)
Re: ACPI PM-Timer on K6-3 SiS5591: Houston..., Dominik Brodowski, (Sun Aug 10, 9:29 am)
Re: ACPI PM-Timer on K6-3 SiS5591: Houston..., Arjan van de Ven, (Sun Aug 10, 9:40 am)
Re: ACPI PM-Timer on K6-3 SiS5591: Houston..., Andreas Mohr, (Sun Aug 10, 12:08 pm)
Re: ACPI PM-Timer on K6-3 SiS5591: Houston..., Dominik Brodowski, (Sun Aug 10, 1:02 pm)
[git pull?] clocksource: ACPI pmtmr bugfixes [Was: Re: ACP ..., Dominik Brodowski, (Mon Aug 18, 12:03 pm)
[PATCH 1/2] acpi_pm.c: use proper read function also in er ..., Dominik Brodowski, (Mon Aug 18, 12:05 pm)
[PATCH 2/2] acpi_pm.c: check for monotonicity, Dominik Brodowski, (Mon Aug 18, 12:05 pm)
Re: [git pull?] clocksource: ACPI pmtmr bugfixes [Was: Re: ..., Dominik Brodowski, (Mon Aug 18, 12:35 pm)
Re: [git pull?] clocksource: ACPI pmtmr bugfixes [Was: Re: ..., Dominik Brodowski, (Mon Aug 18, 1:09 pm)
[PATCH 1/2] acpi_pm.c: use proper read function also in er ..., Dominik Brodowski, (Mon Aug 18, 1:10 pm)
[PATCH 2/2] acpi_pm.c: check for monotonicity, Dominik Brodowski, (Mon Aug 18, 1:11 pm)
Re: [PATCH 2/2] acpi_pm.c: check for monotonicity, Andreas Mohr, (Mon Aug 18, 1:18 pm)
Re: [PATCH 2/2] acpi_pm.c: check for monotonicity, Andrew Morton, (Mon Aug 18, 1:28 pm)
Re: [git pull?] clocksource: ACPI pmtmr bugfixes [Was: Re: ..., Dominik Brodowski, (Mon Aug 18, 1:29 pm)
Re: [PATCH 2/2] acpi_pm.c: check for monotonicity, Dominik Brodowski, (Mon Aug 18, 1:42 pm)
Re: [PATCH 1/2] acpi_pm.c: use proper read function also i ..., Dominik Brodowski, (Tue Aug 19, 2:49 am)
[PATCH v2 1/2] acpi_pm.c: use proper read function also in ..., Dominik Brodowski, (Fri Aug 22, 3:22 pm)
[PATCH v2 2/2] acpi_pm.c: check for monotonicity, Dominik Brodowski, (Fri Aug 22, 3:26 pm)
Re: [PATCH v2 2/2] acpi_pm.c: check for monotonicity, Jochen Voß, (Sat Aug 23, 1:48 am)