Home » Mailing list archives » linux-kernel » 2008 » August » 18

[PATCH 0/15] apic: unification series 5

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Cyrill Gorcunov
Subject: [PATCH 0/15] apic: unification series 5
Date: Monday, August 18, 2008 - 9:45 am

This series is over

commit d5e629a6f88137fb77c4cc857be5ea7c3f27110d
Author: Yinghai Lu <yhlu.kernel@gmail.com>
Date:   Sun Aug 17 21:12:27 2008 -0700

    x86: apic - unify lapic_resume - fix
    
    Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>

Please review - any comments are quite welcome!

Mostly #ifdef added, code rearrangement - nothing serious
(except new bugs have been brought in :-)

So I think the most simple/basic unification is done.
Now unif. process will be harder since it will require
for much detailed code review - for example smp_spurious_interrupt
which uses different call frames on 32/64 bit modes and will
require some wrapping I think.

With this series 32bit code compilation warns:

arch/x86/kernel/apic_32.c: In function ‘end_local_APIC_setup’:
arch/x86/kernel/apic_32.c:1165: warning: ISO C90 forbids mixed declarations and code
arch/x86/kernel/apic_32.c: In function ‘disconnect_bsp_APIC’:
arch/x86/kernel/apic_32.c:1446: warning: ISO C90 forbids mixed declarations and code
cyrill@lenovo linux-2.6.git $ 

So parenthesis will be needed to eliminate them... but
I think it could be too ugly... need some time to think.
So patches 8/15 and 10/15 sould be not applied for now - just review them.
Thanks for patience!

		- Cyrill -
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/15] apic: unification series 5, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 01/15] x86: apic - rearrange maxcpu definition, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 02/15] x86: apic - unify setup_boot_APIC_clock, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 03/15] x86: apic - unify disable_local_APIC, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 04/15] x86: apic - unify lapic_shutdown, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 05/15] x86: apic - unify connect_bsp_APIC, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 06/15] x86: apic - unify lapic_setup_esr, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 07/15] x86: apic - unify __setup_APIC_LVTT, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 08/15] x86: apic - unify disconnect_bsp_APIC, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 09/15] x86: apic - generic_processor_info, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 10/15] x86: apic - unify end_local_APIC_setup, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 11/15] x86: apic - unify local_apic_timer_interrupt, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 12/15] x86: apic - unify apic_set_verbosity, Cyrill Gorcunov, (Mon Aug 18, 9:46 am)
[PATCH 13/15] x86: apic - unify disableapic and nolapic se ..., Cyrill Gorcunov, (Mon Aug 18, 9:46 am)
[PATCH 14/15] x86: apic - rearrange parse_lapic_timer_c2_ok, Cyrill Gorcunov, (Mon Aug 18, 9:46 am)
[PATCH 15/15] x86: apic - lapic_resume 32bit - unification fix, Cyrill Gorcunov, (Mon Aug 18, 9:46 am)
Re: [PATCH 01/15] x86: apic - rearrange maxcpu definition, Cyrill Gorcunov, (Mon Aug 18, 9:59 am)
Re: [PATCH 0/15] apic: unification series 5, H. Peter Anvin, (Mon Aug 18, 10:22 am)
Re: [PATCH 0/15] apic: unification series 5, Cyrill Gorcunov, (Mon Aug 18, 10:28 am)
Re: [PATCH 0/15] apic: unification series 5, Cyrill Gorcunov, (Mon Aug 18, 12:12 pm)
Re: [PATCH 0/15] apic: unification series 5, Ingo Molnar, (Mon Aug 18, 5:09 pm)