[PATCH 04/15] x86: apic - unify lapic_shutdown

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Cyrill Gorcunov
Date: Monday, August 18, 2008 - 9:45 am

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
 arch/x86/kernel/apic_32.c |    9 ++++++---
 arch/x86/kernel/apic_64.c |   14 +++++++++++++-
 2 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/apic_32.c b/arch/x86/kernel/apic_32.c
index 13c4b79..d4efe86 100644
--- a/arch/x86/kernel/apic_32.c
+++ b/arch/x86/kernel/apic_32.c
@@ -838,10 +838,13 @@ void lapic_shutdown(void)
 
 	local_irq_save(flags);
 
-	if (enabled_via_apicbase)
-		disable_local_APIC();
-	else
+#ifdef CONFIG_X86_32
+	if (!enabled_via_apicbase)
 		clear_local_APIC();
+	else
+#endif
+		disable_local_APIC();
+
 
 	local_irq_restore(flags);
 }
diff --git a/arch/x86/kernel/apic_64.c b/arch/x86/kernel/apic_64.c
index 4fb903b..4880654 100644
--- a/arch/x86/kernel/apic_64.c
+++ b/arch/x86/kernel/apic_64.c
@@ -707,6 +707,12 @@ void disable_local_APIC(void)
 #endif
 }
 
+/*
+ * If Linux enabled the LAPIC against the BIOS default disable it down before
+ * re-entering the BIOS on shutdown.  Otherwise the BIOS may get confused and
+ * not power-off.  Additionally clear all LVT entries before disable_local_APIC
+ * for the case where Linux didn't enable the LAPIC.
+ */
 void lapic_shutdown(void)
 {
 	unsigned long flags;
@@ -716,7 +722,13 @@ void lapic_shutdown(void)
 
 	local_irq_save(flags);
 
-	disable_local_APIC();
+#ifdef CONFIG_X86_32
+	if (!enabled_via_apicbase)
+		clear_local_APIC();
+	else
+#endif
+		disable_local_APIC();
+
 
 	local_irq_restore(flags);
 }
-- 
1.6.0.rc1.34.g0fe8c

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/15] apic: unification series 5, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 01/15] x86: apic - rearrange maxcpu definition, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 02/15] x86: apic - unify setup_boot_APIC_clock, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 03/15] x86: apic - unify disable_local_APIC, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 04/15] x86: apic - unify lapic_shutdown, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 05/15] x86: apic - unify connect_bsp_APIC, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 06/15] x86: apic - unify lapic_setup_esr, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 07/15] x86: apic - unify __setup_APIC_LVTT, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 08/15] x86: apic - unify disconnect_bsp_APIC, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 09/15] x86: apic - generic_processor_info, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 10/15] x86: apic - unify end_local_APIC_setup, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 11/15] x86: apic - unify local_apic_timer_interrupt, Cyrill Gorcunov, (Mon Aug 18, 9:45 am)
[PATCH 12/15] x86: apic - unify apic_set_verbosity, Cyrill Gorcunov, (Mon Aug 18, 9:46 am)
[PATCH 14/15] x86: apic - rearrange parse_lapic_timer_c2_ok, Cyrill Gorcunov, (Mon Aug 18, 9:46 am)
Re: [PATCH 01/15] x86: apic - rearrange maxcpu definition, Cyrill Gorcunov, (Mon Aug 18, 9:59 am)
Re: [PATCH 0/15] apic: unification series 5, H. Peter Anvin, (Mon Aug 18, 10:22 am)
Re: [PATCH 0/15] apic: unification series 5, Cyrill Gorcunov, (Mon Aug 18, 10:28 am)
Re: [PATCH 0/15] apic: unification series 5, Cyrill Gorcunov, (Mon Aug 18, 12:12 pm)
Re: [PATCH 0/15] apic: unification series 5, Ingo Molnar, (Mon Aug 18, 5:09 pm)