Home » Mailing list archives » linux-kernel » 2008 » August » 18

Re: [PATCH] Fix i486 suspend to disk CR4 oops

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Dave Jones
Subject: Re: [PATCH] Fix i486 suspend to disk CR4 oops
Date: Monday, August 18, 2008 - 8:24 am

On Mon, Aug 18, 2008 at 08:41:20AM +0200, Ingo Molnar wrote:

 > diff --git a/arch/x86/kernel/efi_32.c b/arch/x86/kernel/efi_32.c
 > index 4b63c8e..5cab48e 100644
 > --- a/arch/x86/kernel/efi_32.c
 > +++ b/arch/x86/kernel/efi_32.c
 > @@ -53,7 +53,7 @@ void efi_call_phys_prelog(void)
 >  	 * directory. If I have PAE, I just need to duplicate one entry in
 >  	 * page directory.
 >  	 */
 > -	cr4 = read_cr4();
 > +	cr4 = read_cr4_safe();
 >  
 >  	if (cr4 & X86_CR4_PAE) {
 >  		efi_bak_pg_dir_pointer[0].pgd =
 > @@ -91,7 +91,7 @@ void efi_call_phys_epilog(void)
 >  	gdt_descr.size = GDT_SIZE - 1;
 >  	load_gdt(&gdt_descr);
 >  
 > -	cr4 = read_cr4();
 > +	cr4 = read_cr4_safe();
 >  
 >  	if (cr4 & X86_CR4_PAE) {
 >  		swapper_pg_dir[pgd_index(0)].pgd =

Is this part really necessary ?

Why would a 486 be in EFI code?

	Dave

-- 
http://www.codemonkey.org.uk
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Fix i486 suspend to disk CR4 oops, David Fries, (Sun Aug 17, 9:03 pm)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, Maciej W. Rozycki, (Sun Aug 17, 9:14 pm)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, H. Peter Anvin, (Sun Aug 17, 9:35 pm)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, Andi Kleen, (Sun Aug 17, 11:04 pm)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, H. Peter Anvin, (Sun Aug 17, 11:34 pm)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, Ingo Molnar, (Sun Aug 17, 11:41 pm)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, Andi Kleen, (Sun Aug 17, 11:42 pm)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, H. Peter Anvin, (Sun Aug 17, 11:45 pm)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, Pavel Machek, (Mon Aug 18, 2:15 am)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, Rafael J. Wysocki, (Mon Aug 18, 3:16 am)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, David Fries, (Mon Aug 18, 5:58 am)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, Ingo Molnar, (Mon Aug 18, 6:25 am)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, Maciej W. Rozycki, (Mon Aug 18, 7:38 am)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, Maciej W. Rozycki, (Mon Aug 18, 7:41 am)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, Dave Jones, (Mon Aug 18, 8:24 am)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, Lennart Sorensen, (Mon Aug 18, 9:04 am)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, Dave Jones, (Mon Aug 18, 10:17 am)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, H. Peter Anvin, (Mon Aug 18, 10:32 am)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, Pavel Machek, (Mon Aug 18, 3:02 pm)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, Pavel Machek, (Mon Aug 18, 3:04 pm)
Re: [PATCH] Fix i486 suspend to disk CR4 oops, H. Peter Anvin, (Mon Aug 18, 3:10 pm)
Re: [PATCH] i486 CR4 oops, no_console_suspend, David Fries, (Mon Aug 18, 8:37 pm)
Re: [PATCH] i486 CR4 oops, no_console_suspend, Ingo Molnar, (Tue Aug 19, 2:34 am)
Re: [PATCH] i486 CR4 oops, no_console_suspend, H. Peter Anvin, (Tue Aug 19, 9:07 am)
Re: [PATCH] i486 CR4 oops, no_console_suspend, David Fries, (Wed Aug 20, 9:17 pm)
Re: [PATCH] i486 CR4 oops, no_console_suspend, H. Peter Anvin, (Wed Aug 20, 10:37 pm)