Re: [PATCH 0/9] -tip/apic merging one more series

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Cyrill Gorcunov <gorcunov@...>
Cc: <hpa@...>, <mingo@...>, <tglx@...>, <macro@...>, <linux-kernel@...>
Date: Sunday, August 17, 2008 - 5:53 pm

please check if you need { } otherwise you broke 64 bit


static int lapic_resume(struct sys_device *dev)
{
        unsigned int l, h;
        unsigned long flags;
        int maxlvt;

        if (!apic_pm_state.active)
                return 0;

        maxlvt = lapic_get_maxlvt();

        local_irq_save(flags);

#ifdef CONFIG_X86_64
        if (x2apic)
                enable_x2apic();
        else
#endif
                /*
                 * Make sure the APICBASE points to the right address
                 *
                 * FIXME! This will be wrong if we ever support suspend on
                 * SMP! We'll need to do this as part of the CPU restore!
                 */
                rdmsr(MSR_IA32_APICBASE, l, h);
                l &= ~MSR_IA32_APICBASE_BASE;
                l |= MSR_IA32_APICBASE_ENABLE | mp_lapic_addr;
                wrmsr(MSR_IA32_APICBASE, l, h);


YH
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/9] -tip/apic merging one more series, Cyrill Gorcunov, (Sun Aug 17, 3:41 pm)
Re: [PATCH 0/9] -tip/apic merging one more series, Yinghai Lu, (Sun Aug 17, 5:53 pm)
Re: [PATCH 0/9] -tip/apic merging one more series, Cyrill Gorcunov, (Mon Aug 18, 12:22 am)
Re: [PATCH 0/9] -tip/apic merging one more series, Ingo Molnar, (Mon Aug 18, 3:18 am)
Re: [PATCH 0/9] -tip/apic merging one more series, Ingo Molnar, (Mon Aug 18, 3:24 am)
Re: [PATCH 0/9] -tip/apic merging one more series, Cyrill Gorcunov, (Mon Aug 18, 3:41 am)
[PATCH 6/9] x86: apic - unify lapic_setup_esr, Cyrill Gorcunov, (Sun Aug 17, 3:41 pm)
[PATCH 9/9] x86: apic - generic_processor_info, Cyrill Gorcunov, (Sun Aug 17, 3:41 pm)
[PATCH 5/9] x86: apic - unify connect_bsp_APIC, Cyrill Gorcunov, (Sun Aug 17, 3:41 pm)
[PATCH 3/9] x86: apic - unify disable_local_APIC, Cyrill Gorcunov, (Sun Aug 17, 3:41 pm)
[PATCH 8/9] x86: apic - unify disconnect_bsp_APIC, Cyrill Gorcunov, (Sun Aug 17, 3:41 pm)
[PATCH 7/9] x86: apic - unify __setup_APIC_LVTT, Cyrill Gorcunov, (Sun Aug 17, 3:41 pm)
[PATCH 2/9] x86: apic - unify setup_boot_APIC_clock, Cyrill Gorcunov, (Sun Aug 17, 3:41 pm)
[PATCH 4/9] x86: apic - unify disable_local_APIC, Cyrill Gorcunov, (Sun Aug 17, 3:41 pm)
[PATCH 1/9] x86: apic - rearrange maxcpu definition, Cyrill Gorcunov, (Sun Aug 17, 3:41 pm)