login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
August
»
17
Re: [PATCH 3/5] ide: add a driver-wide debugging macro
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Joe Perches <joe@...>
To: Borislav Petkov <petkovbb@...>
Cc: <Bartlomiej@...>, <Zolnierkiewicz@...>, <bzolnier@...>, <linux-kernel@...>, <linux-ide@...>, Borislav Petkov <petkovbb@...>
Subject:
Re: [PATCH 3/5] ide: add a driver-wide debugging macro
Date: Sunday, August 17, 2008 - 2:13 pm
On Sun, 2008-08-17 at 19:23 +0200, Borislav Petkov wrote:
quoted text
> diff --git a/include/linux/ide.h b/include/linux/ide.h > index c161840..b6d714d 100644 > --- a/include/linux/ide.h > +++ b/include/linux/ide.h > [] > +/* DRV_NAME has to be defined in the driver before using the macro below */ > +#define __ide_debug_log(lvl, fmt, args...) \ > +{ \ > + if (unlikely(drive->debug_mask & lvl)) \ > + printk(KERN_INFO DRV_NAME ": " fmt, ## args); \ > +}
Shouldn't a debug printk use KERN_DEBUG? --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 0/5] ide debugging macros
, Borislav Petkov
, (Sun Aug 17, 1:23 pm)
Re: [PATCH 0/5] ide debugging macros
, Bartlomiej Zolnierkiewicz...
, (Mon Aug 18, 5:08 pm)
Re: [PATCH 0/5] ide debugging macros
, Borislav Petkov
, (Tue Aug 19, 2:23 am)
Re: [PATCH 0/5] ide debugging macros
, Borislav Petkov
, (Tue Aug 19, 2:15 am)
Re: [PATCH 0/5] ide debugging macros
, Bartlomiej Zolnierkiewicz...
, (Mon Aug 18, 5:29 pm)
[PATCH 5/5] ide-floppy: add a debug_mask module parameter
, Borislav Petkov
, (Sun Aug 17, 1:23 pm)
[PATCH 4/5] ide-floppy: convert driver to the new debugging ...
, Borislav Petkov
, (Sun Aug 17, 1:23 pm)
[PATCH 1/5] ide: unify conversion macros
, Borislav Petkov
, (Sun Aug 17, 1:23 pm)
[PATCH 3/5] ide: add a driver-wide debugging macro
, Borislav Petkov
, (Sun Aug 17, 1:23 pm)
Re: [PATCH 3/5] ide: add a driver-wide debugging macro
, Joe Perches
, (Sun Aug 17, 2:13 pm)
Re: [PATCH 3/5] ide: add a driver-wide debugging macro
, Borislav Petkov
, (Sun Aug 17, 2:24 pm)
[PATCH 2/5] ide: add drive->debug_mask switch
, Borislav Petkov
, (Sun Aug 17, 1:23 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg KH
[GIT PATCH] driver core patches against 2.6.24
Tarkan Erimer
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Amit K. Arora
[RFC] Heads up on sys_fallocate()
Chuck Ebbert
Why do so many machines need "noapic"?
git
:
linux-netdev
:
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller
[GIT]: Networking
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Natalie Protasevich
[BUG] New Kernel Bugs
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
0 users
and
434 guests
online.
Syndicate