[PATCH 1/9] ide: fix IDE ACPI for slave device-only configurations

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-ide@...>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@...>, <linux-kernel@...>
Date: Sunday, August 17, 2008 - 1:14 pm

ACPI _GTM / _PS0 / _STM were not called if only slave device was present.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/ide.c |   21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

Index: b/drivers/ide/ide.c
===================================================================
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -365,15 +365,15 @@ __IDE_DEVSET(pio_mode, 0, NULL, set_pio_
 
 static int generic_ide_suspend(struct device *dev, pm_message_t mesg)
 {
-	ide_drive_t *drive = dev->driver_data;
+	ide_drive_t *drive = dev->driver_data, *pair = ide_get_pair_dev(drive);
 	ide_hwif_t *hwif = HWIF(drive);
 	struct request *rq;
 	struct request_pm_state rqpm;
 	ide_task_t args;
 	int ret;
 
-	/* Call ACPI _GTM only once */
-	if (!(drive->dn % 2))
+	/* call ACPI _GTM only once */
+	if ((drive->dn & 1) == 0 || pair == NULL)
 		ide_acpi_get_timing(hwif);
 
 	memset(&rqpm, 0, sizeof(rqpm));
@@ -389,26 +389,25 @@ static int generic_ide_suspend(struct de
 
 	ret = blk_execute_rq(drive->queue, NULL, rq, 0);
 	blk_put_request(rq);
-	/* only call ACPI _PS3 after both drivers are suspended */
-	if (!ret && (((drive->dn % 2) && hwif->drives[0].present
-		 && hwif->drives[1].present)
-		 || !hwif->drives[0].present
-		 || !hwif->drives[1].present))
+
+	/* call ACPI _PS3 only after both devices are suspended */
+	if (ret == 0 && ((drive->dn & 1) || pair == NULL))
 		ide_acpi_set_state(hwif, 0);
+
 	return ret;
 }
 
 static int generic_ide_resume(struct device *dev)
 {
-	ide_drive_t *drive = dev->driver_data;
+	ide_drive_t *drive = dev->driver_data, *pair = ide_get_pair_dev(drive);
 	ide_hwif_t *hwif = HWIF(drive);
 	struct request *rq;
 	struct request_pm_state rqpm;
 	ide_task_t args;
 	int err;
 
-	/* Call ACPI _STM only once */
-	if (!(drive->dn % 2)) {
+	/* call ACPI _PS0 / _STM only once */
+	if ((drive->dn & 1) == 0 || pair == NULL) {
 		ide_acpi_set_state(hwif, 1);
 		ide_acpi_push_timing(hwif);
 	}
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/9] ide: fix IDE ACPI for slave device-only configur..., Bartlomiej Zolnierkiewicz..., (Sun Aug 17, 1:14 pm)
[PATCH 9/9] ide: remove superfluous -&gt;waiting_for_dma checks, Bartlomiej Zolnierkiewicz..., (Sun Aug 17, 1:15 pm)
[PATCH 8/9] ide: remove superfluous -&gt;dma field from ide_..., Bartlomiej Zolnierkiewicz..., (Sun Aug 17, 1:15 pm)
[PATCH 7/9] ide: remove superfluous -&gt;media field from id..., Bartlomiej Zolnierkiewicz..., (Sun Aug 17, 1:15 pm)
[PATCH 6/9] ide: DMA_PIO_RETRY -&gt; IDE_DFLAG_DMA_PIO_RETRY, Bartlomiej Zolnierkiewicz..., (Sun Aug 17, 1:15 pm)
[PATCH 5/9] ide: add device flags, Bartlomiej Zolnierkiewicz..., (Sun Aug 17, 1:15 pm)
[PATCH 4/9] ide-disk: add ide_do_setfeature() helper, Bartlomiej Zolnierkiewicz..., (Sun Aug 17, 1:15 pm)
Re: [PATCH 4/9] ide-disk: add ide_do_setfeature() helper, Sergei Shtylyov, (Wed Aug 20, 6:04 am)
[PATCH 3/9] ide-disk: remove stale init_idedisk_capacity() d..., Bartlomiej Zolnierkiewicz..., (Sun Aug 17, 1:15 pm)
[PATCH 2/9] ide-disk: set_addressing() fixes, Bartlomiej Zolnierkiewicz..., (Sun Aug 17, 1:15 pm)
Re: [PATCH 2/9] ide-disk: set_addressing() fixes, Sergei Shtylyov, (Sat Aug 23, 5:45 pm)
Re: [PATCH 2/9] ide-disk: set_addressing() fixes, Bartlomiej Zolnierkiewicz..., (Mon Aug 25, 4:23 pm)