Re: [PATCH] Make Dell keyboard repeat quirk apply to a wider range of hardware

Previous thread: [PATCH] HPET: Workaround for a BIOS workaround on AMD SB700 platform by crane cai on Wednesday, August 13, 2008 - 8:13 pm. (9 messages)

Next thread: SATA Cold Boot Problems with 2.6.27-rc[23] on nVidia 680i by Manny Maxwell on Wednesday, August 13, 2008 - 9:16 pm. (2 messages)
From: Matthew Garrett
Date: Wednesday, August 13, 2008 - 8:32 pm

Dell laptops fail to send key up events for several of their special 
keys. There's an existing quirk in the kernel to handle this, but it's 
limited to the Latitude range. This patch extends it to cover all 
portable Dells.

Signed-off-by: Matthew Garrett <mjg@redhat.com>

---
diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index b1ce10f..e32c24d 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -834,10 +834,10 @@ static void atkbd_disconnect(struct serio *serio)
 }
 
 /*
- * Most special keys (Fn+F?) on Dell Latitudes do not generate release
+ * Most special keys (Fn+F?) on Dell laptops do not generate release
  * events so we have to do it ourselves.
  */
-static void atkbd_latitude_keymap_fixup(struct atkbd *atkbd)
+static void atkbd_dell_laptop_keymap_fixup(struct atkbd *atkbd)
 {
 	const unsigned int forced_release_keys[] = {
 		0x85, 0x86, 0x87, 0x88, 0x89, 0x8a, 0x8b, 0x8f, 0x93,
@@ -1461,13 +1461,13 @@ static int __init atkbd_setup_fixup(const struct dmi_system_id *id)
 
 static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
 	{
-		.ident = "Dell Latitude series",
+		.ident = "Dell Laptop",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
-			DMI_MATCH(DMI_PRODUCT_NAME, "Latitude"),
+			DMI_MATCH(DMI_CHASSIS_TYPE, "8"), /* Portable */
 		},
 		.callback = atkbd_setup_fixup,
-		.driver_data = atkbd_latitude_keymap_fixup,
+		.driver_data = atkbd_dell_laptop_keymap_fixup,
 	},
 	{
 		.ident = "HP 2133",

-- 
Matthew Garrett | mjg59@srcf.ucam.org
--

From: Dmitry Torokhov
Date: Friday, August 15, 2008 - 12:04 pm

Applied to 'next', thank you Matthew.

-- 
Dmitry
--

Previous thread: [PATCH] HPET: Workaround for a BIOS workaround on AMD SB700 platform by crane cai on Wednesday, August 13, 2008 - 8:13 pm. (9 messages)

Next thread: SATA Cold Boot Problems with 2.6.27-rc[23] on nVidia 680i by Manny Maxwell on Wednesday, August 13, 2008 - 9:16 pm. (2 messages)