Re: [PATCH] msr: Fix NULL pointer deref due to msr_open on nonexistent CPUs

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Ingo Molnar

Subject: Re: [PATCH] msr: Fix NULL pointer deref due to msr_open on nonexistent CPUs

Date: Friday, August 15, 2008 - 4:38 am

* Darrick J. Wong <djwong@us.ibm.com> wrote:

quoted text> msr_open tests for someone trying to open a device for a nonexistent CPU.
> However, the function always returns 0, not ret like it should, hence userspace
> can BUG the kernel trivially.  This bug was introduced by the cdev lock_kernel
> pushdown patch last May.
> 
> The BUG can be reproduced with these commands:
> 
> # mknod fubar c 202 8 <-- pick a number less than NR_CPUS that is not
>                           the number of an online CPU
> # cat fubar

applied to tip/x86/urgent - thanks Darrick.

	Ingo
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] msr: Fix NULL pointer deref due to msr_open on non ..., Darrick J. Wong, (Thu Aug 14, 3:43 pm)

Re: [PATCH] msr: Fix NULL pointer deref due to msr_open on ..., Ingo Molnar, (Fri Aug 15, 4:38 am)

Re: [PATCH] msr: Fix NULL pointer deref due to msr_open on ..., Jonathan Corbet, (Fri Aug 15, 7:57 am)


linux-kernel:
Ingo Molnar	Re: [patch] e1000=y && e1000e=m regression fix
Greg Kroah-Hartman	[PATCH 20/36] Driver core: Call device_pm_add() after bus_add_device() in device_a...
Boaz Harrosh	how to use KBUILD_EXTRA_SYMBOLS
Brandeburg, Jesse	RE: [regression] e1000e broke e1000 (was: Re: [ANNOUNCE] e1000 toe1000e migration ...
Pekka Enberg	Re: [PATCH] include/linux/slab.h: new KFREE() macro.
git:
Bill Lear	cpio command not found
Jing Xue	Re: git rm --cached
Fredrik Kuivinen	Re: fatal: unable to create '.git/index': File exists
Johannes Schindelin	Re: [PATCH 1/3 v2] Implement the patience diff algorithm
Johannes Sixt	Re: How to pull remote branch with specified commit id?
linux-netdev:
Jamie Lokier	Re: POHMELFS high performance network filesystem. Transactions, failover, performa...
Oliver Neukum	Re: [RFC] Patch to option HSO driver to the kernel
Paulius Zaleckas	Re: [RFC] Patch to option HSO driver to the kernel
Timo Teräs	ip xfrm policy semantics
Ron Mercer	[net-next PATCH 2/2] qlge: Version change to v1.00.00.27
openbsd-misc:
Tomas Bodzar	Re: OpenSMTPd actual development and integration
Netmaffia.hu	Tini Lányok AKCIÓBAN OTTHON
Bryan Irvine	Re: DVD burn error: No space left on device
Sevan / Venture37	Re: This is what Linus Torvalds calls openBSD crowd
Siju George	This is what Linus Torvalds calls openBSD crowd
git-commits-head:
Linux Kernel Mailing List	powerpc/fsl_msi: enable msi allocation in all banks
Linux Kernel Mailing List	[ARM] mmp: avengers lite (pxa168) board bring up
Linux Kernel Mailing List	via82cxxx: add support for VT6415 PCIE PATA IDE Host Controller
Linux Kernel Mailing List	checkpatch: warn on declaration with storage class not at the beginning
Linux Kernel Mailing List	USB: remove duplicate entry in Option driver and Pl2303 driver for Huawei modem