linux-kernel mailing list

FromSubjectsort iconDate
J.A.
ath5k on the Acer Aspire One
Hi... I have just got a One, and have installed a standard distro (not Linpus), Mandriva in my case. Everything works pretty nicely but WiFi. Hardware is: 03:00.0 Ethernet controller: Atheros Communications Inc. AR242x 802.11abg Wireless PCI Express Adapter (rev 01) The driver used is ath5k. On load, it logs this: Aug 15 01:13:57 one klogd: ath5k_pci 0000:03:00.0: registered as 'phy0' Aug 15 01:13:57 one klogd: ath5k phy0: Support for RF2425 is under development. Aug 15 01:13:57 one ...
Aug 14, 4:51 pm 2008
David Woodhouse
[PATCH] Reduce brokenness of CRIS headers_install
I won't say 'fix', because they still look broken, although this will at least allow 'make ARCH=CRIS headers_install' to _complete_. For headers which are exported, we should probably choose between asm/arch-v10 and asm/arch-v32 by something that GCC defines -- we can't rely on a generated symlink. And we certainly can't export an arch/ directory which doesn't even exist. And the only thing that we seem to include from the arch/ directory is <asm/arch/ptrace.h> from <asm/ptrace.h> ... and ...
Aug 14, 3:55 pm 2008
Darrick J. Wong
[PATCH] msr: Fix NULL pointer deref due to msr_open on n ...
msr_open tests for someone trying to open a device for a nonexistent CPU. However, the function always returns 0, not ret like it should, hence userspace can BUG the kernel trivially. This bug was introduced by the cdev lock_kernel pushdown patch last May. The BUG can be reproduced with these commands: # mknod fubar c 202 8 <-- pick a number less than NR_CPUS that is not the number of an online CPU # cat fubar Signed-off-by: Darrick J. Wong ...
Aug 14, 3:43 pm 2008
David Witbrodt
Re: HPET regression in 2.6.26 versus 2.6.25 -- revert fo ...
Let's say I start with this: 1. 'git checkout v2.6.27-rc3' 2. [apply patch] 3. build kernel + reboot If the kernel locks up, you want me to: 4. [un-apply the patch] 5. 'git bisect start' 6. 'git bisect bad' Of course, we both hope that the kernel will NOT lock up, but let's say it does. My confusion is the what step to take next. To use 'git bisect' I have to select the next kernel version manually until I find a "good" and "bad" version... then git can automatically do its ...
Aug 14, 3:25 pm 2008
Steven Rostedt
[PATCH] ftrace: use only 5 byte nops for x86
Mathieu Desnoyers revealed a bug in the original code. The nop that is used to relpace the mcount caller can be a two part nop. This runs the risk where a process can be preempted after executing the first nop, but before the second part of the nop. The ftrace code calls kstop_machine to keep multiple CPUs from executing code that is being modified, but it does not protect against a task preempting in the middle of a two part nop. If the above preemption happens and the tracer is enabled, ...
Aug 14, 3:05 pm 2008
Jeremy Fitzhardinge
Re: [PATCH] ftrace: use only 5 byte nops for x86
Don't think that will help in general. qemu claims its a Pentium II. J --
Aug 14, 4:49 pm 2008
Rafael J. Wysocki
[PATCH 2/3] Adapt the sky2 driver to the reworked PCI PM
Adapt the sky2 driver to the reworked PCI PM * Use device_set_wakeup_enable() and friends as needed * Remove an open-coded reference to the standard PCI PM registers * Use pci_prepare_to_sleep() and pci_back_from_sleep() in the ->suspend() and ->resume() callbacks * Use the observation that it is sufficient to call pci_enable_wake() once, unless it fails Tested on Asus M3A32-MVP (Yukon-2 EC Ultra rev 3). Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> --- drivers/net/sky2.c | 34 ...
Aug 14, 2:38 pm 2008
Jeff Kirsher
Re: [PATCH 3/3] Adapt the e100 driver to the reworked PCI PM
We have tested the patch in our labs and systems wake from S5 just fine. Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> -- Cheers, Jeff --
Aug 14, 4:56 pm 2008
Rafael J. Wysocki
[PATCH 0/3] Adapt three network drivers to the reworked PCI PM
Hi, After the PCI PM core code has been updated, PCI network drivers (especially those using pci_enable_wake() for setting up WOL) should be adapted to it. This series of patches modifies three drivers, skge, sky2 and e100, for this purpose. [Note for Andrew: Patch 1/3 has been in -mm for some time, but the present one has a better changelog (IMO).] Please consider for applying. Thanks, Rafael --
Aug 14, 2:35 pm 2008
Stephen Hemminger
Re: [PATCH 2/3] Adapt the sky2 driver to the reworked PCI PM
On Thu, 14 Aug 2008 23:38:17 +0200 There was a regression in earlier releases caused because some BIOS's are wrong, and device can wakeup. --
Aug 14, 3:23 pm 2008
Rafael J. Wysocki
[PATCH 3/3] Adapt the e100 driver to the reworked PCI PM
[Note: I have no hardware to test this patch, but it seems pretty straightforward.] Adapt the e100 driver to the reworked PCI PM * Use device_set_wakeup_enable() and friends as needed * Use pci_pme_active() to clear PME_Status and disable PME# * Use the observation that it is sufficient to call pci_enable_wake() once, unless it fails Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> --- drivers/net/e100.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 ...
Aug 14, 2:40 pm 2008
Rafael J. Wysocki
[PATCH 1/3] Adapt the skge driver to the reworked PCI PM
From: Rafael J. Wysocki <rjw@sisk.pl> Adapt the skge driver to the reworked PCI PM * Use device_set_wakeup_enable() and friends as needed * Remove an open-coded reference to the standard PCI PM registers * Use pci_prepare_to_sleep() and pci_back_from_sleep() in the ->suspend() and ->resume() callbacks * Use the observation that it is sufficient to call pci_enable_wake() once, unless it fails Tested on Asus L5D (Yukon-Lite rev 7). Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> --- ...
Aug 14, 2:37 pm 2008
H. Peter Anvin
Re: [PATCH] x86 alternatives : fix LOCK_PREFIX race with ...
Yeah, although the LOCK prefix was measurable. -hpa --
Aug 14, 2:43 pm 2008
Mathieu Desnoyers
[PATCH] x86 alternatives : fix LOCK_PREFIX race with pre ...
If a kernel thread is preempted in single-cpu mode right after the NOP (nop about to be turned into a lock prefix), then we CPU hotplug a CPU, and then the thread is scheduled back again, a SMP-unsafe atomic operation will be used on shared SMP variables, leading to corruption. No corruption would happen in the reverse case : going from SMP to UP is ok because we split a bit instruction into tiny pieces, which does not present this condition. Changing the 0x90 (single-byte nop) currently used ...
Aug 14, 1:58 pm 2008
Andi Kleen
Re: [PATCH] x86 alternatives : fix LOCK_PREFIX race with ...
My understanding was that the nops only make a measurable difference in the -pg/mcount/ftrace patched out case where every function call starts with a 5 byte nop. Presumably function calls are much more common than lock prefix operations. -Andi --
Aug 14, 2:20 pm 2008
Nilay DORSA
Son Veda Şarkısı Ayrı Kalanlar , Ayrılanlar İçin...
Arkadaşlar Rastgele İnternette Dolaşırken Buldum Ben Çok Geç Kalmışım Benim Arkadaşlarımda Dinliyormuş. Hiç Bana Söylemedi Uyuzlar :( Bende Herkezle Paylaşmak İstedim Ben Çok Sevdim Sizinde Çok Seveceğinize Eminim.. Korkmayın Ben Norton İle Tarattım Temiz ve Ayrıca Kendim Yeniden Upload Ettim... http://rapidshare.com/files/137322215/hakanergun-sonveda.mp3 Saygılarımla Mutlu Kalın : ) --
Aug 14, 11:38 am 2008
Aristeu Rozanski
[PATCH] perfctr: don't use CCCR_OVF_PMI1 on Pentium 4Ds
Currently, setup_p4_watchdog() use CCCR_OVF_PMI1 to enable the counter overflow interrupts to the second logical core. But this bit doesn't work on Pentium 4 Ds (model 4, stepping 4) and this patch avoids its use on these processors. Tested on 4 different machines that have this specific model with success. Signed-off-by: Aristeu Rozanski <aris@redhat.com> --- arch/x86/kernel/cpu/perfctr-watchdog.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) --- ...
Aug 14, 1:32 pm 2008
Balbir Singh
Re: [PATCH 1/1] mm_owner: fix cgroup null dereference
Thanks for catching this Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com> -- Balbir --
Aug 14, 1:58 pm 2008
Jiri Slaby
[PATCH 1/1] mm_owner: fix cgroup null dereference
Hi, found this in mmotm, a fix for mm-owner-fix-race-between-swap-and-exit.patch -- mm->owner is set to NULL prior to calling cgroup_mm_owner_callbacks, but it should be set after that to not pass NULL pointer as the old owner which otherwise results in an oops (shortened): BUG: unable to handle kernel NULL pointer dereference at 0000000000000580 Oops: 0000 [1] SMP Pid: 3396, comm: nscd Tainted: G W 2.6.27-rc3-mm1_64 #439 RIP: 0010:[<ffffffff8027035a>] [<ffffffff8027035a>] ...
Aug 14, 1:16 pm 2008
Daniel J Blueman
[2.6.27-rc3] XFS logbsize/logbufs option problem...
When the logbsize (eg =256k) or logbufs (eg =8) XFS mount options are present in /etc/fstab, the filesystem fails to mount r/w with 2.6.27-rc3, so stays read-only. This seems to be a regression over 2.6.27-rc1 (didn't check -rc2). I'm testing on Ubuntu Intrepid x86-64, thus filesystem was constructed with xfsprogs 2.9.8-1. Have you seen encountered this issue at all? Many thanks, Daniel -- Daniel J Blueman --
Aug 14, 12:55 pm 2008
Christoph Hellwig
Re: [2.6.27-rc3] XFS logbsize/logbufs option problem...
Yes, this is a known issues, and I have a patch for it that I'm about to resubmit after fixing up some comments. --
Aug 14, 1:21 pm 2008
Steven Rostedt
[PATCH v2 0/6] ftrace: to kill a daemon (small updates)
[ Changes since v1: regex fix in x86_64 recordmcount.pl. Now it can handle all mcount+0x... mcount-0x... and mcount, where as the original only handled mcount+0x... Made mcount on start-up to simply return. The current mcount is set up to be replaced with a call to ftrace_record_ip. This is no longer necessary. Note: This patch series is focusing on how calls to mcount in the kernel are converted to nops. It does not address what kind of nop ...
Aug 14, 12:45 pm 2008
Steven Rostedt
[PATCH v2 5/6] ftrace: enable using mcount recording on x86
Enable the use of the __mcount_loc infrastructure on x86_64 and i386. Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- arch/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) Index: linux-tip.git/arch/x86/Kconfig =================================================================== --- linux-tip.git.orig/arch/x86/Kconfig 2008-08-14 13:55:03.000000000 -0400 +++ linux-tip.git/arch/x86/Kconfig 2008-08-14 14:05:05.000000000 -0400 @@ -25,6 +25,7 @@ config X86 select HAVE_KPROBES ...
Aug 14, 12:45 pm 2008
Steven Rostedt
[PATCH v2 2/6] ftrace: mcount call site on boot nops core
This is the infrastructure to the converting the mcount call sites recorded by the __mcount_loc section into nops on boot. It also allows for using these sites to enable tracing as normal. When the __mcount_loc section is used, the "ftraced" kernel thread is disabled. This uses the current infrastructure to record the mcount call sites as well as convert them to nops. The mcount function is kept as a stub on boot up and not converted to the ftrace_record_ip function. We use the ftrace_record_ip ...
Aug 14, 12:45 pm 2008
Steven Rostedt
[PATCH v2 1/6] ftrace: create __mcount_loc section
[ Note: after this patch is applied, you need to run: chmod +x scripts/recordmcount.pl ] This patch creates a section in the kernel called "__mcount_loc". This will hold a list of pointers to the mcount relocation for each call site of mcount. For example: objdump -dr init/main.o [...] Disassembly of section .text: 0000000000000000 <do_one_initcall>: 0: 55 push %rbp [...] 000000000000017b <init_post>: 17b: 55 push ...
Aug 14, 12:45 pm 2008
Steven Rostedt
[PATCH v2 6/6] ftrace: x86 mcount stub
x86 now sets up the mcount locations through the build and no longer needs to record the ip when the function is executed. This patch changes the initial mcount to simply return. There's no need to do any other work. If the ftrace start up test fails, the original mcount will be what everything will use, so having this as fast as possible is a good thing. Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- arch/x86/kernel/entry_32.S | 14 -------------- arch/x86/kernel/entry_64.S | ...
Aug 14, 12:45 pm 2008
Steven Rostedt
Re: [PATCH v2 3/6] ftrace: enable mcount recording for modules
Thanks, But I find the if is a bit more clear. It may confuse code reviewers if we expect them to know that sechdrs[0].sh_size is zero. This isn't a hot path. -- Steve --
Aug 14, 4:40 pm 2008
Rusty Russell
Re: [PATCH v2 3/6] ftrace: enable mcount recording for modules
You don't actually need the if. The size of section 0 is 0. Rusty. --
Aug 14, 4:26 pm 2008
Steven Rostedt
[PATCH v2 3/6] ftrace: enable mcount recording for modules
This patch enables the loading of the __mcount_section of modules and changing all the callers of mcount into nops. The modification is done before the init_module function is called, so again, we do not need to use kstop_machine to make these changes. Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- include/linux/ftrace.h | 3 +++ kernel/module.c | 11 +++++++++++ kernel/trace/ftrace.c | 5 +++++ 3 files changed, 19 insertions(+) Index: ...
Aug 14, 12:45 pm 2008
Steven Rostedt
[PATCH v2 4/6] ftrace: rebuild everything on change to F ...
When enabling or disabling CONFIG_FTRACE_MCOUNT_RECORD, we want a full kernel compile to handle the adding of the __mcount_loc sections. Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- include/linux/kernel.h | 5 +++++ 1 file changed, 5 insertions(+) Index: linux-tip.git/include/linux/kernel.h =================================================================== --- linux-tip.git.orig/include/linux/kernel.h 2008-08-14 13:55:12.000000000 -0400 +++ ...
Aug 14, 12:45 pm 2008
Dave Jones
silence mmconfig printk.
There's so much broken mmconfig hardware/bios'es out there, that classing this as an error seems a little extreme. Lower its priority to KERN_INFO so that it isn't so noisy when booting with 'quiet' Signed-off-by: Dave Jones <davej@redhat.com> diff -up linux-2.6.26.noarch/arch/x86/pci/mmconfig-shared.c.jx linux-2.6.26.noarch/arch/x86/pci/mmconfig-shared.c --- linux-2.6.26.noarch/arch/x86/pci/mmconfig-shared.c.jx 2008-08-12 14:03:38.000000000 -0400 +++ ...
Aug 14, 12:07 pm 2008
Daniel J Blueman
Re: ALC883 recording troubles...
Hi Takashi, I am still finding this recording +ve saturation on my ALC883 Intel HDA sound device with 2.6.27-rc3 (ie ALSA 1.0.17 drivers) and ALSA 1.0.16-1 libraries on Ubuntu Intrepid. The previous workaround still 'gets us out of jail': # ./hda-verb /dev/snd/hwC0D0 0x23 SET_AMP_GAIN_MUTE 0x7180 nid = 0x23, verb = 0x300, param = 0x7180 value = 0x0 Note, we see this message "hda_codec: Unknown model for ALC883, trying auto-probe from BIOS..." as before on this Asus P5E-VM ...
Aug 14, 12:10 pm 2008
Stefan Richter
New Linux FireWire wiki
Hi all, there is now a new wiki with information about the Linux FireWire/ IEEE 1394 kernel drivers and related userspace software: http://ieee1394.wiki.kernel.org/ Its current content is almost identical with (although already more up-to-date than) wiki.linux1394.org. You will discover quickly why I made the move if you look at the RecentChanges or TitleIndex of wiki.linux1394.org. I hope you will find the new wiki useful (or if not, make it useful). -- Stefan ...
Aug 14, 11:50 am 2008
Cyrill Gorcunov
[patch 0/8] [RFC -tip] another one step toward APIC merging
Hi, here are the series of patches to help APIC code merging. I've more patches in my queue (~20 for now). But I still playing with them so they too much ugly to be even tested. The patch with subject x86: apic - do not clear APIC twice in lapic_shutdown actually is not merge-helper but rather I found a bit strange of double clearing of APIC in 32bit code. As always I would really appreciate any comments on this series. The patches are over -tip/master commit ...
Aug 14, 11:34 am 2008
Sven Wegener
Re: [regression?] [resend] Memory zone info seems incomp ...
Could you make sure DEBUG_MEMORY_INIT is activated (it should, if you've not chosen the embedded feature) and boot with mminit_loglevel=3 and see if you get the ouput you want. Sven --
Aug 14, 12:08 pm 2008
Andrew Morton
Re: [regression?] [resend] Memory zone info seems incomp ...
On Thu, 14 Aug 2008 20:42:23 +0200 It could be deliberate, I forget. Maybe we trimmed nr_nodemap_entries --
Aug 14, 12:13 pm 2008
Frans Pop
[regression?] [resend] Memory zone info seems incomplete ...
With 2.6.26 I get: <snip> Zone PFN ranges: DMA 0 -> 4096 DMA32 4096 -> 1048576 Normal 1048576 -> 1048576 Movable zone start PFN for each node early_node_map[4] active PFN ranges 0: 0 -> 159 0: 256 -> 521844 0: 521961 -> 521964 0: 521983 -> 521984 On node 0 totalpages: 521751 DMA zone: 56 pages used for memmap DMA zone: 1271 pages reserved DMA zone: 2672 pages, LIFO batch:0 DMA32 zone: 7081 pages used for ...
Aug 14, 11:42 am 2008
Frans Pop
Re: [regression?] [resend] Memory zone info seems incomp ...
That gives me: On node 0 totalpages: 521751 mminit::memmap_init DMA zone: 88 pages used for memmap mminit::memmap_init DMA zone: 1839 pages reserved DMA zone: 2072 pages, LIFO batch:0 mminit::memmap_init Initialising map node 0 zone 0 pfns 0 -> 4096 mminit::memmap_init DMA32 zone: 11127 pages used for memmap DMA32 zone: 506625 pages, LIFO batch:31 mminit::memmap_init Initialising map node 0 zone 1 pfns 4096 -> 521984 mminit::memmap_init Normal zone: 0 pages used for ...
Aug 14, 1:46 pm 2008
Hugh Dickins
oops in proc_sys_compare
I got this oops below, after several hours of swap-heavy kernel builds in tmpfs, on 2.6.27-rc1-mm1 a couple of weeks ago. Tried to reproduce it without success, then got a very similar trace (not saved) from 2.6.27-rc3 itself doing the same test yesterday: again oopsing in proc_sys_compare on address -16, looks like it's trying for PROC_I(dentry->d_inode)->sysctl but d_inode is NULL. I looked to see what's been going on in fs/proc recently, and your [PATCH] sanitize proc_sysctl ...
Aug 14, 11:31 am 2008
David Witbrodt
Re: HPET regression in 2.6.26 versus 2.6.25 -- revert fo ...
First, I apologize. I see that you were assuming I had KEXEC enabled when you gave me the patch against 2.6.27-rc3. I have only posted parts of my custom .config to LKML, thinking that posting the whole thing was not appropriate. Did you mean CRASH_DUMP instead of "kdump" above? [N] kexec system call (CONFIG_KEXEC) (bool) (Help) [N] kernel crash dumps (EXPERIMENTAL) (CONFIG_CRASH_DUMP) (bool) (Help) My custom .config has both of these disabled -- either because they default to ...
Aug 14, 11:11 am 2008
Yinghai Lu
Re: HPET regression in 2.6.26 versus 2.6.25 -- revert fo ...
just like the old way doing git-bisect, but before compiling, apply the batch, and before git-bisect good or bad, revert the patch. YH --
Aug 14, 11:29 am 2008
Lennart Sorensen
Re: Help writing kernel module...
Don't know. Of course really why would you care if a module of a certain name is loaded. You should only care that a module providing the function you want is loaded. Perhaps you need to explain what you are trying to do. -- Len Sorensen --
Aug 14, 12:44 pm 2008
Lennart Sorensen
Re: Help writing kernel module...
Use a symbol exported by that other module and your module should automatically depend on that module and modprobe will nicely load it before your module for you. -- Len Sorensen --
Aug 14, 11:02 am 2008
Ryan Hope
Help writing kernel module...
I can't find any information on how to make a kernel module load another module. Can someone please tell me how to do this? Thanks in advance. -Ryan --
Aug 14, 11:00 am 2008
Ryan Hope
Re: Help writing kernel module...
what about if I want to determine if a module is loaded? On Thu, Aug 14, 2008 at 2:02 PM, Lennart Sorensen --
Aug 14, 12:01 pm 2008
Mihaela Grigore
self-modifying code in 2.6 kernel for ppc writes into re ...
Hello, There is a piece of code in the early initialization of the 2.6 kernel that identifies the cpu type and then tries to eliminate code that does not apply to the current cpu. This is done by writing nop's over sections of code that are not needed (do_cpu_ftr_fixups in arch/ppc/kernel/misc.S) When I try to run the kernel in a ppc emulator, I get a segmentation fault in do_cpu_ftr_fixups. From examining the section headers of the vmlinux, the text section is marked as readonly. The piece ...
Aug 14, 10:57 am 2008
Joerg Roedel
[PATCH 0/4] AMD IOMMU updates for 2.6.27-rc3
Hi Ingo, here are 4 update patches for AMD IOMMU which should be merged in 2.6.27. They fix various issues that came up during tests. They also fix some minor style issues. Joerg git diff --stat tip/master.. : arch/x86/kernel/amd_iommu.c | 19 +++++++++++-------- arch/x86/kernel/amd_iommu_init.c | 24 +++++++++++++++++++++--- include/asm-x86/amd_iommu_types.h | 8 +++++--- 3 files changed, 37 insertions(+), 14 deletions(-) --
Aug 14, 10:55 am 2008
Joerg Roedel
[PATCH 1/4] AMD IOMMU: use status bit instead of memory ...
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com> --- arch/x86/kernel/amd_iommu.c | 17 ++++++++++------- include/asm-x86/amd_iommu_types.h | 4 ++++ 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c index 22d7d05..028e945 100644 --- a/arch/x86/kernel/amd_iommu.c +++ b/arch/x86/kernel/amd_iommu.c @@ -101,16 +101,13 @@ static int iommu_queue_command(struct amd_iommu *iommu, struct iommu_cmd *cmd) */ static ...
Aug 14, 10:55 am 2008
Ingo Oeser
Re: [PATCH 1/4] AMD IOMMU: use status bit instead of mem ...
Hi Joerg, Could you elaborate, why you had to remove this? Busy waiting loops should always do cpu_relay() Best Regards Ingo Oeser --
Aug 14, 11:35 am 2008
Joerg Roedel
[PATCH 3/4] AMD IOMMU: replace LOW_U32 macro with generi ...
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com> --- arch/x86/kernel/amd_iommu.c | 2 +- include/asm-x86/amd_iommu_types.h | 3 --- 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c index 028e945..de39e1f 100644 --- a/arch/x86/kernel/amd_iommu.c +++ b/arch/x86/kernel/amd_iommu.c @@ -164,7 +164,7 @@ static int iommu_queue_inv_iommu_pages(struct amd_iommu *iommu, address &= PAGE_MASK; CMD_SET_TYPE(&cmd, ...
Aug 14, 10:55 am 2008
Joerg Roedel
[PATCH 4/4] AMD IOMMU: initialize dma_ops after sysfs re ...
If sysfs registration fails all memory used by IOMMU is freed. This happens after dma_ops initialization and the functions will access the freed memory then. Fix this by initializing dma_ops after the sysfs registration. Signed-off-by: Joerg Roedel <joerg.roedel@amd.com> --- arch/x86/kernel/amd_iommu_init.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c index ceba338..a69cc0f 100644 --- ...
Aug 14, 10:55 am 2008
Joerg Roedel
[PATCH 2/4] AMD IOMMU: initialize device table properly
This patch adds device table initializations which forbids memory accesses for devices per default and disables all page faults. Signed-off-by: Joerg Roedel <joerg.roedel@amd.com> --- arch/x86/kernel/amd_iommu_init.c | 18 ++++++++++++++++++ include/asm-x86/amd_iommu_types.h | 1 + 2 files changed, 19 insertions(+), 0 deletions(-) diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c index d9a9da5..ceba338 100644 --- a/arch/x86/kernel/amd_iommu_init.c +++ ...
Aug 14, 10:55 am 2008
Joerg Roedel
Re: [PATCH 1/4] AMD IOMMU: use status bit instead of mem ...
I removed it because its not idling anymore in that loop imho. It reads data from MMIO and does a small calculation with it. Joerg --
Aug 14, 1:02 pm 2008
Ingo Oeser
Re: [PATCH REVIEW] udf: Fix lock inversion between iprun ...
Hi Jan, What about moving the allocation before taking the mutex? That way, we even reduce the lock contention and simplify the failure path. Signed-off-by: Ingo Oeser <ioe-lkml@rameria.de> diff --git a/fs/udf/ialloc.c b/fs/udf/ialloc.c index eb9cfa2..76446eb 100644 --- a/fs/udf/ialloc.c +++ b/fs/udf/ialloc.c @@ -90,6 +90,25 @@ struct inode *udf_new_inode(struct inode *dir, int mode, int *err) return NULL; } + if (UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_USE_EXTENDED_FE)) ...
Aug 14, 11:48 am 2008
Jan Kara
[PATCH REVIEW] udf: Fix lock inversion between iprune_mu ...
A memory allocation inside alloc_mutex must not recurse back into the filesystem itself because that leads to lock inversion between iprune_mutex and alloc_mutex (and thus to deadlocks - see traces below). Make allocations inside alloc_mutex use GFP_NOFS to avoid this problem. tar D ffff81015b9c8c90 0 6614 6612 ffff8100d5a21a20 0000000000000086 0000000000000000 00000000ffff0000 ffff81015b9c8c90 ffff81015b8f0cd0 ffff81015b9c8ee0 0000000000000000 0000000000000003 ...
Aug 14, 10:49 am 2008
Ulrich Drepper
AT_EXECFN not useful
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I've just removed the support for AT_EXECFN again from glibc. The information isn't useful because the path name isn't normalized. I.e., it's not the actual binary path if symlinks are followed during the resolution. This makes it unusable for the $ORIGIN handling. This is on top of the problem with relative paths. Unless somebody has another use case where this is useful I suggest removing AT_EXECFN support again. It's just superfluous work ...
Aug 14, 10:15 am 2008
Mihai Moldovan
[PROBLEM] Kernel crashes with 2.6.25-rc1 and above
Dear Kernel Hackers, as indicated in the Subject line, I've got some sort of problem. All Kernel above (and equal) 2.6.25-rc1 are crashing on my Notebook after a *random* time, thus preventing me of using them. When I first noticed that problem, I tried to get some usable result by bisecting the Kernel, but after 2 weeks of bisecting only, I've given up. My machine locks up after a random amount of uptime, and this is a real problem. Before bisecting, I thought that this time would be ...
Aug 14, 10:06 am 2008
Randy Dunlap
Re: Would it be better for git-commits-head to have -M - ...
or the git-commits list could use what Linus has requested to be used in pull requests: Please use "git diff -M --stat --summary" to generate the diffstat: the -M enables rename detection, and the summary enables a summary of new/deleted or renamed files. --- ~Randy Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA http://linuxplumbersconf.org/ --
Aug 14, 10:15 am 2008
James Cloos
Would it be better for git-commits-head to have -M -C diffs?
Would anyone else prefer to see the posts on the commits list use git's copy and move detection? Git show (used by the feed-mail-list script) does support -M and -C. It does affect the stat section. The recent commit 758db3f21187 would have had its stat changed from looking like: arch/h8300/include/asm/Kbuild | 1 + arch/h8300/include/asm/a.out.h | 20 ++ arch/h8300/include/asm/atomic.h | 144 +++++++++++ . ...
Aug 14, 9:56 am 2008
David Woodhouse
Re: Would it be better for git-commits-head to have -M - ...
I see no particular reason not to do that. I've spent the whole day screwing with magic git scripts on master.kernel.org, fixing the It would be nice, but I'm not sure it's a good idea. They aren't always valid email addresses. Maybe a Reply-To: header, rather than From: ? -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation --
Aug 14, 3:09 pm 2008
Rick Jones
[ANNOUNCE] pcitop - PCI* bus utilization tool
Folks A new tool that may be of interest to those doing I/O performance has just been released: http://pcitop.berlios.de/ There is descriptive text at the URL. In a nutshell, in its current form the tool can be used to show PCI* bus utilization on HP Integrity systems running Linux. It is anticipated that the functionality will be extended to other platforms as the required knowledge becomes available. Any assistance in this will be most appreciated :) happy benchmarking, rick ...
Aug 14, 10:04 am 2008
Jiri Slaby
[PATCH 1/1] NET: e100, fix iomap read
There were 2 omitted readb's used on an iomap space. eliminate them by using ioread8 instead. Signed-off-by: Jiri Slaby <jirislaby@gmail.com> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com> Cc: Bruce Allan <bruce.w.allan@intel.com> Cc: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com> Cc: John Ronciak <john.ronciak@intel.com> --- drivers/net/e100.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e100.c ...
Aug 14, 9:27 am 2008
Brandeburg, Jesse
RE: [PATCH 1/1] NET: e100, fix iomap read
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --
Aug 14, 9:29 am 2008
Jiri Slaby
[PATCH 2/3] Char: sx, fix io unmapping
board->base is increased for CF cards after mapping. Use board->base2 for unmapping the region, since it holds the original/correct address. Signed-off-by: Jiri Slaby <jirislaby@gmail.com> Cc: R.E.Wolff@BitWizard.nl --- drivers/char/sx.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/sx.c b/drivers/char/sx.c index c385206..5b8d7a1 100644 --- a/drivers/char/sx.c +++ b/drivers/char/sx.c @@ -2504,7 +2504,7 @@ static void __devexit ...
Aug 14, 9:25 am 2008
Jiri Slaby
[PATCH 3/3] Char: sx, remove bogus iomap
readl/writel are not expected to accept iomap return value. Replace bogus mapping by standard ioremap. Signed-off-by: Jiri Slaby <jirislaby@gmail.com> Cc: R.E.Wolff@BitWizard.nl --- drivers/char/sx.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/char/sx.c b/drivers/char/sx.c index 5b8d7a1..ba4e862 100644 --- a/drivers/char/sx.c +++ b/drivers/char/sx.c @@ -2504,7 +2504,7 @@ static void __devexit sx_remove_card(struct sx_board *board, ...
Aug 14, 9:25 am 2008
Jiri Slaby
[PATCH 1/3] Char: cyclades, remove bogus iomap
readl/writel are not expected to accept iomap return value. Replace bogus mapping by standard ioremap. Signed-off-by: Jiri Slaby <jirislaby@gmail.com> --- drivers/char/cyclades.c | 21 ++++++++++++--------- 1 files changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/char/cyclades.c b/drivers/char/cyclades.c index 33737bb..6e480e8 100644 --- a/drivers/char/cyclades.c +++ b/drivers/char/cyclades.c @@ -4976,12 +4976,14 @@ static int __devinit cy_pci_probe(struct pci_dev *pdev, ...
Aug 14, 9:25 am 2008
Ulrich Drepper
[PATCH] MAP_GROWSUP & MAP_GROWSDOWN removal
Arjan's mail the other day in which he foolishly tried to advocate the use of MAP_GROWSDOWN reminded me that I wanted to see these flags removed for some time. The mail just made it clear that it's quite important if even kernel people don't realize how dangerous the flags are. I looked around and found, beside LinuxThreads, just one user of the flag. This code is broken, will likely not work, and will just compile fine when I remove the flags from the glibc headers. What is proposed here is ...
Aug 14, 8:19 am 2008
Alan Cox
Re: [PATCH] MAP_GROWSUP & MAP_GROWSDOWN removal
The functionality is used by the kernel internally anyway so there is no point removing it as it has no cost at all. You can equally call "reboot" by mistake or strcpy with wrong parameters. The interface is also part of our historic ABI/API so shouldn't just get booted out. You might not like it, and it might not be very useful but thats true of stuff like readahead() as well. Alan --
Aug 14, 1:30 pm 2008
Takashi Iwai
[GIT PULL] ALSA fix for 2.6.27-rc3
Linus, please pull ALSA update for 2.6.27-rc3 from: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git for-linus containing the following change. This is an additional support of a missing model, so fairly safe to apply. Thanks! Takashi === Clemens Ladisch (1): ALSA: virtuoso: add Xonar D1 support Documentation/sound/alsa/ALSA-Configuration.txt | 10 +--- sound/pci/Kconfig | 2 +- sound/pci/oxygen/virtuoso.c ...
Aug 14, 8:36 am 2008
Pavel Machek
PM_TRACE is no longer experimental
PM_TRACE is stable for quite long. I don't think it needs to depend on experimental. Signed-off-by: Pavel Machek <pavel@suse.cz> --- commit 710f4e9070c453e743fcfa1a6017075026c4967b tree 7f3fe656004f2d21b6a9cbe1264f9f2236572456 parent ea977ecb4f994b0dc2e09cab3dbba87aad030d99 author Pavel <pavel@amd.ucw.cz> Thu, 14 Aug 2008 17:18:07 +0200 committer Pavel <pavel@amd.ucw.cz> Thu, 14 Aug 2008 17:18:07 +0200 kernel/power/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 ...
Aug 14, 8:18 am 2008
Pavel Machek
arch/x86/Kconfig: clean up, experimental adjustement
Adjust experimental tags in Kconfig, update config to notice that i386/x86_64 is now single architecture. Signed-off-by: Pavel Machek <pavel@suse.cz> --- commit ea977ecb4f994b0dc2e09cab3dbba87aad030d99 tree 95db6fca54f0aa0bbe0e9cb7f83e87b56c004413 parent a1d270d84974135ba67bc83fd6498bd580ada373 author Pavel <pavel@amd.ucw.cz> Thu, 14 Aug 2008 17:15:59 +0200 committer Pavel <pavel@amd.ucw.cz> Thu, 14 Aug 2008 17:15:59 +0200 arch/x86/Kconfig | 8 ++++---- 1 files changed, 4 ...
Aug 14, 8:16 am 2008
Ingo Molnar
Re: [PATCH] sched: fix rt-bandwidth hotplug race
applied to tip/sched/urgent - thanks! Ingo --
Aug 14, 6:51 am 2008
Peter Zijlstra
[PATCH] sched: fix rt-bandwidth hotplug race
Subject: sched: fix rt-bandwidth hotplug race From: Peter Zijlstra <a.p.zijlstra@chello.nl> Date: Thu Aug 14 15:42:44 CEST 2008 When we hot-unplug a cpu and rebuild the sched-domain, all cpus will be detatched. Alex observed the case where a runqueue was stealing bandwidth from an already disabled runqueue to satisfy its own needs. Stop this by skipping over already disabled runqueues. Reported-by: Alex Nixon <alex.nixon@citrix.com> Signed-off-by: Peter Zijlstra ...
Aug 14, 6:49 am 2008
James Morris
[GIT] capability fix for 2.6.27
Hi Linus, Please pull this fix from David Howells: Fix the setting of PF_SUPERPRIV by __capable() as it could corrupt the flags the target process if that is not the current process and it is trying to change its own flags in a different way at the same time. The approach taken involves cleanly separating the way capabilities are checked so that capable() now only refers to the current task and assumes the capability is about to be used, while has_capability() is used to ...
Aug 14, 6:45 am 2008
Ingo Molnar
[PATCH] irq: sparse irqs, fix #3
From 1b53f0444df394e4448ba56694f0bc4dda2bece0 Mon Sep 17 00:00:00 2001 From: Ingo Molnar <mingo@elte.hu> Date: Thu, 14 Aug 2008 16:07:04 +0200 Subject: [PATCH] irq: sparse irqs, fix #3 fix non-APIC UP build: arch/x86/kernel/built-in.o: In function `setup_arch': : undefined reference to `pin_map_size' arch/x86/kernel/built-in.o: In function `setup_arch': : undefined reference to `first_free_entry' Signed-off-by: Ingo Molnar <mingo@elte.hu> --- arch/x86/kernel/setup.c | 2 ++ 1 ...
Aug 14, 7:07 am 2008
Eric W. Biederman
Re: [PATCH 00/53] dyn_array/nr_irqs/sparse_irq support v10
I did: struct irq_desc { struct irq irq; .... } Then to_idesc is just a container_of call. Or simply a type cast but that is rude. Having nr be a field in struct irq is possibly valid. When last we talked about the design Linus was emphatic that what gets exposed to drivers be an opaque token. When I looked for 99%+ of the arch code we can use that same opaque token. irq_desc is something we don't really care about except in do_IRQ(). So I guess the truly ...
Aug 14, 4:55 pm 2008
Ingo Molnar
[PATCH] irq: sparse irqs, export nr_irqs
From c239ac14984518f2f3b7a920367c79bb6c3180e4 Mon Sep 17 00:00:00 2001 From: Ingo Molnar <mingo@elte.hu> Date: Thu, 14 Aug 2008 15:58:26 +0200 Subject: [PATCH] irq: sparse irqs, export nr_irqs fix: Building modules, stage 2. MODPOST 458 modules ERROR: "nr_irqs" [drivers/serial/8250.ko] undefined! Signed-off-by: Ingo Molnar <mingo@elte.hu> --- kernel/irq/handle.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kernel/irq/handle.c ...
Aug 14, 6:57 am 2008
Eric W. Biederman
Re: [PATCH] irq: sparse irqs, fix #2
Unfortunate gradual accreation of functionality. vector_allocation_domain could perhaps be better named. Round up this cpu to the set of cpus I need to allocate a vector on. Eric --
Aug 14, 10:03 am 2008
Ingo Molnar
[PATCH] irq: sparse irqs, fix #2
From 28f153577fc82ff93cd63472134b40f0634bff70 Mon Sep 17 00:00:00 2001 From: Ingo Molnar <mingo@elte.hu> Date: Thu, 14 Aug 2008 15:38:50 +0200 Subject: [PATCH] irq: sparse irqs, fix #2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit fix: In file included from arch/x86/kernel/setup.c:99: include/asm-x86/mach-default/mach_apic.h:142: error: expected ‘)’ before ‘->’ token That hunk got mis-merged. Signed-off-by: Ingo Molnar ...
Aug 14, 6:36 am 2008
Ingo Molnar
[PATCH] irq: sparse irqs, fix
From 547c9dd238f4412622fb6a2622d81c35c0a9fb85 Mon Sep 17 00:00:00 2001 From: Ingo Molnar <mingo@elte.hu> Date: Thu, 14 Aug 2008 15:32:59 +0200 Subject: [PATCH] irq: sparse irqs, fix MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit fix: drivers/pci/intel-iommu.c: In function ‘dmar_set_interrupt': drivers/pci/intel-iommu.c:918: error: too few arguments to function ‘create_irq' Signed-off-by: Ingo Molnar <mingo@elte.hu> --- ...
Aug 14, 6:31 am 2008
Ingo Molnar
Re: [PATCH 00/53] dyn_array/nr_irqs/sparse_irq support v10
(lkml Cc:-ed) ok, i've created a new tip/irq/sparseirq topic branch for this. Could you please send future updates against: git-checkout tip/master git-merge tip/irq/sparseirq Not yet integrated into tip/master, i've still got some other backlog. A couple of observations about the general structure of the sparse irqs code: - the new APIs should probably live in mm/bootmem.c not in init/main.c, and in bootmem.h. Also, it should be outlined clearly why this new API ...
Aug 14, 6:26 am 2008
Eric W. Biederman
Re: [PATCH 00/53] dyn_array/nr_irqs/sparse_irq support v10
We may want an is_valid_isa_irq() for drivers. Otherwise drivers should not be passing in irqs. And the request_irq path should valid the irq number but it should not allocate it. So we will have failures with invalid irq numbers. For acpi, mptables and the like we can easily have a check for some reasonably high value if there is value in that. Last I looked parts s390 is weird. I'm not even convinced they use linux/interrupt.h My mistake. irq_desc() is a bad name for the ...
Aug 14, 1:05 pm 2008
Yinghai Lu
Re: [PATCH 00/53] dyn_array/nr_irqs/sparse_irq support v10
On Thu, Aug 14, 2008 at 1:05 PM, Eric W. Biederman struct irq { unsigned int nr; struct irq_desc *idesc; } why not use -1U here? YH --
Aug 14, 1:42 pm 2008
Yinghai Lu
Re: [PATCH] irq: sparse irqs, fix #3
we don't need pin_map_size and first_free_entry after 64 and 32 bit all put irq_2_pin in irq_cfg. need to remove them. YH --
Aug 14, 10:34 am 2008
Yinghai Lu
Re: [PATCH 00/53] dyn_array/nr_irqs/sparse_irq support v10
find something interesting: found new irq_cfg for irq 20 0 add_pin_to_irq: irq 20 --> apic 0 pin 20 assign_irq_vector: irq 20 vector 0x59 cpu 5 IOAPIC[0]: Set routing entry (0-20 -> 0x59 -> IRQ 20 Mode:1 Active:1) found new irq_desc for irq 20 pci 0000:00:02.1: PCI INT B -> Link[LUS2] -> GSI 20 (level, low) -> IRQ 20 IO APIC #0...... .... register #00: 00000000 ....... : physical APIC id: 00 ....... : Delivery Type: 0 ....... : LTS : 0 .... register #01: ...
Aug 14, 2:24 pm 2008
Ingo Molnar
[PATCH] irq: sparse irqs, fix IRQ auto-probe crash
find below a crash fix discovered by tip/master testing. Robustness of sparse IRQs is looking pretty good otherwise at first glance. Ingo ------------------> From a4a5ec7bbaaaab5fcb86bd348b98bfbed7c6a3b7 Mon Sep 17 00:00:00 2001 From: Ingo Molnar <mingo@elte.hu> Date: Thu, 14 Aug 2008 15:48:50 +0200 Subject: [PATCH] irq: sparse irqs, fix IRQ auto-probe crash fix: [ 10.631533] calling yenta_socket_init+0x0/0x20 [ 10.631533] Yenta: CardBus bridge found at 0000:15:00.0 ...
Aug 14, 6:53 am 2008
Yinghai Lu
Re: [PATCH 00/53] dyn_array/nr_irqs/sparse_irq support v10
move pre_alloc_dyn_array, per_cpu_dyn_array_size, per_cpu_alloc_dyn_array # git grep CONFIG_HAVE_DYN_ARRAY | wc -l 9 #git grep CONFIG_HAVE_SPARSE_IRQ | wc -l 39 arch/x86/kernel/io_apic_32.c:#ifdef CONFIG_HAVE_SPARSE_IRQ_DEBUG arch/x86/kernel/io_apic_32.c:#ifndef CONFIG_HAVE_SPARSE_IRQ arch/x86/kernel/io_apic_64.c:#ifdef CONFIG_HAVE_SPARSE_IRQ_DEBUG arch/x86/kernel/io_apic_64.c:#ifndef CONFIG_HAVE_SPARSE_IRQ arch/x86/kernel/irq_32.c:#ifdef ...
Aug 14, 12:01 pm 2008
Andrew Morton
Re: [PATCH] irq: sparse irqs, fix #2
I haven't looked at callers of this, but... Does it need to be allocated on the stack? Local cpumask_t's are a size problem. Can we build this in .rodata at compile time instead? Is this the caller? + for_each_cpu_mask(cpu, mask) { + cpumask_t domain, new_mask; + int new_cpu; + int vector; + + domain = vector_allocation_domain(cpu); + cpus_and(new_mask, domain, cpu_online_map); If so we could perhaps do static noinline const cpumask_t *vector_allocation_domain(int ...
Aug 14, 9:33 am 2008
Bryan Wu
[GIT PULL] Blackfin arch updates for 2.6.27-rc3
Hi Linus, Due to some usb bug fixing task, I missed 2.6.27-rc2 cycle. This pull request looks like a little bigger but it is reasonable for the early 2.6.27 development cycle. Most new code are related to 2 new board support. Also we fixed some critical bugs. Please pull from 'for-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/cooloney/blackfin-2.6.git for-linus to receive the following updates: arch/blackfin/Kconfig | 69 +- ...
Aug 14, 6:22 am 2008
Rocky Craig
[PATCH 2.6.27] [POWERPC] Invalidate all TLB entries in a ...
From: Rocky Craig <rocky.craig@hp.com> The apparent intent of "flush_tlbs" is to invalidate TLB entries that might match in the address range 0 to 0x00400000. A loop counter is set up at the high value and decremented by page size. However, the loop is only done once as the sense of the conditional branch at the loop end does not match the setup/decrement. Signed-off-by: Rocky Craig <rocky.craig@hp.com> --- Source is from 2.6.27 development, but the bug appears as far back as ...
Aug 14, 6:11 am 2008
Benjamin Herrenschmidt
Re: [PATCH 2.6.27] [POWERPC] Invalidate all TLB entries ...
Heh nice, that's a bug as old as the port I would say :-) --
Aug 14, 3:28 pm 2008
David Witbrodt
Re: HPET regression in 2.6.26 versus 2.6.25 -- why Yingh ...
I finished experimenting last night with trying to find the last commit in the gittree that would let me revert the problem successfully... and I got completely raped. The bisecting took me all the way back to the first commit introducing the problem on these motherboards: 3def3d6d... Considering these 3 consecutive commits (according to 'git log')from late Feb. 2008, between kernel versions 2.6.25 and 2.6.26-rc1: --------------------------------------------------------- 700efc1b...: ...
Aug 14, 5:20 am 2008
Yinghai Lu
Re: HPET regression in 2.6.26 versus 2.6.25 -- revert fo ...
can you try enable kexec and kdump in you .config. please try to bisect on current tree. and every time apply the revert patch... YH --
Aug 14, 10:39 am 2008
David Witbrodt
Re: HPET regression in 2.6.26 versus 2.6.25 -- revert fo ...
So your patch code protects against problem that Bill is mentioning without using "#ifdef CONFIG_KEXEC", right Yinghai? For the record: my configs, including the kernel I built with Yinghai's revert patch, have CONFIG_KEXEC not set. Some experiments I did last night may render these questions moot, though. My problem is very specific to the hardware on two of my machines, and it has something to do with setting up the system resources that insert_resource() touches. Dave W. --
Aug 14, 5:03 am 2008
Jens Axboe
Re: can block drivers get non-fs requests?
Nope, that doesn't matter. If you already have a prep function, using BLKPREP_KILL is the easiest solution. -- Jens Axboe --
Aug 14, 7:06 am 2008
Pierre Ossman
Re: can block drivers get non-fs requests?
On Thu, 14 Aug 2008 13:42:09 +0200 So killing off the request with -EOPNOTSUPP is preferred over having a prepare function and stopping it there? Rgds --=20 -- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org rdesktop, core developer http://www.rdesktop.org WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption.
Aug 14, 5:39 am 2008
Jens Axboe
Re: can block drivers get non-fs requests?
You should check in the driver whether the request type is supported. So if you can only handle fs requests, you should do a check for !blk_fs_request() after elv_next_request() and call Yes, that is correct. A PC request is essentially a SCSI command sent Normal IO activity will only produce fs requests. However, if someone uses eg SG_IO on your block device, you will be sent pc requests. There are no checks for this, it is left to the driver. -- Jens Axboe --
Aug 14, 4:42 am 2008
Pierre Ossman
can block drivers get non-fs requests?
Hi Jens, There is one part of the block layer I'm having trouble completely understanding (well there are loads really, but right now there's one in particular :)): Do block drivers need to watch out for requests that aren't "normal" reads and writes? The MMC block driver has a funky prepare function that checks for FS and PC requests and discards anything else. I believe this is wrong in two regards: a) PC requests seem to be prepared SCSI cmds, and the MMC driver just expects normal ...
Aug 14, 4:38 am 2008
J. Bruce Fields
Re: [PATCH]lockd: fix handling of grace period after lon ...
Good catch! Did you actually run across this in practice? I would've thought it relatively unusual to have a lockd that didn't receive its first lock request until 25 days after startup. I've actually had a patch that does roughly the same thing for a while at: git://linux-nfs.org/~bfields/linux.git failover 3ff893a7.. "lockd: don't depend on lockd main loop to end grace" but hadn't submitted it since I didn't see the bug you found. (I had other reasons I wanted to do this). ...
Aug 14, 12:06 pm 2008
NAKANO Hiroaki
[PATCH]lockd: fix handling of grace period after long pe ...
lockd uses time_before() to determine whether the grace period has expired. This would seem to be enough to avoid timer wrap-around issues, but, unfortunately, that is not the case. The time_* family of comparison functions can be safely used to compare jiffies relatively close in time, but they stop working after approximately LONG_MAX/2 ticks. nfsd can suffer this problem because the time_before() comparison in lockd() is not performed until the first request comes in, which means that if there ...
Aug 14, 4:08 am 2008
David Howells
[PATCH] Fix setting of PF_SUPERPRIV by __capable()
Fix the setting of PF_SUPERPRIV by __capable() as it could corrupt the flags the target process if that is not the current process and it is trying to change its own flags in a different way at the same time. __capable() is using neither atomic ops nor locking to protect t->flags. This patch removes __capable() and introduces has_capability() that doesn't set PF_SUPERPRIV on the process being queried. This patch further splits security_ptrace() in two: (1) security_ptrace_may_access(). ...
Aug 14, 3:37 am 2008
Mel Gorman
[PATCH] Skip memory holes in FLATMEM when reading /proc/ ...
Hi Russell, Attached is what is arguably an ARM-patch rather than an mm patch. I tried subscribing to the ARM mailing list to post there but no luck so far. If you are not the right person to send this to, point me elsewhere. Thanks ==== Ordinarily, memory holes in flatmem still have a valid memmap and is safe to use. However, an architecture (ARM) frees up the memmap backing memory holes on the assumption it is never used. /proc/pagetypeinfo reads the whole range of pages in a zone ...
Aug 14, 3:10 am 2008
Ming Lei
BUG : lockdep link failed
a2VybmVsIHJldmlzaW9uIDogY29tbWl0IGI2MzVhY2VjNDhiY2FhOTE4M2ZjYmY0ZTM5NTU2MTZi MGQ0MTE5YjUKLi4uCldBUk5JTkc6IG1vZHBvc3Q6IEZvdW5kIDIyIHNlY3Rpb24gbWlzbWF0Y2go ZXMpLgpUbyBzZWUgZnVsbCBkZXRhaWxzIGJ1aWxkIHlvdXIga2VybmVsIHdpdGg6CidtYWtlIENP TkZJR19ERUJVR19TRUNUSU9OX01JU01BVENIPXknCiAgR0VOICAgICAudmVyc2lvbgogIENISyAg ICAgaW5jbHVkZS9saW51eC9jb21waWxlLmgKICBVUEQgICAgIGluY2x1ZGUvbGludXgvY29tcGls ZS5oCiAgQ0MgICAgICBpbml0L3ZlcnNpb24ubwogIExEICAgICAgaW5pdC9idWlsdC1pbi5vCiAg TEQgICAgICAudG1wX3ZtbGludXgxCmtlcm5lbC9i ...
Aug 14, 2:58 am 2008
Chris Lalancette
[PATCH]: Expand Xen blkfront for > 16 xvd
Jeremy, Until recently, the maximum number of xvd block devices you could attach to a Xen domU was 16. This limitation turned out to be problematic for some users, so it was expanded to handle a much larger number of disks. However, this requires a couple of changes in the way that blkfront scans for disks. This functionality is already present in the Xen linux-2.6.18-xen.hg tree; the attached patch adds this functionality to the mainline xen-blkfront implementation. I successfully ...
Aug 14, 2:54 am 2008
Hugh Dickins
Re: [rfc][patch] mm: dirty page accounting race fix
I realized that was the intended optimization, what I'd missed is that dirty_accountable can only be true there if (vma->vm_flags & VM_WRITE): that's checked in vma_wants_writenotify(), which is how dirty_accountable gets to be set. So those lines are okay, panic over, phew. Hugh --
Aug 14, 5:47 am 2008
Peter Zijlstra
Re: [rfc][patch] mm: dirty page accounting race fix
Also, the new page is only added to the rmap _after_ it has been Another case I just looked at is if ptep_clear_flush_young() actually does the clear bit. But the few arches (x86_64, ppc64) that I looked at don't seem to do so. If someone would, you could hit this race. CPU1 CPU2 lock(pte_lock) ptep_clear_flush(ptep) page_mkclean() page_check_address() ...
Aug 14, 5:49 am 2008
Hugh Dickins
Re: [rfc][patch] mm: dirty page accounting race fix
Well, yes, dirty and accessed can be changed from another thread in userspace while we hold pt lock in the kernel. (But dirty could only be changed if the pte is writable, and in dirty balancing cases that should be being prevented.) But no, that isn't what I was thinking of. pt lock better be enough to secure against kernel modifications to the pte. I was just thinking there are (potentially) all those other ptes of the page, and this pte may be modified the next instant, it wasn't ...
Aug 14, 6:39 am 2008
Hugh Dickins
Re: [rfc][patch] mm: dirty page accounting race fix
Yes, that's the part of the protocol I was forgetting. Not exactly relevant to the mprotect case where your hole opens up, but exactly the part of it that synchronizes all the ptes with the struct page, which was worrying me there. I really ought to read all those private messages to Virginia. Yes. The pte is still marked dirty and writable (after briefly being absent) and the page may be modified by userspace without entering the accounting; it will eventually get picked up and written ...
Aug 14, 12:09 pm 2008
Nick Piggin
Re: [rfc][patch] mm: dirty page accounting race fix
If I may... perhaps I didn't explain the race well enough. I'll try to shed further light on it (or prove myself wrong): It is true that there are other ptes, and any of those others at any time may be modified when we don't hold their particular ptl. But after we clean them, they'll require a page fault to dirty them again, and we're blocking out page faults (effectively -- see the comments in clear_page_dirty_for_io and wait_on_page_locked in do_wp_page) by holding the page lock over the ...
Aug 14, 6:52 am 2008
Nick Piggin
[rfc][patch] mm: dirty page accounting race fix
Hi, Wonder if you would be kind enough to verify this? It solves my issues (well still running after several hours wheras it previously would lock up in a few seconds). Thanks, Nick --- There is a race with dirty page accounting where a page may not properly be accounted for. clear_page_dirty_for_io() calls page_mkclean; then TestClearPageDirty. page_mkclean walks the rmaps for that page, and for each one it cleans and write protects the pte if it was dirty. It uses ...
Aug 14, 2:45 am 2008
Jeremy Fitzhardinge
Re: [rfc][patch] mm: dirty page accounting race fix
I got bitten by precisely the same train of thought. I think that code officially Non Obvious (or at least Not Immediately Obvious, which is bad in security-sensitive code). J --
Aug 14, 1:25 pm 2008
Peter Zijlstra
Re: [rfc][patch] mm: dirty page accounting race fix
s/synch/sync/ ? Indeed, that does look like a hole, and the proposed fix seems sane. --
Aug 14, 3:27 am 2008
Hugh Dickins
Re: [rfc][patch] mm: dirty page accounting race fix
I'm not against this if it really turns out to be the answer, it's simple enough and it sounds like a very good find; but I'm still not convinced that you've got to the bottom of it. Am I confused, or is your "do_wp_page calls ptep_clear_flush_notify" example a very bad one? The page it's dealing with there doesn't go back into the page table (its COW does), and the dirty_accounting case doesn't even get down there, it's dealt with in the reuse case above, which uses ptep_set_access_flags. ...
Aug 14, 4:55 am 2008
Hugh Dickins
Re: [rfc][patch] mm: dirty page accounting race fix
I agree completely that should be allowed (within pagetable lock) and is sometimes essential, mprotect being the classic example. So I'll try to think through your case later on, focussing on Yes, that's what I'd missed: with that worry out of the way, I should think a bit clearer. Hugh --
Aug 14, 6:20 am 2008
Peter Zijlstra
Re: [rfc][patch] mm: dirty page accounting race fix
Exactly, we do that because the page is already dirty, therefore we do not need to trap on write to mark it dirty - at least, that was the idea behind this optimization. --
Aug 14, 5:18 am 2008
Nick Piggin
Re: [rfc][patch] mm: dirty page accounting race fix
Oh you're right definitely. Thanks. Actually, the bug I am running into is not with a vanilla kernel... I am making several of my own required changes to solve other races I need to plug, so I'm sorry the changelog might be misleading... Hmm, no even in that case I think we get away with it because of the wait_on_page_locked which ensures clearing the page dirty Maybe I've found another one: ppc64's set_pte_at seems to clear the pte, and lots of pte accessors are implemented with ...
Aug 14, 5:35 am 2008
David Miller
Re: [git patches] net driver updates
From: Jeff Garzik <jeff@garzik.org> Pulled and pushed back out to kernel.org, thanks Jeff. --
Aug 14, 2:54 pm 2008
Jeff Garzik
[git patches] net driver updates
Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-davem to receive the following updates: drivers/net/Kconfig | 2 +- drivers/net/acenic.c | 1 - drivers/net/arm/ixp4xx_eth.c | 6 +- drivers/net/atl1e/atl1e_ethtool.c | 2 +- drivers/net/atl1e/atl1e_main.c | 4 +- drivers/net/au1000_eth.c | 2 +- drivers/net/ax88796.c ...
Aug 14, 2:32 am 2008
Jens Axboe Aug 14, 2:41 am 2008
Aaron Carroll
[PATCH 2/3] deadline-iosched: non-functional fixes
* convert goto to simpler while loop; * use rq_end_sector() instead of computing manually; * fix false comments; * remove spurious whitespace; * convert rq_rb_root macro to an inline function. Signed-off-by: Aaron Carroll <aaronc@gelato.unsw.edu.au> --- block/deadline-iosched.c | 26 +++++++++++++------------- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/block/deadline-iosched.c b/block/deadline-iosched.c index 07b80e4..fd31117 100644 --- ...
Aug 14, 1:17 am 2008
Aaron Carroll
[PATCH 3/3] block: update documentation for deadline fif ...
Update the description of fifo_batch to match the current implementation, and include a description of how to tune it. Signed-off-by: Aaron Carroll <aaronc@gelato.unsw.edu.au> --- Documentation/block/deadline-iosched.txt | 14 ++++++++++---- 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/Documentation/block/deadline-iosched.txt b/Documentation/block/deadline-iosched.txt index c23cab1..7257676 100644 --- a/Documentation/block/deadline-iosched.txt +++ ...
Aug 14, 1:17 am 2008
Aaron Carroll
[PATCH 1/3] deadline-iosched: allow non-sequential batching
Deadline currently only batches sector-contiguous requests, so except for a few circumstances (e.g. requests in a single direction), it is essentially first come first served. This is bad for throughput, so change it to CSCAN, which means requests in a batch do not need to be sequential and are issued in increasing sector order. Signed-off-by: Aaron Carroll <aaronc@gelato.unsw.edu.au> --- block/deadline-iosched.c | 14 +++----------- 1 files changed, 3 insertions(+), 11 ...
Aug 14, 1:17 am 2008
Aaron Carroll
[PATCH 0/3] deadline-iosched: performance, style and doc ...
Hi Jens, Patch 1 changes deadline to dispatch in a CSCAN-like manner for improved throughput. This fixes two performance issues, namely deadline avalanche that occurs under high load, and FCFS-like behaviour for mixed read/write workloads. Benchmark results are below. Patches 2 and 3 introduce some non-functional changes, mostly for style and documentation. Thanks, -- Aaron -----------------------------------x8----------------------------------- Figures quoted in KiB/s unless ...
Aug 14, 1:17 am 2008
gshan
strange response from shell after issuing command "resize"
After I issued command "resize" to shell which is running on one of serial port, it doesn't output shell prompt any more, but echo what I inputed. It seems that shell don't know how to end one input line when this issue happened. Anybody has ideas? aaa@(none):~$ resize COLUMNS=125; LINES=39; export COLUMNS LINES; <entery key input> <enter char output> <entery key input> <enter char output> <entery key input> <enter char output> <entery key input> <enter char output> ...
Aug 14, 2:01 am 2008
Peter Teoh
KDB compilation errors for 2.6.26
I patched the stock kernel at http://www.kernel.org/pub/linux/kernel/v2.6/ for 2.6.26 with the two kdb for 2.6.26 from ftp://oss.sgi.com/www/projects/kdb/download/latest/ and after compilation, CHECK include/video/uvesafb.h CHECK include/video/sisfb.h CHECK include/video/edid.h Kernel: arch/x86/boot/bzImage is ready (#1) Building modules, stage 2. MODPOST 1605 modules ERROR: "next_online_pgdat" [kdb/modules/kdbm_vm.ko] undefined! ERROR: "first_online_pgdat" ...
Aug 14, 1:35 am 2008
Michael Ellerman
Re: bug in lmb_enforce_memory_limit()
Perhaps after the first loop we should set memory_limit to equal lmb_end_of_DRAM(), then the second loop should work as it is. I think that actually makes memory_limit (the variable) more useful, and avoids more code like we have in numa_enforce_memory_limit(), which doesn't use memory_limit exactly because it isn't the value we're Guilty as charged. I have some tests for that code, but clearly not Would it be that much extra logic to check that the address is less than the limit? ...
Aug 14, 4:26 am 2008
David Miller
bug in lmb_enforce_memory_limit()
I just mentioned this to Ben H. on IRC and promised I would report it here. :-) The first loop over lmb.memory in this function interprets the memory_limit as a raw size limit, and that's fine so far. But the second loop over lmb.reserved interprets this value instead as an "address limit." I haven't cobbled together a fix myself, but probably the way to do this is, when we're about break out of the first loop over lmb.memory, walk through the now-trimmed memory blobs and trim those ...
Aug 14, 1:20 am 2008
Stephen Rothwell
linux-next: Tree for August 14
Hi all, News: This is the 6 month anniversary of linux-next (the first release was Feb 14). Changes since next-20080813: The usb-current tree lost its conflict. The ubifs tree lost its conflict. The slab tree lost its conflict. The hdlc tree gained a build fix patch. The ttydev tree gained a conflict against the usb tree. The creds tree gained a conflict against the ttydev tree and lost one against Linus' tree. I have also applied the following patches for known ...
Aug 14, 12:29 am 2008
Greg KH
Re: linux-next: Tree for August 14 (sysfs/acpi errors)
Why would this be a sysfs error, it's acpi doing something foolish, that's why the sysfs layer is warning about it :) thanks, greg k-h --
Aug 14, 8:44 am 2008
Geert Uytterhoeven
Re: linux-next: Tree for August 14
And linux-next helped me a lot in finding breakage early. Thanks for your efforts, Stephen! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds --
Aug 14, 2:16 am 2008
Randy Dunlap
Re: linux-next: Tree for August 14 (sysfs/acpi errors)
calling param_sysfs_init+0x0/0x1e7 ------------[ cut here ]------------ WARNING: at fs/sysfs/dir.c:463 sysfs_add_one+0x35/0x3d() sysfs: duplicate filename 'acpi' can not be created Modules linked in: Pid: 1, comm: swapper Not tainted 2.6.27-rc3-next-20080814 #1 Call Trace: [<ffffffff802358cb>] warn_slowpath+0xae/0xdd [<ffffffff8036a6be>] ? number+0x115/0x21f [<ffffffff8036574d>] ? __next_cpu+0x19/0x26 [<ffffffff8022d575>] ? find_busiest_group+0x25b/0x6ee [<ffffffff8036aefc>] ? ...
Aug 14, 8:38 am 2008
Randy Dunlap
Re: linux-next: Tree for August 14 (bug: cciss)
Tainted by some prior sysfs warn_on crapola. BUG: unable to handle kernel NULL pointer dereference at 0000000000000248 IP: [<ffffffffa001cb68>] do_cciss_intr+0x627/0xa6c [cciss] PGD 17eba6067 PUD 17eba7067 PMD 0 Oops: 0002 [1] SMP last sysfs file: /sys/block/ram15/dev CPU 2 Modules linked in: cciss(+) ehci_hcd ohci_hcd uhci_hcd Pid: 0, comm: swapper Tainted: G W 2.6.27-rc3-next-20080814 #1 RIP: 0010:[<ffffffffa001cb68>] [<ffffffffa001cb68>] do_cciss_intr+0x627/0xa6c ...
Aug 14, 8:34 am 2008
Jeremy Fitzhardinge
Re: kernel BUG at lib/radix-tree.c:473!
Irritatingly, it looks like the i386 register dump doesn't include cr2. My 64-bit dump has cr2 as 00007fb12cb2a000 which is a good solid usermode address. I'll run X under strace to see if that gives a clue to what it corresponds to. J --
Aug 14, 10:38 am 2008
Markus Armbruster
Re: kernel BUG at lib/radix-tree.c:473!
The actual cleverness is in fb_defio[*], which was written by Jaya Kumar (cc'ed). I merely ripped out the old, somewhat racy cleverness I inherited from Anthony Liguori (which you can still admire in Xen's 2.6.18 kernel), and switched over to use fb_defio instead. Because one instance of clever code is enough. My understanding of fb_defio's inner workings is rather limited I fear. I'm just using it. Jaya, could you help? [...] [*] Documentation/fb/deferred_io.txt ...
Aug 14, 3:48 pm 2008
Jeremy Fitzhardinge
Re: kernel BUG at lib/radix-tree.c:473!
It's a /dev/fb0 mapping: open("/dev/fb0", O_RDWR) = 8 ... mmap(NULL, 2097152, PROT_READ|PROT_WRITE, MAP_SHARED, 8, 0) = 0x7fed69a08000 The fault is 1 page into this mapping: WARNING: at /home/jeremy/hg/xen/paravirt/linux/fs/buffer.c:711 __set_page_dirty+0x7e/0x113() Modules linked in: xen_fbfront fb fb_sys_fops sysimgblt sysfillrect xen_netfront syscopyarea xen_kbdfront xen_blkfront Pid: 1357, comm: X Not tainted 2.6.27-rc2-tip #337 Call Trace: [<ffffffff802346be>] ...
Aug 14, 12:33 pm 2008
Jeremy Fitzhardinge
Re: kernel BUG at lib/radix-tree.c:473!
My understanding is that the driver is doing something a bit clever: it uses the page dirty flags to determine which parts of the framebuffer have been written to, and uses that information to minimize the amount of stuff that needs to be copied out. The writes to the pages are not expected to generate actual page faults. But I haven't really looked at it closely, and I'm not at all familiar with the vm at this layer. I'm not sure how it actually allocates the framebuffer memory for ...
Aug 14, 3:04 pm 2008
Hugh Dickins
Re: kernel BUG at lib/radix-tree.c:473!
No, have a good break and come back to it next week. Whatever I suggest in a rush will at first give you more oopses than you started out with, back and forth, then it'll give us some info but not enough, back and forth... no. I'd rather spend the time trying to work out a hypothesis from my end: it's always easier to devise an info patch once you have a hypothesis to test, right now it makes no sense to me at all. My starting point will be, prior to my tmpfs patch the faulting page had a ...
Aug 14, 10:42 am 2008
Hugh Dickins
Re: kernel BUG at lib/radix-tree.c:473!
Nor I! Thanks a lot for doing the bisection, but all I can say so far is that I'm utterly flummoxed. (And I do wonder if it's a pvfb bug which has previously been masked; but that's premature, we can't say until we understand how it got here at all.) There's a lot of "?" entries in your backtrace, Jeremy's ones look clearer: CONFIG_FRAME_POINTER=y ought to improve yours. In both cases it's handling a page fault: I'm curious as to what kind of vma this fault is occurring on. Could you ...
Aug 14, 6:06 am 2008
Ian Campbell
Re: kernel BUG at lib/radix-tree.c:473!
That was with CONFIG_FRAME_POINTER=y / CONFIG_DEBUG_KERNEL=y / I'll have a go but I'm just about to go away for a long weekend so it might be next week unless I get to it tonight. Any pointers on how to go about it would be appreciated though... Ian. -- Ian Campbell Current Noise: Enslaved - Intro: "Green Reflection" The problem with people who have no vices is that generally you can be pretty sure they're going to have some pretty annoying virtues. -- Elizabeth Taylor --
Aug 14, 7:56 am 2008
Peter Zijlstra Aug 14, 3:41 am 2008
Ian Campbell
kernel BUG at lib/radix-tree.c:473!
Jeremy first noticed this http://marc.info/?l=3Dlinux-kernel&m=3D121783008503477&w=3D2 [ 3.132333] ------------[ cut here ]------------ [ 3.132343] kernel BUG at /home/ijc/development/kernel/2.6.git/lib/radix= -tree.c:473! [ 3.132348] invalid opcode: 0000 [#1] SMP=20 [ 3.132352] Modules linked in: [ 3.132356]=20 [ 3.132363] Pid: 580, comm: debconf Tainted: G W (2.6.26 #27) [ 3.132368] EIP: 0061:[<c01f5279>] EFLAGS: 00010002 CPU: 0 [ 3.132375] EIP is at ...
Aug 14, 12:02 am 2008
Johannes Weiner
Re: kernel BUG at lib/radix-tree.c:473!
Hi, Creating a device node on a different filesystem to see if the driver only worked with the safe shmem set_page_dirty and now breaks due to exposure to the generic version. Or if the driver works with the generic version through other mappings and the shmem code screws it up somewhere else. Hannes --
Aug 14, 4:13 pm 2008
Hugh Dickins
Re: kernel BUG at lib/radix-tree.c:473!
Brilliant, thanks a lot, Jeremy. That fits, I'd been inching towards forming the thought that it was likely to involve a block or char device (rather than a directory, which is what had prompted the patch). I'd thought about them when making the patch, but quickly decided that a device node may live in a tmpfs (and usually does with udev), but redirects off to somewhere else entirely. If I open /dev/sda and mmap it, then I don't expect to see pages of shmem, I expect to see pages from my ...
Aug 14, 2:03 pm 2008
jmerkey
[PATCH 2.6.27-rc3 18/29] mdb: add global external proced ...
added global external procedure defines. added and updated volatile declarations. added and updated debug_lock synchronization and SSB command support. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/debug/mdb/mdb-proc.h 1969-12-31 17:00:00.000000000 -0700 +++ b/debug/mdb/mdb-proc.h 2008-08-13 11:56:03.000000000 -0600 @@ -0,0 +1,146 @@ + +/*************************************************************************** +* +* Copyright (c) 2008 Jeff V. Merkey ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 19/29] mdb: adding notify_die handler ...
added module support for keyboard debugger entry point and notify_die entry point. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/drivers/char/keyboard.c 2008-08-13 14:22:15.000000000 -0600 +++ b/drivers/char/keyboard.c 2008-08-13 11:56:03.000000000 -0600 @@ -44,6 +44,10 @@ #include <linux/notifier.h> #include <linux/jiffies.h> +#if defined(CONFIG_MDB) || defined(CONFIG_MDB_MODULE) +#include <linux/kdebug.h> +#endif + extern void ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 21/29] mdb: disable console warnings i ...
disable the console warning checks if the debugger is active because the debugger is dependent in the console output functions in order to provide console display. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/include/linux/console.h 2008-08-13 14:22:32.000000000 -0600 +++ b/include/linux/console.h 2008-08-13 11:56:03.000000000 -0600 @@ -141,11 +141,16 @@ void vcs_remove_sysfs(struct tty_struct *tty); /* Some debug stub to catch some of the obvious ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 22/29] mdb: export kernel_text_address
export the kernel_text_address() to allow symbol searching and matches of symbolic names contained the the kernel symbol table. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/kernel/extable.c 2008-07-13 15:51:29.000000000 -0600 +++ b/kernel/extable.c 2008-08-13 11:56:03.000000000 -0600 @@ -59,6 +59,9 @@ return 1; return __module_text_address(addr) != NULL; } +#if defined(CONFIG_MDB_MODULE) +EXPORT_SYMBOL_GPL(__kernel_text_address); +#endif int ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 23/29] mdb: export kallsyms functions
export the kallsyms lookup functions to the module based debugger. add debugger specific lookup to search for matching strstr text fragments for entered search terms. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/kernel/kallsyms.c 2008-08-13 14:22:32.000000000 -0600 +++ b/kernel/kallsyms.c 2008-08-13 11:56:03.000000000 -0600 @@ -160,6 +160,9 @@ } return module_kallsyms_lookup_name(name); } +#if ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 24/29] mdb: add export function to module.c
add the ability to scan and display the loaded module list inside the debugger. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/kernel/module.c 2008-08-13 14:22:32.000000000 -0600 +++ b/kernel/module.c 2008-08-13 11:56:03.000000000 -0600 @@ -2503,6 +2503,41 @@ return 0; } +#if defined(CONFIG_MDB) || defined(CONFIG_MDB_MODULE) +int mdb_modules(char *str, int (*print)(char *s, ...)) +{ + struct module *mod; + struct module_use *use; + + if ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 28/29] mdb: change mdb name to "Merkey ...
change mdb name to "Merkey's Linux Kernel Debugger". update description to add very simple and minimal instructions on entering the debugger and access to the internal help panels. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/lib/Kconfig.debug 2008-08-13 14:22:32.000000000 -0600 +++ b/lib/Kconfig.debug 2008-08-13 11:56:03.000000000 -0600 @@ -134,6 +134,39 @@ Say Y here if you are developing drivers or trying to debug and identify kernel problems. ...
Aug 13, 11:14 pm 2008
jmerkey
[ANNOUNCE] mdb: version 2.6.27-rc3 released
ChangesLog: 2.6.27-rc3 1/29 mdb: add machine restart/genapic export add machine restart and genapic exports for the module based build of the debugger. genapic is exported here rather than arch/x86/mach-generic/probes.c because EXPORT_SYMBOL does not work correctly when used inside of files in this directory in the 2.6.27 tree. 2.6.27-rc3 2/29 mdb: add debug directory Makefile add a debug directory makefile for loadable kernel debugger modules. 2.6.27-rc3 3/29 mdb: add ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 29/29] mdb: add /debug directory to ma ...
add the /debug directory to the main Makefile for module-based kernel debuggers. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/Makefile 2008-08-13 14:22:11.000000000 -0600 +++ b/Makefile 2008-08-13 11:56:03.000000000 -0600 @@ -620,6 +620,7 @@ ifeq ($(KBUILD_EXTMOD),) core-y += kernel/ mm/ fs/ ipc/ security/ crypto/ block/ +core-$(CONFIG_MDB) += debug/ vmlinux-dirs := $(patsubst %/,%,$(filter %/, $(init-y) $(init-m) \ $(core-y) $(core-m) ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 27/29] mdb: export the clocksource nmi ...
export the clocksource nmi watchdog for the module based kernel debugger. This function is called to prevent watchdog events while the debugger has processors in suspended states during active debugging sessions. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/kernel/time/clocksource.c 2008-08-13 14:22:32.000000000 -0600 +++ b/kernel/time/clocksource.c 2008-08-13 11:56:03.000000000 -0600 @@ -242,6 +242,9 @@ { clocksource_resume_watchdog(); } +#if ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 25/29] mdb: add a notify_die handler t ...
add a notify_die handler to hook the panic entry point prior to Linux "execve"-ing another kernel for crash analysis. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/kernel/panic.c 2008-08-13 14:22:32.000000000 -0600 +++ b/kernel/panic.c 2008-08-13 11:56:03.000000000 -0600 @@ -21,6 +21,8 @@ #include <linux/debug_locks.h> #include <linux/random.h> #include <linux/kallsyms.h> +#include <linux/kdebug.h> + int panic_on_oops; int tainted; @@ -82,6 +84,13 ...
Aug 13, 11:14 pm 2008
Pekka Enberg
Re: [PATCH 2.6.27-rc3 26/29] mdb: export task_curr
We usually don't export symbols conditionally, especially in core kernel code. --
Aug 14, 1:39 am 2008
jmerkey
Re: [PATCH 2.6.27-rc3 26/29] mdb: export task_curr
OK. That's simple and minimal. Jeff --
Aug 14, 7:49 am 2008
jmerkey
[PATCH 2.6.27-rc3 26/29] mdb: export task_curr
export the task_curr function to the module based kernel debugger to enable process back tracing and state display. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/kernel/sched.c 2008-08-13 14:22:32.000000000 -0600 +++ b/kernel/sched.c 2008-08-13 11:56:03.000000000 -0600 @@ -1736,6 +1736,9 @@ { return cpu_curr(task_cpu(p)) == p; } +#if defined(CONFIG_MDB_MODULE) +EXPORT_SYMBOL_GPL(task_curr); +#endif static inline void __set_task_cpu(struct ...
Aug 13, 11:14 pm 2008
jmerkey
Re: [PATCH 2.6.27-rc3 26/29] mdb: export task_curr
Well,then please suggest how a kernel debugger can be module based and still be able to get this information some other way that's generic and minimal impact. Jeff --
Aug 14, 7:35 am 2008
Johannes Weiner
Re: [PATCH 2.6.27-rc3 26/29] mdb: export task_curr
EXPORT_SYMBOL_GPL(task_curr); Without the #if's. Just export it. Hannes --
Aug 14, 8:05 am 2008
jmerkey
[PATCH 2.6.27-rc3 20/29] mdb: export the console redirec ...
export the console redirection handle to allow the debugger screen to becoime visible again during exceptions. Export of this variable allows the debugger to switch to the current screen in order to enable the debugging console on systems with a redirected system console. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/drivers/char/vt.c 2008-08-13 14:22:15.000000000 -0600 +++ b/drivers/char/vt.c 2008-08-13 11:56:03.000000000 -0600 @@ -188,6 +188,10 @@ int ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 17/29] mdb: update operating system defines
updated and included operating system dependent defines Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/debug/mdb/mdb-os.h 1969-12-31 17:00:00.000000000 -0700 +++ b/debug/mdb/mdb-os.h 2008-08-13 11:56:03.000000000 -0600 @@ -0,0 +1,106 @@ + +/*************************************************************************** +* +* Copyright (c) 2008 Jeff V. Merkey All Rights Reserved. +* 1058 East 50 South +* Lindon, Utah 84042 +* ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 16/29] mdb: add touch_nmi_watchdog cal ...
added clocksource nmi functions and nmi watchdog update logic to correct soft cpu errors due to nmi watchdog timers. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/debug/mdb/mdb-os.c 1969-12-31 17:00:00.000000000 -0700 +++ b/debug/mdb/mdb-os.c 2008-08-13 13:18:57.000000000 -0600 @@ -0,0 +1,1125 @@ + +/*************************************************************************** +* +* Copyright (c) 2008 Jeff V. Merkey All Rights Reserved. +* 1058 East ...
Aug 13, 11:14 pm 2008
jmerkey Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 15/29] mdb: notify_die fixes/add SSB support
added complete notify_die states and state support for SSB command. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/debug/mdb/mdb-main.c 1969-12-31 17:00:00.000000000 -0700 +++ b/debug/mdb/mdb-main.c 2008-08-13 11:56:03.000000000 -0600 @@ -0,0 +1,648 @@ + +/*************************************************************************** +* +* Copyright (c) 1997, 2008 Jeff V. Merkey All Rights Reserved. +* 1058 East 50 South +* Lindon, Utah 84042 +* ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 13/29] mdb: add includes and external ...
added includes and external function prototypes debugger registry Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/debug/mdb/mdb-list.h 1969-12-31 17:00:00.000000000 -0700 +++ b/debug/mdb/mdb-list.h 2008-08-13 11:56:03.000000000 -0600 @@ -0,0 +1,83 @@ + +/*************************************************************************** +* +* Copyright (c) 2008 Jeff V. Merkey All Rights Reserved. +* 1058 East 50 South +* Lindon, Utah 84042 +* ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 12/29] mdb: add alternate debugger, ac ...
added the command registry for registering debugger and accelerator keystroke commands. corrected a large number of checkpatch.pl reported issues. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/debug/mdb/mdb-list.c 1969-12-31 17:00:00.000000000 -0700 +++ b/debug/mdb/mdb-list.c 2008-08-13 11:56:03.000000000 -0600 @@ -0,0 +1,628 @@ + +/*************************************************************************** +* +* Copyright (c) 2008 Jeff V. Merkey All ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 11/29] mdb: add includes and external ...
added includes and external defines for keyboard specific code Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/debug/mdb/mdb-keyboard.h 1969-12-31 17:00:00.000000000 -0700 +++ b/debug/mdb/mdb-keyboard.h 2008-08-13 11:56:03.000000000 -0600 @@ -0,0 +1,137 @@ + + +/*************************************************************************** +* +* Copyright (c) 2008 Jeff V. Merkey All Rights Reserved. +* 1058 East 50 South +* Lindon, Utah 84042 +* ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 10/29] mdb: add SSB jump detection support
added JMP, CALL, RET, J%% detection into the ia32 disassembler for SSB support and branch detection. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/debug/mdb/mdb-ia32-support.c 1969-12-31 17:00:00.000000000 -0700 +++ b/debug/mdb/mdb-ia32-support.c 2008-08-13 11:56:03.000000000 -0600 @@ -0,0 +1,1935 @@ + +/*************************************************************************** +* +* Copyright (c) 2008 Jeff V. Merkey All Rights Reserved. +* 1058 East 50 ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 7/29] mdb: fix APIC ICR directed NMI l ...
fixed the APIC ICR directed NMI lockup problem seen on certain laptop systems when sending directed NMI exceptions over the APIC ICC bus. added exception forking logic into debug_lock to handle nested exceptions and concurrent int1 debugger exceptions. instrumented better detection and quiescence logic for NMI xcalls. fixed external defines. fixed a large number of checkpatch.pl reports of global variables. moved volatile and __asm__ __volatile__ references into mdb-ia32.c since this ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 6/29] mdb: add main include configurat ...
add top level mdb.h include file. added focus processor internal tracing and debugging defines. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/debug/mdb/mdb.h 1969-12-31 17:00:00.000000000 -0700 +++ b/debug/mdb/mdb.h 2008-08-13 11:56:03.000000000 -0600 @@ -0,0 +1,54 @@ + +/*************************************************************************** +* +* Copyright (c) 2008 Jeff V. Merkey All Rights Reserved. +* 1058 East 50 South +* Lindon, Utah ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 9/29] mdb: add includes and external f ...
added includes and external function prototypes for ia32 specific code Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/debug/mdb/mdb-ia32-proc.h 1969-12-31 17:00:00.000000000 -0700 +++ b/debug/mdb/mdb-ia32-proc.h 2008-08-13 11:56:03.000000000 -0600 @@ -0,0 +1,511 @@ + +/*************************************************************************** +* +* Copyright (c) 2008 Jeff V. Merkey All Rights Reserved. +* 1058 East 50 South +* Lindon, Utah 84042 +* ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 8/29] mdb: add includes and external d ...
added includes and external defines for ia32 specific code Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/debug/mdb/mdb-ia32.h 1969-12-31 17:00:00.000000000 -0700 +++ b/debug/mdb/mdb-ia32.h 2008-08-13 11:56:03.000000000 -0600 @@ -0,0 +1,172 @@ + +/*************************************************************************** +* +* Copyright (c) 2008 Jeff V. Merkey All Rights Reserved. +* 1058 East 50 South +* Lindon, Utah 84042 +* ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 4/29] mdb: checkpatch.pl fixes/add SSB ...
correct checkpatch.pl global declarations, volatile declarations moved to the ia32 specific file. add focus processor support for SSB. add sld update functions for SSB. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/debug/mdb/mdb-base.c 1969-12-31 17:00:00.000000000 -0700 +++ b/debug/mdb/mdb-base.c 2008-08-13 11:56:03.000000000 -0600 @@ -0,0 +1,2313 @@ + +/*************************************************************************** +* +* Copyright (c) ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 5/29] mdb: add external defines for de ...
add architecture independent external defines. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/debug/mdb/mdb-base.h 1969-12-31 17:00:00.000000000 -0700 +++ b/debug/mdb/mdb-base.h 2008-08-13 11:56:03.000000000 -0600 @@ -0,0 +1,296 @@ + +/*************************************************************************** +* +* Copyright (c) 2008 Jeff V. Merkey All Rights Reserved. +* 1058 East 50 South +* Lindon, Utah 84042 +* ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 1/29] mdb: add machine restart/genapic ...
add machine restart and genapic exports for the module based build of the debugger. genapic is exported here rather than arch/x86/mach-generic/probes.c because EXPORT_SYMBOL does not work correctly when used inside of files in this directory in the 2.6.27 tree. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/arch/x86/kernel/reboot.c 2008-08-13 14:22:14.000000000 -0600 +++ b/arch/x86/kernel/reboot.c 2008-08-13 11:56:03.000000000 -0600 @@ -502,6 +502,13 @@ { ...
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 2/29] mdb: add debug directory Makefile
add a debug directory makefile for loadable kernel debugger modules. Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/debug/Makefile 1969-12-31 17:00:00.000000000 -0700 +++ b/debug/Makefile 2008-08-13 11:56:03.000000000 -0600 @@ -0,0 +1,5 @@ +# +# Makefile for kernel debugger modules +# + +obj-$(CONFIG_MDB) += mdb/ --
Aug 13, 11:14 pm 2008
jmerkey
[PATCH 2.6.27-rc3 3/29] mdb: add mdb kernel debugger Makefile
add the makefile for the MDB kernel debugger Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) --- a/debug/mdb/Makefile 1969-12-31 17:00:00.000000000 -0700 +++ b/debug/mdb/Makefile 2008-08-13 11:56:03.000000000 -0600 @@ -0,0 +1,5 @@ +# + +obj-$(CONFIG_MDB) += mdb.o + +mdb-y := mdb-main.o mdb-base.o mdb-list.o mdb-logic.o mdb-os.o mdb-ia32.o mdb-ia32-support.o --
Aug 13, 11:14 pm 2008
Robert Hancock Aug 13, 10:12 pm 2008
Milan Plzik Aug 14, 1:10 am 2008
Manny Maxwell
SATA Cold Boot Problems with 2.6.27-rc[23] on nVidia 680i
Hello, I've been experiencing nasty intermittent boot problems on recent -git kernels. The problem is not readily reproducible; I tried to bisect and couldn't trigger it at all, but if I leave the machine off for at least an hour or so it triggers and is quite obvious (the kernel halts completely after spewing SATA errors). This is a multi-OS machine; if I boot into a 'good' OS (2.6.25.x works, as does Windows XP), then reboot into a recent kernel, the kernel boots fine. So the procedure for ...
Aug 13, 9:16 pm 2008
Matthew Garrett
[PATCH] Make Dell keyboard repeat quirk apply to a wider ...
Dell laptops fail to send key up events for several of their special keys. There's an existing quirk in the kernel to handle this, but it's limited to the Latitude range. This patch extends it to cover all portable Dells. Signed-off-by: Matthew Garrett <mjg@redhat.com> --- diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c index b1ce10f..e32c24d 100644 --- a/drivers/input/keyboard/atkbd.c +++ b/drivers/input/keyboard/atkbd.c @@ -834,10 +834,10 @@ static void ...
Aug 13, 8:32 pm 2008
Thomas Gleixner
Re: [PATCH] HPET: Workaround for a BIOS workaround on AM ...
Crane, thanks for debugging this. I think we don't need a quirk for this workaround. Checking the config register value for 0xffffffff is safe on all machines. I simplified your patch to the one below and added a printk in case the check times out. One thing I'm a bit wary about is the readout of the HPET_PERIOD register. Is the value correct even _before_ the SMM machinery is started ? Thanks, tglx ----- diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c index ...
Aug 14, 3:11 am 2008
crane cai
[PATCH] HPET: Workaround for a BIOS workaround on AMD SB ...
>From 9bd2f534f986768f1944e626e37af1c323e47dbb Mon Sep 17 00:00:00 2001 From: Crane Cai <crane.cai@amd.com> Date: Thu, 14 Aug 2008 10:31:01 +0800 Subject: [PATCH] HPET: Workaround for a BIOS workaround on AMD SB700 platform On the AMD SB700 southbridge, between the revisions 0x30 to 0x3a, when its spread-spectrum frequency modulation feature is enabled, the base frequency used by the HPET will not be running on average slower than nominal 14.318 MHz. Since there is no provision in the OS for ...
Aug 13, 8:13 pm 2008
Ingo Molnar
Re: [PATCH] HPET: Workaround for a BIOS workaround on AM ...
nice fix! I've applied it to tip/x86/urgent as the quirk is limited to this platform so it should be safe for v2.6.27 as well. Exactly what kind of failure mode have you seen without the quirk? Do we read out the wrong values and thus hpet_clocksource_register() is calibrated incorrectly and you can get non-functional high-res timers? A quick question: the signoff order indicates that the patch has been authored by XiaoGang Zheng. Or is the reverse order intended? (you wrote the ...
Aug 14, 1:41 am 2008
Lennart Sorensen
Re: [PATCH] HPET: Workaround for a BIOS workaround on AM ...
Should that have read "the base frequency used by HPET will on average be running slower than nominal 14.318 MHz"? That would be pretty much the opposite of what the comment says, but makes more sense based on the -- Len Sorensen --
Aug 14, 7:11 am 2008
crane cai
Re: [PATCH] HPET: Workaround for a BIOS workaround on AM ...
XiaoGang insures that HPET check method in hardware view. I refine the method and generate the patch. Vojtech and Zahir refine the description. This issue is cleared by Joachim and many other persons in SUSE. -Crane --
Aug 14, 2:10 am 2008
Ingo Molnar
Re: [PATCH] HPET: Workaround for a BIOS workaround on AM ...
small build fix: From c107f81791afa9f749cf242944c90a18faf69fda Mon Sep 17 00:00:00 2001 From: Ingo Molnar <mingo@elte.hu> Date: Thu, 14 Aug 2008 11:03:24 +0200 Subject: [PATCH] x86, hpet: workaround for a BIOS workaround on AMD SB700 platform, fix fix: arch/x86/kernel/early-quirks.c: In function 'amd_sb700_hpet': arch/x86/kernel/early-quirks.c:105: error: 'sb700_hpet_workaround' undeclared (first use in this function) arch/x86/kernel/early-quirks.c:105: error: (Each undeclared ...
Aug 14, 2:04 am 2008
Vojtech Pavlik Aug 14, 7:14 am 2008
Stephen Rothwell
Re: Resolved XFS conflict in next-creds
Hi James, On Thu, 14 Aug 2008 12:42:55 +1000 (EST) James Morris <jmorris@namei.org> w= 6#next-creds Thanks. I have fetched it for today's linux-next. --=20 Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/
Aug 13, 8:11 pm 2008
James Morris
Resolved XFS conflict in next-creds
I resolved the following conflict with Linus' tree in: git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next-creds commit 4030dcef54030fdb4ad6ff3813ac031d7afbdf35 Merge: 1e058f1... 8d0968a... Author: James Morris <jmorris@namei.org> Date: Thu Aug 14 10:43:47 2008 +1000 Merge branch 'master' into next-creds Conflicts: fs/xfs/xfs_acl.c Signed-off-by: James Morris <jmorris@namei.org> diff --cc fs/xfs/xfs_acl.c index ...
Aug 13, 7:42 pm 2008
Akinobu Mita
[PATCH] brd: fix name argument of unregister_blkdev()
The name of brd block device is "ramdisk", it's not "brd". (The block device is registered by register_blkdev(RAMDISK_MAJOR, "ramdisk") So it should be unregistered by unregister_blkdev(RAMDISK_MAJOR, "ramdisk") Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Cc: Nick Piggin <npiggin@suse.de> --- drivers/block/brd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: 2.6-git/drivers/block/brd.c =================================================================== --- ...
Aug 13, 7:32 pm 2008
David Brownell
Re: [GIT PATCH] USB patches for 2.6.27-rc3
Minor clarifications. The musb_hdrc (*) driver is *currently* used on ARM, specifically a bunch of TI chips (**), but it's an IP core which has been licensed by various other vendors. That is: it's not ARM-specific. We already know about work adding Blackfin 5xx support, which I suspect will appear in the 2.6.28 timeframe, and I've also had queries from folk using this IP on some PowerPC systems too. - Dave (*) Mentor USB Highspeed Dual Role Controller (MUSB HDRC), from Mentor ...
Aug 13, 8:10 pm 2008
Greg KH
[GIT PATCH] USB patches for 2.6.27-rc3
Here are some USB patches for your 2.6.26-git tree. The majority of this patch is removing an old driver (auerswald), and adding a new one (musb, an USB embedded host/device combo on ARM systems). musb is totally self-contained, so that causes no problems with any other patches. The majority of the other changes are new device ids and bugfixes. Note, a new file got added for the sierra devices for their wierd usb-storage-type devices, but that too is self-contained and affects no one ...
Aug 13, 5:44 pm 2008
Karel Zak
[ANNOUNCE] util-linux-ng v2.14.1-rc1
The first util-linux-ng 2.14.1 release candidate is available at ftp://ftp.kernel.org/pub/linux/utils/util-linux-ng/ (Note that 2.14.1 is stable maintenance release.) Feedback and bug reports, as always, are welcomed. Karel Util-linux-ng 2.14.1 Release Notes ================================== ChangeLog between v2.14 and v2.14.1 ----------------------------------- For more details see ChangeLog files at: ...
Aug 13, 5:30 pm 2008
James Morris
[GIT] Credentials API wrappers for 2.6.27
The patch below from David Howells adds wrappers for the new credentials wrappers without utilizing them (except for XFS per below), so that subsystems may be converted over to the new API in smaller pieces. This approach was suggested by Stephen here: http://marc.info/?l=linux-kernel&m=121843301206340&w=2 Some changes were made to the XFS code to eliminate namespace collisions, and these have been updated according to feedback from Christoph (who has also since ok'd them to me ...
Aug 13, 5:10 pm 2008
David Miller
Re: [GIT]: Sparc
From: David Miller <davem@davemloft.net> While further testing I noticed a bug which I've pushed into the tree, please repull to fetch it if you haven't already, thanks! The following changes since commit 4f70f7a91bffdcc39f088748dc678953eb9a3fbd: David S. Miller (1): sparc64: Implement IRQ stacks. are available in the git repository at: master.kernel.org:/pub/scm/linux/kernel/git/davem/sparc-2.6.git master David S. Miller (1): sparc64: Handle stack trace attempts ...
Aug 13, 5:21 pm 2008
Alan D. Brunelle
Re: Linux 2.6.27-rc3: kernel BUG at mm/vmalloc.c - bisected
I came in this morning, and did a 'git bisect reset' and 'git pull' built, and everything booted fine. I don't know if some fix came in for something else, or if the problem got "hidden" (some sort of timing thing, so the problem still lurks). If you feel it's important to track this down, if you could give me instructions on how to break apart that one merge, I could then try individual kernels from there... Thanks, Alan --
Aug 14, 12:21 pm 2008
Rafael J. Wysocki
Re: Linux 2.6.27-rc3: kernel BUG at mm/vmalloc.c - bisected
I have created a Bugzilla entry at http://bugzilla.kernel.org/show_bug.cgi?id=11342 for this problem. I'll close it now, but please reopen if if the problem reappears. Thanks, Rafael --
Aug 14, 1:29 pm 2008
Rafael J. Wysocki
Re: Linux 2.6.27-rc3: kernel BUG at mm/vmalloc.c - bisected
This is a merge commit that introduced several changes into the Thanks, Rafael --
Aug 14, 9:14 am 2008
Darrick J. Wong
[PATCH v2] coretemp: Recognize Nehalem CPUs
Add in the CPUID for Nehalem chips. Signed-off-by: Darrick J. Wong <djwong@us.ibm.com> --- drivers/hwmon/coretemp.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c index 70239ac..93c1722 100644 --- a/drivers/hwmon/coretemp.c +++ b/drivers/hwmon/coretemp.c @@ -413,10 +413,11 @@ static int __init coretemp_init(void) for_each_online_cpu(i) { struct cpuinfo_x86 *c = &cpu_data(i); - /* check if family ...
Aug 13, 6:36 pm 2008
Kent Liu Aug 13, 6:11 pm 2008
Rudolf Marek
Re: [lm-sensors] [PATCH] coretemp: Recognize Nehalem CPUs
Hi Darrick, Please update the Documentation too. I have patch for the Intel Atom, but this one seems trivial, so lets push this one first. Thanks, Rudolf --
Aug 14, 12:07 am 2008
Tomas Winkler
Re: [ANNOUNCE] Wifi Link 5300 and 5100 Series
Yes, this was already reported, but I was not able to reproduce it so far on my machines. I'm still trying to locate is this iwl5000 branch ? Thanks Tomas --
Aug 14, 5:15 am 2008
Tomas Winkler
Re: [ANNOUNCE] Wifi Link 5300 and 5100 Series
Can you send me the exact laptop type? Thanks --
Aug 14, 6:03 am 2008
Will Simoneau
Re: [ANNOUNCE] Wifi Link 5300 and 5100 Series
It's a Sager NP5796 (Clevo M570TU).
Aug 14, 10:55 am 2008
Will Simoneau
Re: [ANNOUNCE] Wifi Link 5300 and 5100 Series
OK, that gave me very different kernel/driver versions. uname -r: 2.6.26-rc6-iwl-2.3.5-wl dmesg: iwlagn: Intel(R) Wireless WiFi Link AGN driver for Linux, 2.3.5ks iwlagn: Copyright(c) 2003-2008 Intel Corporation ACPI: PCI Interrupt 0000:07:00.0[A] -> GSI 17 (level, low) -> IRQ 17 PCI: Setting latency timer of device 0000:07:00.0 to 64 iwlagn: Detected Intel Wireless WiFi Link 5300AGN REV=3D0x24 iwlagn: Tunable channels: 13 802.11bg, 24 802.11a channels phy1: Selected rate control ...
Aug 14, 12:13 pm 2008
Tomas Winkler Aug 14, 11:09 am 2008
Will Simoneau
Re: [ANNOUNCE] Wifi Link 5300 and 5100 Series
5000 This is great news to me - my new Sager laptop has a 5300 card. However, it doesn't seem to work: iwlagn: Intel(R) Wireless WiFi Link AGN driver for Linux, 1.3.27ks iwlagn: Copyright(c) 2003-2008 Intel Corporation iwlagn 0000:07:00.0: PCI INT A -> GSI 17 (level, low) -> IRQ 17 iwlagn 0000:07:00.0: setting latency timer to 64 iwlagn: Detected Intel Wireless WiFi Link 5300AGN REV=3D0x24 iwlagn: Tunable channels: 13 802.11bg, 24 802.11a channels phy7: Selected rate control algorithm ...
Aug 13, 11:26 pm 2008
Andrew Morton
Re: [Bugme-new] [Bug 11323] New: /proc/diskstats does no ...
On Wed, 13 Aug 2008 16:51:12 -0700 It's useless. I have never ever ever ever wanted to know when random person X committed a patch to some local tree. The overwhelmingly most Spose that works. My usual recourse is searching the commits list, which has useful-to-humans ordering information. I suppose that partitioning a junk disk with lots of little partitions --
Aug 13, 5:20 pm 2008
Jeff Garzik Aug 14, 1:28 am 2008
Krzysztof Halasa Aug 14, 11:46 am 2008
Ingo Molnar
Re: [patch 3/3] x86, xsave: use BUG_ON() instead of BUIL ...
applied these patches to tip/x86/xsave: f65bc21: x86, xsave: use BUG_ON() instead of BUILD_BUG_ON() ed40595: x86, xsave: clear the user buffer before doing fxsave/xsave ee2b92a: x86, xsave: remove the redundant access_ok() in setup_rt_frame() thanks Suresh. Ingo --
Aug 14, 1:56 am 2008
Pekka Enberg Aug 14, 12:15 pm 2008
Theodore Tso
Re: [malware-list] TALPA - a threat model? well sorta.
We don't have a way of exporting this fact at the moment. I assume Well, if you're willing to try it out, as I've mentioned on my blog[1][2], ext4 is working pretty well on my laptop --- I'm running it as my primary filesystem. There are a few problems with ext3 filesystems converted to use ext4, as opposed to starting afresh via "mke2fs -t ext4dev /dev/hdXX" that we've just found in the past week (and fixed within a day or two, although they haven't been pushed to Linus yet), but overall, ...
Aug 14, 4:34 pm 2008
tvrtko.ursulin
Re: [malware-list] TALPA - a threat model? well sorta.
Hm, maybe by implementing a facility with which a client can register it's interface usage intent? Something like: register(I_HAVE_NO_INTEREST_IN_CONTENT); register(I_WANT_TO_EXAMINE_CONTENT); All former ones would run first because they only want to have the opportunity to block and do something unrelated to file content (like HSMs), and later group would be ran last since they want to examine the content. Ordering inside those two groups is not important because I don't see how a ...
Aug 14, 2:30 am 2008
Theodore Tso
Re: [malware-list] TALPA - a threat model? well sorta.
"Infected" just means to instantly return an error when the file is opened or if an already opened file descriptor is read or mmap'ed, right? If file is already mmaped(), what's the plan? Send a kill -9 to the process, even if it ends up kill off an emacs or openoffice If a userspace database knows that inode X, i_version Y was checked a day ago, and inode X still has i_version Y, even if that inode has been evicted from memory, the contents will be the same absent root messing about with ...
Aug 14, 8:50 am 2008
Theodore Tso
Re: [malware-list] TALPA - a threat model? well sorta.
We do need a standardized way of enabling it (since it does cost you something in performance, so not everyone will want it on), and a standardized way of reading i_version out to userspace. Maybe a mount option is the right way to do it, maybe not. We may want to take this to the linux-fs list and try to get agreements on these points; the main reason why it's not enabled by default in ext4 is because the NFSv4 advanced caching code is in common use (is it even in mainline)? - ...
Aug 14, 12:41 pm 2008
Arjan van de Ven
Re: TALPA - a threat model? well sorta.
On Thu, 14 Aug 2008 10:12:13 -0400 well... do you really need a response? I think we need to sort the interface issue on this for sure, and -- If you want to reach me at my work email, use arjan@linux.intel.com For development, discussion and tips for power savings, visit http://www.lesswatts.org --
Aug 14, 8:57 am 2008
Mihai
Re: [malware-list] TALPA - a threat model? well sorta.
I see. Well, as long as everyone sticks to _just_ the file scan. To be honest, the only immediate use of the patch that is/was in question, is a "natural" scanner for file servers (Samba, NFS etc). 7v5w7go9ub0o, however, might have some more ideas. :) I admit and I apologize, I got pretty worked up when people started asking questions like: "how do we protect the file scanner", when the answer should have been obvious: the way we protect any other daemon (service) today, by -- Mihai ...
Aug 14, 5:34 am 2008
J. Bruce Fields
Re: [malware-list] TALPA - a threat model? well sorta.
Oops, I'd love to, and it should be very easy. How do I find out if i_version is supported on a given superblock? There's nothing particularly "advanced" about this, by the way--this is a very minor variation on the caching model that nfs has always had, and our nfsv4 server is currently pretty broken without it. Actually, it's pretty broken even on nfsv2/v3 for filesystems with poor time resolution. --b. --
Aug 14, 2:21 pm 2008
Theodore Tso
Re: [malware-list] TALPA - a threat model? well sorta.
It's on-disk for some filesystems, in order to support NFsv4 advanced caching semantics (which means i_version has to survive a reboot, which means it has to be on disk). It is *not* on disk for ext3, although it is for ext4. - Ted --
Aug 14, 12:17 pm 2008
tvrtko.ursulin
RE: [malware-list] TALPA - a threat model? well sorta.
Small misunderstanding because both would block. If you go back to Ted's original post I was replying to, he was worried about how would anti-malware scanning interact with HSM since both may end up using the same interface. HSM, as far as I understand it, needs to block on open and "plant" the right file in place, while anti-malware also needs to block and examine the right content. That is why ordering matters, anti-malware needs to run after the content is put in place. And that is what ...
Aug 14, 5:27 am 2008
Christoph Hellwig
Re: [malware-list] TALPA - a threat model? well sorta.
I have not yet seen code actually using it at all, neither in mainline nor on one of the many nfs development lists. --
Aug 14, 1:20 pm 2008
tvrtko.ursulin
Re: TALPA - a threat model? well sorta.
It is in fact really simple with the proposed inode versioning approach. Any client which wants to invalidate the cache just needs to bump the global version number which will force a rescan on next access. Tvrtko Sophos Plc, The Pentagon, Abingdon Science Park, Abingdon, OX14 3YP, United Kingdom. Company Reg No 2096520. VAT Reg No GB 348 3873 20. --
Aug 14, 2:18 am 2008
7v5w7go9ub0o
Re: TALPA - a threat model? well sorta.
(this was posted in linux.kernel, before I realized there was a linux.kernel.malware. Hope it helps your discussion) (FYI. Dazuko may have trailblazed some of the issues now under discussion re: libmalware.so. It has worked well for me. It used to be an LKM, it is now a source patch. It is used in a number of commercial products) <http://dazuko.dnsalias.org/wiki/index.php/Main_Page> "A Virtual Device Driver to Allow Online File Access Control A common interface is needed, which ...
Aug 13, 5:14 pm 2008
Eric Paris
Re: [malware-list] TALPA - a threat model? well sorta.
There needs to be a way to say that an inode in cache needs to be rescanned. 3 states this flag can be. Clean, Dirty, Infected. The current talpa solution involves a global monotomically increasing counter every time you change virus defs or make some "interesting" change. If global == inode flag we are clean. If global == negative inode flag we are infected. if global > inode flag we are dirty and exporting i_version might be useful for better userspace caching, although I've yet to ...
Aug 14, 6:48 am 2008
Press, Jonathan
RE: [malware-list] TALPA - a threat model? well sorta.
PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBtYWx3YXJlLWxpc3QtYm91bmNl c0BkbWVzZy5wcmludGsubmV0IFttYWlsdG86bWFsd2FyZS1saXN0LQ0KPiBib3VuY2VzQGRtZXNn LnByaW50ay5uZXRdIE9uIEJlaGFsZiBPZiBNaWhhaSBEb24/dQ0KPiBTZW50OiBXZWRuZXNkYXks IEF1Z3VzdCAxMywgMjAwOCA4OjE4IFBNDQo+IFRvOiBBbmRpIEtsZWVuDQo+IENjOiBwZXRlcnpA aW5mcmFkZWFkLm9yZzsgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZzsgbWFsd2FyZS0NCj4g bGlzdEBsaXN0cy5wcmludGsubmV0OyBoY2hAaW5mcmFkZWFkLm9yZzsgdmlyb0B6ZW5pdi5saW51 eC5vcmcudWs7DQo+IGFsYW5AbHhvcmd1ay51a3V1 ...
Aug 14, 4:58 am 2008
Arnd Bergmann
Re: TALPA - a threat model? well sorta.
In this case, it seems to be the same kind of requirement that lead to dnotify and inotify, right? So in order to get the third notification syscall interface right, the obvious questions are: 1. How do you make it cleaner than inotify? 2. How do you make it more scalable than inotify? 3. Do you need it to do anything that inotify doesn't do, beyond 1. and 2.? Arnd <>< --
Aug 14, 6:00 am 2008
Arjan van de Ven
Re: [malware-list] TALPA - a threat model? well sorta.
On Thu, 14 Aug 2008 10:46:55 +0100 close isn't the answer just because you can write content to the file after that (and that's not just theoretical, glibc stdio supports mmap etc); "dirty" *has* to be the event anyway. It's not impossible to solve; even say a 1 second rearming delay would avoid 99.9% of the useless rescans while still making sure everything gets scanned at some point. Anyway this kind of policy can be done in userspace (and you can there's quite a few programs that open() ...
Aug 14, 6:46 am 2008
Theodore Tso
Re: [malware-list] TALPA - a threat model? well sorta.
So in essence, what I hear you saying is that all AV products want to work in a mode where the moment the inode falls out of the inode cache, and we lose the "clean" bit, when the inode is brought back into the cache, it will be scanned again. That is, the "clean" bit is never persistent, and never needs to be stored in memory. That seems fair; if it turns out there is an AV product that wants to optimize this a bit further, as long as we provide a persistent inode version/generation number, ...
Aug 14, 6:24 am 2008
7v5w7go9ub0o
Re: TALPA - a threat model? well sorta.
I just noticed a separate discussion about integrity-checking LKMs and LSMs. Obviously, a libmalware.so or Dazuko based integrity-checker would block a kernel from loading in a Trojaned LKM - noting that the MD5 had changed, and asking you to block, temporarily allow, or permanently allow the changed module. Another security benefit of your pursuit. HTH --
Aug 13, 7:25 pm 2008
Eric Paris
Re: [malware-list] TALPA - a threat model? well sorta.
We don't have a revocation mechanism in linux and this isn't about adding one. Your trying to turn this into something it isn't. If you have it opened and mmap'd you've got that file for as long as you want. I've already said that given Arjan's belief that we can move it read/write instead of open/close we are moving the open->read race to a mmap->fault race. It isn't perfect at stopping bad data flow, but its is i_version an on disk think? didn't realize that and just assumed it was in ...
Aug 14, 10:29 am 2008
Eric Paris
Re: TALPA - a threat model? well sorta.
I've been thinking about this more over night. I really like the idea for perf reasons but I'm scared of programs not expecting and thus poorly handling -EACCESS from read. Every program ever is going to expect that back from open, but once you have the fd open its not common. The idea of multiple concurrent outstanding async notifications is going to be much more difficult to code, but hey, who am I to complain. We could have outstanding async scanning requests for any number of ...
Aug 14, 7:12 am 2008
Mihai
Re: TALPA - a threat model? well sorta.
I honestly don't think we should worry about root. Sure, if the AV scanner happens to catch something (as a consequence of it's implementation), then very well. But designing an antimalware solution which assumes the root is compromised will throw us into security talks for years and I don't think we'll live to hear the end of them. We should focus on the regular users and fix (if needed) the current userland apps (ie. the ones that need root access to do their job). For anymore than ...
Aug 13, 5:18 pm 2008
Eric Paris
Re: [malware-list] TALPA - a threat model? well sorta.
Is there some pragmatic way in kernel to know if the inode I have corresponds to a persistent or in core only inode? I'll poke around myself and look. -Eris --
Aug 14, 12:20 pm 2008
tvrtko.ursulin
Re: [malware-list] TALPA - a threat model? well sorta.
Do I understand correctly that everyone agrees scanning whenever an inode gets dirty would be a terrible thing for performance? Another thing we have here is that malware could not be neccessariliy identified until the very last write (one example where it will always be the case are PDF files (I think)). So the whole question is at which point should be performing an async scan. Close seems like a natural point which should be ideal for majority of applications, I don't see how any ...
Aug 14, 2:46 am 2008
Christoph Hellwig
Re: [malware-list] TALPA - a threat model? well sorta.
It's not used at all on regular files except for ext4 with a non-default, undocumented mount option. XFS will grow it soon in a similar way as ext4, except that it will be documented or I might have even figured out by then how to just enabled it from nfsd. --
Aug 14, 12:34 pm 2008
Press, Jonathan
RE: [malware-list] TALPA - a threat model? well sorta.
I'm not sure I understand why "interest in content" means not blocking, and vice versa. However, I think this is a good idea if made more Jon Press --
Aug 14, 5:03 am 2008
Ingo Molnar
Re: [PATCH](retry 3) invalidate caches before going into ...
please put this into a unified include file, and as an inline - there's just a single callsite. That avoids duplication and also removes a function. Also, please run the patch through scripts/checkpatch, it would have Thanks, Ingo --
Aug 14, 6:49 am 2008
Arjan van de Ven
Re: [PATCH](retry 3) invalidate caches before going into ...
On Thu, 14 Aug 2008 08:45:04 -0500 looks good to me Acked-by: Arjan van de Ven <arjan@linux.intel.com> -- If you want to reach me at my work email, use arjan@linux.intel.com For development, discussion and tips for power savings, visit http://www.lesswatts.org --
Aug 14, 7:00 am 2008
Mark Langsdorf
Re: [PATCH](retry 3) invalidate caches before going into ...
When a CPU core is shut down, all of its caches need to be flushed to prevent stale data from causing errors if the core is resumed. Current Linux suspend code performs an assignment after the flush, which can add dirty data back to the cache.  On some AMD platforms, additional speculative reads have caused crashes on resume because of this dirty data. Relocate the cache flush to be the very last thing done before halting.  Tie into an assembly line so the compile will not reorder it.  Add ...
Aug 14, 6:45 am 2008
Mark Langsdorf
Re: [PATCH](retry 4) invalidate caches before going into ...
When a CPU core is shut down, all of its caches need to be flushed to prevent stale data from causing errors if the core is resumed. Current Linux suspend code performs an assignment after the flush, which can add dirty data back to the cache.  On some AMD platforms, additional speculative reads have caused crashes on resume because of this dirty data. Relocate the cache flush to be the very last thing done before halting.  Tie into an assembly line so the compile will not reorder it.  Add ...
Aug 14, 7:11 am 2008
Dmitry
Re: Tree for linux-next
That's the github problem. I'll try to find another place to host this git and will send a request again. Sorry for the noise. -- With best wishes Dmitry --
Aug 14, 3:59 am 2008
Yinghai Lu
Re: HPET regression in 2.6.26 versus 2.6.25 -- revert fo ...
why oops ? it that is not appended to res_kernel... YH --
Aug 14, 3:36 am 2008
Bill Fink
Re: HPET regression in 2.6.26 versus 2.6.25 -- revert fo ...
Hi David, I'm not sure Yinghai's revert patch is completely equivalent to a revert of the original problematic commit, by a side-by-side comparison of the original commit with his recent revert patch, but then I don't really know that code at all. In the original code there was a section (in e820_reserve_resources()): #ifdef CONFIG_KEXEC if (crashk_res.start != crashk_res.end) request_resource(res, &crashk_res); #endif If you don't have CONFIG_KEXEC defined in your ...
Aug 14, 3:04 am 2008
John Kacur
Re: drop overzealous ERROR: do not initialise statics to ...
On Wed, Aug 13, 2008 at 10:19 PM, Guennadi Liakhovetski That is true, but the point is that even the folks who invented the language don't have a problem with making the initialization explicit. I'm not even trying to argue that folks should do it one way or the other, I'm just saying it is unimportant, so let's drop it from checkpatch.pl and save ourselves a lot of pointless code churn. btw, see pg 94 of "The Practice of Programming" where the masters also explicitly initialize statics. --
Aug 14, 1:42 am 2008
Pavel Machek
Re: Power management for SCSI
Ok, I see, "its done at the wrong level" sounds pretty serious. First the general comments/questions: # #1. It's done at the wrong level: suspend "device" is actually a target #function. There's no way on a multi-lun device we want to keep the #flags and last_busy anywhere but in the target So... if there's one device with Lun0==cdrom1 and Lun1==cdrom2, it is a single target, and we want to keep flags/last busy common to all that? What is good data structure to add? I see scsi_tgt*.h, ...
Aug 14, 6:08 am 2008
Oliver Neukum
Re: [linux-pm] Power management for SCSI
The core problem is that you insist on a rigid bottom-to-top flow of autosuspensions. That's good for systems like USB and PCI which are trees for PM purposes. It makes no sense for true busses with equal members on the bus. Regards Oliver --
Aug 14, 2:43 pm 2008
Alan Stern
Re: [linux-pm] Power management for SCSI
Oh, I see. All right, yes. However USB in general _does_ have the property that child devices might not be able to accomplish much while the USB link is suspended, particularly if they are bus-powered. This The way I designed the autosuspend framework, you _can't_ do that. In my framework autosuspend and autoresume events propagate _up_ the device tree, not _down_. This means an autosuspend has to be initiated by the child SCSI layer, not by the USB layer. Which is as it should be, ...
Aug 14, 8:40 am 2008
Oliver Neukum
Re: [linux-pm] Power management for SCSI
But you cannot make the conclusion that the ultimate children should have any autosuspend attributes. We can implement autosuspend in usb storage and propagate the suspend calls down the tree without SCSI knowing about autosuspend. Such a system would have it drawbacks, but it'd be a lot simpler. Regards Oliver --
Aug 13, 11:08 pm 2008
Stefan Richter
Re: Power management for SCSI
Actually a command set driver like sd surely wants last_busy (time of last use) separate for each LU for auto-spindown, doesn't it? include/scsi/scsi_tgt*.h are for local target implementations. The representation of "remote" targets, as seen by local initiators, is include/scsi/scsi_device.h's struct scsi_target. -- Stefan Richter -=====-==--- =--- -===- http://arcgraph.de/sr/ --
Aug 14, 3:11 pm 2008
Pavel Machek
Re: [linux-pm] Power management for SCSI
Hmm... but suspended devices have very little power budget, right? So unless you have external power supply (2.5" frames generally don't), you can't really suspend and stay spinned up... -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --
Aug 14, 6:50 am 2008
Pavel Machek
Re: Power management for SCSI
Is this step in the right direction? Moved autosuspend from scsi_host_template to scsi_transport_template... Pavel diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index e4864d9..2b8cf09 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -320,14 +320,14 @@ static struct device_attribute *ahci_sde }; struct pci_dev *my_pdev; -int autosuspend_enabled = 0; /* HERE */ +int autosuspend_enabled = 1; /* HERE */ struct sleep_disabled_reason ahci_active = { ...
Aug 14, 8:56 am 2008
Alan Stern
Re: [linux-pm] Power management for SCSI
What can we do?... Real world devices don't always obey the spec. You could argue that the suspend current should be sufficient to maintain the contents of the cache, which would then be written out after resume. But even if that is true, it's a very fragile guarantee Think of it in two parts: idle-timeout detection and autosuspend. Presumably you don't object to the idle-timeout detection (which is needed for powering down links in general), and you don't argue against the ...
Aug 14, 8:47 am 2008
Oliver Neukum
Re: [linux-pm] Power management for SCSI
True, but the spec says that no state shall be lost. I don't really argue against flushing the caches. But I cannot that this would demand that we should implement autopsuspend for SCSI. It seems like overengineering to me. Regards Oliver --
Aug 14, 7:08 am 2008
Alan Stern
Re: [linux-pm] Power management for SCSI
My framework is tree-oriented because it's based on the driver model, which uses a tree of devices. Even on a true bus, the members can't be entirely equal -- one of them has to be closer to the CPU than the others are. If that one member is in a low-power state then the CPU can't communicate with anything on the bus, unlike when one of the other members is in a low-power state. (I suppose in theory there could be a situation in which the CPU has direct communication with a bunch of ...
Aug 14, 3:25 pm 2008
Pekka Enberg
Re: [RFC][PATCH] netconsole: avoid deadlock on printk fr ...
Hi David, It's not just the link status. We have assert() and debugging printks there under tp->lock as well which can also trigger the deadlock condition. Yeah, that works for the link status case, but not for things like the printks in rtl8139_tx_interrupt()... Hmm. Pekka --
Aug 14, 6:28 am 2008
David Miller
Re: [RFC][PATCH] netconsole: avoid deadlock on printk fr ...
From: Pekka J Enberg <penberg@cs.helsinki.fi> Why create a special purpose lock when the generic networking already is taking a lock for you to proect the TX path? Furthermore, as I just described in another reply, netpoll already knows that it might need to trylock() attempt on this lock in order to avoid the very deadlocks this thread is about. --
Aug 14, 3:15 pm 2008
David Miller
Re: [RFC][PATCH] netconsole: avoid deadlock on printk fr ...
From: "Pekka Enberg" <penberg@cs.helsinki.fi> Note that netconsole specifically does trylock on the netdev xmit lock specifically to handle this case. If you could command the TX path solely under this generic lock already provided by the generic networking, you could avoid this deadlock as well. This is yet another reason many other drivers don't get hit by this problem. The solution is built into netpoll but it only works if you use the provided generic locking mechanisms to mutex the ...
Aug 14, 3:13 pm 2008
Pekka J Enberg
Re: [RFC][PATCH] netconsole: avoid deadlock on printk fr ...
...so I guess something like the following (totally untested) patch could work. Pekka Subject: [PATCH] 8139too: avoid deadlock with netconsole From: Pekka Enberg <penberg@cs.helsinki.fi> As explained by Vegard Nossum, the 8139too driver can deadlock with netconsole: I encountered a hard-to-debug deadlock when I pulled out the plug of my RealTek 8139 which was also running netconsole: The driver wants to print a "link down" message. However, this triggers netconsole, which ...
Aug 14, 6:44 am 2008
Lukas Hejtmanek
Re: sysprof in 2.6.27 kernel
another feedback. I got No map at all processes even at those I got debug info installed. -- Lukáš Hejtmánek --
Aug 14, 4:10 am 2008
Lukas Hejtmanek
Re: sysprof in 2.6.27 kernel
and another one. sysproc gui reads user addresses from the sysprof pipe with null pointers. is this ok or is this a bug in sysprof kernel module? -- Lukáš Hejtmánek --
Aug 14, 4:56 am 2008
Christoph Hellwig
Re: UBIFS updates for 2.6.27
Ok. The other patch looks good to me from a quick glance. BTW, -fsdevel might be a better list than lkml for fs patches review. --
Aug 14, 12:27 pm 2008
Dave Chinner
Re: [GIT PULL] XFS update for 2.6.27-rc4
It spent the time between then and now in the -mm tree. Seems like nobody is building m68k out of -mm. I'm out for the next 3 days, but it seems to me that the easiest fix is to move that code out of the header (i.e. uninline them) so the patch below is only compile tested on x86_64 - I've got to go load a trailer and get moving... Cheers, Dave. -- Dave Chinner david@fromorbit.com Completions: Un-inline try_wait_for_completion and completion_done m68k fails to build with these ...
Aug 14, 3:51 pm 2008
Andrew Morton
Re: [GIT PULL] XFS update for 2.6.27-rc4
On Fri, 15 Aug 2008 08:51:30 +1000 I test m68k build regularly, but only allmodconfig. Our (complexity(config system) * complexity(header files)) is so large that compilation testing doesn't prove anything useful. You just have to check your homework very carefully and don earplugs for the I'll give it a whizz on a few architectures, but it looks quite safe from here. It looks like the uninlining was desirable from a size/speed POV anyway. --
Aug 14, 4:03 pm 2008
Geert Uytterhoeven
Re: [GIT PULL] XFS update for 2.6.27-rc4
This change (commit 39d2f1ab2a36ac527a6c41cfe689f50c239eaca3) seems to have broken the m68k build: | CC arch/m68k/kernel/asm-offsets.s | In file included from linux/include/linux/mm_types.h:12, | from linux/include/linux/sched.h:61, | from linux/arch/m68k/kernel/asm-offsets.c:12: | linux/include/linux/completion.h: In function 'try_wait_for_completion': | linux/include/linux/completion.h:80: error: dereferencing pointer to incomplete type | ...
Aug 14, 8:45 am 2008
Jeremy Fitzhardinge
Re: 2.6.26: thinkpad x60 is cooled passively
Yes, this seems like a widespread and chronic problem with these little Thinkpads. I've had both an X31 and X60 go bad this way, and a friend has had his X60 fail twice. A pity given how nice the rest of the machine is. J --
Aug 13, 5:45 pm 2008
Takashi Iwai
Re: linux-next: Tree for August 13
At Wed, 13 Aug 2008 16:40:37 +0200, Today's tree works fine. Thanks! Takashi --
Aug 14, 2:57 am 2008
Randy Dunlap
Re: linux-next: Tree for August 13 (nfsd)
Acked-by: Randy Dunlap <randy.dunlap@oracle.com> --- ~Randy Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA http://linuxplumbersconf.org/ --
Aug 14, 9:44 am 2008
J. Bruce Fields
Re: linux-next: Tree for August 13 (nfsd)
Thanks, I've updated the version in git://linux-nfs.org/~bfields/linux.git for-2.6.28 --
Aug 14, 3:47 pm 2008
Thomas Petazzoni
Re: linux-next: Tree for August 13 (nfsd)
Le Wed, 13 Aug 2008 14:09:31 -0400, Here is an incremental fix. --- Fixup configure out fs locks support This patch adds a few more stubs required to get NFS server to compile properly with CONFIG_FILE_LOCKING=n. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- include/linux/fs.h | 2 ++ 1 file changed, 2 insertions(+) Index: linuxdev/include/linux/fs.h =================================================================== --- ...
Aug 14, 2:16 am 2008
Torsten Kaiser
Re: Linux 2.6.27-rc3
On Wed, Aug 13, 2008 at 10:23 PM, Langsdorf, Mark On the first look the ACPI seems correct. The first two P00x objects have this PSD: Package (0x05) { 0x05, 0x00, 0x00000000, 0x000000FD, 0x00000002 } The other two have 0x00000001 at the third position. But as I don't really have a clue about ACPI, I'm attaching the complete SSDT so you can take look. Just ask, if you need the other ...
Aug 13, 11:04 pm 2008
Andi Kleen
Re: Warning in during hotplug on 2.6.27-rc2-git5
The only way I could see that happening if CPU_DEAD/CPU_ONLINE is not properly balanced. -Andi --
Aug 14, 9:34 am 2008
Langsdorf, Mark
RE: Warning in during hotplug on 2.6.27-rc2-git5
I'm still seeing it on 2.6.27-rc2, even with the patch here http://lkml.org/lkml/2008/7/30/171 and the wbinvd_halt code patch applied. Maybe something else broke in some of the recent hotplug changes? -Mark Langsdorf Operating System Research Center AMD --
Aug 14, 11:35 am 2008
Rafael J. Wysocki
Re: Warning in during hotplug on 2.6.27-rc2-git5
Hm, it seems that MCE is involved somehow. Andi, can you have a look at this, --
Aug 14, 8:53 am 2008
Langsdorf, Mark
RE: Warning in during hotplug on 2.6.27-rc2-git5
Disabling MCE did eliminate the error message. -Mark Langsdorf Operating System Research Center AMD --
Aug 14, 9:06 am 2008
Milan Plzik
RE: Possible CPU_IDLE bug [WAS: Re: Timer unstability on ...
Looks like this has helped; after cold reboot hpet=disable seems to help the system to run properly (on 2.6.26 kernel). I wonder what could cause these problems. In the meanwhile I learned that this machine doesn't do proper cleanup during reboot -- it seems that state before reboot affects the state after reboot, so I should probably do some re-testing with cold reboot after each attempt. I guess I tried hpet=disable some time ago and after quick reboot it did not work Thank ...
Aug 14, 4:40 am 2008
Thomas Gleixner
RE: Possible CPU_IDLE bug [WAS: Re: Timer unstability on ...
Can you please try "hpet=disable" on the kernel command line ? Thanks, tglx --
Aug 14, 2:00 am 2008
Milan Plzik
RE: Possible CPU_IDLE bug [WAS: Re: Timer unstability on ...
UPDATE: looks like it doesn't help always. I cold-booted twice, once hpet=disable didn't help and the timing was messed up, the other time it seemed to work just correctly. Maybe it's some race condition during startup, but I was not able to find any substantial difference in kernel messages emitted during boot, (just little changes like 2401.86 BogoMIPS --
Aug 14, 6:28 am 2008
Milan Plzik
RE: Possible CPU_IDLE bug [WAS: Re: Timer unstability on ...
I tried it just now, is performs a bit better than 2.6.26 (e.g. I don't get that "press any key unless nothing happens" states), even reports a bit more reasonable values of wakeups, but the system sometimes becomes rather slow (e.g. when playing video). I was not able to compile fglrx driver, so I had to change it to radeon one. And also, the number of wakeups reported is not very convincing, though, it changes from 300 to 600 (which is ~ two times the sum of wakeups) without any reason, and ...
Aug 14, 1:05 am 2008
amruth
KGDB kernel panic no init found in linux 2.6.26 after bo ...
Hi All I am configuring linux 2.6.26 kernel in laptop and transferring image to desktop. My desktop is IDE drive. I am getting kernel panic try init= option error after booting the kernel. I am trying to setup KGDB on linux 2.6.26 kernel between dev machine and test machine. I have issues and it is not working. I can get the kgdb to communicate but I cannot start init images to start. I am using Redhat grub configuration. Do we need apply any patch for 2.6.26 kernel. I am using 2.4.15.5-kgdb ...
Aug 13, 10:35 pm 2008
amruth
KGDB kernel panic no init found in linux 2.6.26 after bo ...
Hi All I am configuring linux 2.6.26 kernel in laptop and transferring image to desktop. My desktop is IDE drive. I am getting kernel panic try init= option error after booting the kernel. I am trying to setup KGDB on linux 2.6.26 kernel between dev machine and test machine. I have issues and it is not working. I can get the kgdb to communicate but I cannot start init images to start. I am using Redhat grub configuration. Do we need apply any patch for 2.6.26 kernel. I am using 2.4.15.5-kgdb ...
Aug 13, 10:35 pm 2008
David Collier-Brown
Re: RFC: I/O bandwidth controller
Actually it's a little-known easy problem. The capacity planning community does it all the time, but then describes it in terms that are only interesting (intelligible?) to an enthusiastic amateur mathematician (;-)) One finds the point, called N*, at which the throughput flattens out and and the response time starts to grow without bounds, and calls that level the maximum. In practice, one does an easier variant. One sets a response-time limit and throttles *everyone* ...
Aug 14, 4:18 am 2008
Johannes Weiner
[PATCH -v2] bootmem: fix aligning of node-relative index ...
Absolute alignment requirements may never be applied to node-relative offsets. Andreas Herrmann spotted this flaw when a bootmem allocation on an unaligned node was itself not aligned because the combination of an unaligned node with an aligned offset into that node is not garuanteed to be aligned itself. This patch introduces two helper functions that align a node-relative index or offset with respect to the node's starting address so that the absolute PFN or virtual address that results from ...
Aug 13, 5:18 pm 2008
Nick Piggin
Re: [git pull] core fixes
Hmm, thanks for merging this Ingo, but it didn't get upstream very nicely (first was merged the one totally broken patch I didn't even really test let alone propose for inclusion!). Then some window of other patches, then the incremental patch to fix it. I know it probably is easiest for your "vacuum the mailing list" mode of workflow. And it's not that I don't appreciate it, but what I care about most is the end result and that is suboptimal in this case. The argument that we lose the ...
Aug 13, 9:45 pm 2008
Frédéric Weisbecker
Re: [PATCH] trace: Fix some mistakes in error messages
I said my kernel version was 2.6.27-rc1 but in fact it still applies on last git tree. --
Aug 14, 6:13 am 2008
Ingo Molnar
Re: [PATCH] Resurect proper handling of maxcpus= kernel ...
applied to tip/x86/urgent, thanks Max. Ingo --
Aug 14, 2:11 am 2008
David Collier-Brown
Re: [malware-list] [RFC 0/5] [TALPA] Intro to a linuxint ...
Sidebar again... Alas, I don't remember what Ted's question was, so I tried to see if I could start a discussion about the most general one (;-)) --dave (not an AV guy) c-b -- David Collier-Brown | Always do right. This will gratify Sun Microsystems, Toronto | some people and astonish the rest davecb@sun.com | -- Mark Twain cell: (647) 833-9377, bridge: (877) 385-4099 code: 506 9191# --
Aug 14, 3:48 am 2008
Ingo Molnar
Re: [PATCH] cpuset: Rework sched domains and CPU hotplug ...
applied to tip/sched/cpuset, thanks. (will show up in tip/sched/urgent as well soon, for v2.6.27 merging.) Ingo --
Aug 14, 2:24 am 2008
Max Krasnyansky
Re: [PATCH] cpuset: Rework sched domains and CPU hotplug ...
Hmm, unless I'm missing something this one is unrelated. There are no cpu hotplug, sched or cpusets paths in the trace besides cpu_maps_update_begin(). But that one is taken in the regular destroy_workqueue() path. The issues is polldev_mutex and cpu_add_remove_lock nesting. I bet you can trigger that without cpusets. CC'ing Dmitry Torokhov. btw It seems to be triggered when X closes polled input device. There aren't that many of them $ git grep input_register_polled_device | wc -l ...
Aug 14, 11:21 am 2008
Ingo Molnar
Re: [PATCH] cpuset: Rework sched domains and CPU hotplug ...
FYI, this new lockdep warning showed up in -tip testing, after i added this patch. Ingo [ 59.750200] ======================================================= [ 59.750200] [ INFO: possible circular locking dependency detected ] [ 59.750200] 2.6.27-rc3-tip-00076-g75f9a29-dirty #1 [ 59.750200] ------------------------------------------------------- [ 59.750200] Xorg/6623 is trying to acquire lock: [ 59.750200] (cpu_add_remove_lock){--..}, at: [<c0147dae>] ...
Aug 14, 4:16 am 2008
Neil Horman
Re: [PATCH] crypto: obscure state information on free
Looks great to me. Thanks Herbert! Best -- /*************************************************** *Neil Horman *nhorman@tuxdriver.com *gpg keyid: 1024D / 0x92A74FA1 *http://pgp.mit.edu ***************************************************/ --
Aug 14, 5:21 am 2008
Herbert Xu
crypto: skcipher - Use RNG interface instead of get_rand ...
And here is the IV generator patch on top. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- commit 560a63d94d36641c83a8f533ed87bab95f6298bb Author: Herbert Xu <herbert@gondor.apana.org.au> Date: Thu Aug 14 22:21:31 2008 +1000 crypto: skcipher - Use RNG interface instead of get_random_bytes This patch ...
Aug 14, 5:23 am 2008
Herbert Xu
Re: [PATCH] crypto: obscure state information on free
Thanks Neil. I've merged this with the original patch and made some small changes on the API side, such as adding a reset helper and adding a krng that just uses get_random_bytes. Here is the final result against cryptodev-2.6. Let me know if you're OK with it and I'll push it out. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: ...
Aug 14, 4:51 am 2008
Neil Horman
Re: crypto: skcipher - Use RNG interface instead of get_ ...
Thumbs up. Thanks Herbert! -- /*************************************************** *Neil Horman *nhorman@tuxdriver.com *gpg keyid: 1024D / 0x92A74FA1 *http://pgp.mit.edu ***************************************************/ --
Aug 14, 8:28 am 2008
Linda Walsh
Re: XFS Lock debugging noise or real problem?
--- --- If it was limited to xfs_fsr, that'd be tolerable -- but its --- The lock-correctness code is described as a feature to provide "provability". It's not called "debugging" and I don't regard that as "debugging" -- but something that any production system that wants operational integrity over a minor 'speed hit', would "theoretically" want. If it is "debug" code, it should be labeled as such -- but code that can mathematically guarantee that parts of the kernel operate correctly ...
Aug 13, 6:04 pm 2008
Dave Chinner
Re: XFS Lock debugging noise or real problem?
generic code == non-filesystem specific kernel code that interfaces Any filesystem that does memory allocation with the same type of lock held that it might take when reclaiming a inode. This is a problem where we go: XFS: lock inode XFS: allocate memory VM: free some memory VM: shrink slab VM: prune inode cache (takes iprune_mutex) XFS: lock inode i.e. the VM recurses back into the filesystem and lockdep sees Basically we've been told by the lockdep folk ...
Aug 13, 5:41 pm 2008
Sam Ravnborg
Alpha - move header files [Was Re: [PATCH] h8300 move he ...
I have build-tested alpha with a simple header file move. Can I ask you to do a simple move of all header files for alpha like you did for h8300. [I could set up a git tree etc. but being busy with my new house arm] Thanks, Sam --
Aug 14, 3:01 pm 2008
Jeff Garzik Aug 14, 1:28 am 2008
Jeff Garzik Aug 14, 1:29 am 2008
Jeff Garzik Aug 14, 1:29 am 2008
Alexander Beregalov Aug 14, 3:51 am 2008
Thomas Petazzoni
Re: [PATCH -mm] fs.h: fix build error with !CONFIG_FILE_ ...
Le Sat, 9 Aug 2008 02:32:28 +0400, I must admit that I'm quite confused by the commit you're referring to. In which tree is it ? Anyway, this problem has already been fixed in the latest version of the patch I sent to LKML on August, 4th: http://marc.info/?l=linux-kernel&m=121802891417797&w=2 However, I just sent another fixup patch to LKML, required to get NFS server to compile with CONFIG_FILE_LOCKING=n. For reference, I copy it below. Sincerly, Thomas --- Fixup configure out ...
Aug 14, 2:19 am 2008
FUJITA Tomonori
Re: [PATCH update] ieee1394: sbp2: enforce s/g segment s ...
On Thu, 14 Aug 2008 09:12:01 +0200 (CEST) static inline unsigned scsi_sg_count(struct scsi_cmnd *cmd) --
Aug 14, 12:21 am 2008
FUJITA Tomonori
Re: [PATCH update] ieee1394: sbp2: enforce s/g segment s ...
On Wed, 13 Aug 2008 12:19:59 +0200 (CEST) You need to keep it? You can access to it via scsi_sg_count when Are you talking about? = To unmap a scatterlist, just call: pci_unmap_sg(pdev, sglist, nents, direction); Again, make sure DMA activity has already finished. PLEASE NOTE: The 'nents' argument to the pci_unmap_sg call must be the _same_ one you passed into the pci_map_sg call, it should _NOT_ be the 'count' value _returned_ from the ...
Aug 13, 5:55 pm 2008
Stefan Richter
Re: [PATCH update] ieee1394: sbp2: enforce s/g segment s ...
Yes, I can easily do it this way; fixed below. Right. How did I forget about that? From: Stefan Richter <stefanr@s5r6.in-berlin.de> Subject: ieee1394: sbp2: remove redundant struct members Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> --- drivers/ieee1394/sbp2.c | 14 +++++--------- drivers/ieee1394/sbp2.h | 4 ---- 2 files changed, 5 insertions(+), 13 deletions(-) Index: ...
Aug 14, 12:12 am 2008
Pavel Machek
Re: [PATCH 1/4] integrity: TPM internel kernel interface
Only 2 TPMs I've seen were on pluggable modules... which was fortunate because they slowed down boot by 5+ minutes, and broke it completely in other cases. Nickname 'kurvitko' (aka useless trash that breaks stuff). They are currently lying under my table, disconnected. (OTOH they were not on PCI, but on some low-count pin header). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --
Aug 14, 4:12 am 2008
Ivan Warren
[PATCH] S390 : Set SLI on PSF/PRSSD on Dasd ECKD initial ...
s390 Dasd ECKD Driver issues a Perform Subsystem Function/Prepare for Read Subsystem Data with a length of 16. However, some hardware (namely 3990/9390 and some version of ESS) only take 12 bytes and therefore, an Incorrect Length indication is returned, breaking CCW Command Chaining and leads to a failure to initialize the DASD. This patch sets the SLI CCW bit to prevent an incorrect length indication to be reported when the control unit expects a length of 12 ...
Aug 14, 11:26 am 2008
Martin Schwidefsky
Re: Fwd: [Patch 2.6] s390 - Allow ECKD devices to be use ...
That makes sense, can I get a signed-off-by for the patch please? -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. --
Aug 14, 8:07 am 2008
Jeff Garzik Aug 14, 1:45 am 2008
Anton Vorontsov
Re: [PATCH 1/3] gpiolib: make gpio_to_chip() public
As we always do with the GPIO API: gpio_direction_*() calls. -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 --
Aug 14, 7:14 am 2008
Anton Vorontsov
Re: [PATCH 1/3] gpiolib: make gpio_to_chip() public
Not exactly. But you can do this way, if you need to preserve a direction. What I did is a bit different though. qe_gpio_set_dedicated() actually just restores a mode that firmware had set up, including direction (since direction could be a part of dedicated configuration). That is, upon GPIO controller registration, we save all registers, then driver can set up a pin to a GPIO mode via standard API, and then it can _revert_ a pin to a dedicated function via qe_gpio_set_dedicated() call. ...
Aug 14, 8:10 am 2008
Laurent Pinchart
Re: [PATCH 0/3] Patches to support QE USB Host Controller
I need gpio_to_chip() (or another 'proper API') as well for RTS/CTS based f= low control in the CPM/CPM2 UART driver. Best regards, =2D-=20 Laurent Pinchart CSE Semaphore Belgium Chaussee de Bruxelles, 732A B-1410 Waterloo Belgium T +32 (2) 387 42 59 =46 +32 (2) 387 42 75
Aug 14, 5:15 am 2008
Laurent Pinchart
Re: [PATCH 1/3] gpiolib: make gpio_to_chip() public
=2D-=20 Laurent Pinchart CSE Semaphore Belgium Chaussee de Bruxelles, 732A B-1410 Waterloo Belgium T +32 (2) 387 42 59 =46 +32 (2) 387 42 75
Aug 14, 7:04 am 2008
Laurent Pinchart
Re: [PATCH 1/3] gpiolib: make gpio_to_chip() public
So the proper sequence to configure a pin in dedicated mode is to set the d= irection first (which will unset the dedicated mode bit) and then set dedic= ated mode (which will not touch the direction bit) ? =2D-=20 Laurent Pinchart CSE Semaphore Belgium Chaussee de Bruxelles, 732A B-1410 Waterloo Belgium T +32 (2) 387 42 59 =46 +32 (2) 387 42 75
Aug 14, 7:45 am 2008
Fernando Luis
Re: request->ioprio
Yes, with the current implementation the field is always zero, but things might change. Instead of passing 0 unconditionally I think we could use a function that extracts/calculates the ioprio of requests. The patch I sent you yesterday is the first step in that direction. Is this a valid approach for you? --
Aug 13, 9:26 pm 2008
Rusty Russell
Re: request->ioprio
The only semantic I assumed was "higher is better". The server (ie. host) can really only use the information to schedule between I/Os for that particular guest anyway. But it sounds like I should be passing "0" in there unconditionally until the kernel semantics are sorted out and I can do something more intelligent? I haven't checked, but I assume that's actually what's happening at the moment (the field is zero)? Rusty. --
Aug 13, 7:16 pm 2008
Rusty Russell
Re: [PATCH] virtio_blk: use a wrapper function to access ...
Yes. Obviously it makes more sense for Jens to queue this so: Acked-by: Rusty Russell <rusty@rustcorp.com.au> Thanks! Rusty. --
Aug 13, 9:42 pm 2008
Fernando Luis
Re: [PATCH] virtio_blk: use a wrapper function to access ...
Thank you Rusty. I'll be responding to this email with an updated patch because I noticed the function I introduced is misnamed (it should be req_get_ioprio() not req_get_bio()). --
Aug 13, 10:17 pm 2008
Fernando Luis
[PATCH] virtio_blk: use a wrapper function to access io ...
struct request has an ioprio member but it is never updated because currently bios do not hold io context information. The implication of this is that virtio_blk ends up passing useless information to the backend driver. That said, some IO schedulers such as CFQ do store io context information in struct request, but use private members for that, which means that that information cannot be directly accessed in a IO scheduler-independent way. This patch adds a function to obtain the ioprio of ...
Aug 13, 10:22 pm 2008
Jens Axboe Aug 14, 12:58 am 2008
Dave Hansen
Re: [Devel] Re: [RFC][PATCH 1/4] checkpoint-restart: gen ...
The only problem I can see with this is that you lose efficiency, especially when you have to build your checkpoint image with lots of things that are config-specific. The approach sounds like a good one in theory, but I'm a bit skeptical that we could stick to it in practice, in a mainline kernel where there are billions of config options. It is definitely something to strive for, though. Good point! -- Dave --
Aug 14, 8:16 am 2008
Pavel Machek
Re: [RFC][PATCH 1/4] checkpoint-restart: general infrast ...
If you do pass a socket, will it handle blocking correctly? Getting deadlocked task would be bad. What happens if I try to snapshot into /proc/self/fd/0 ? Or maybe restore from /proc/cmdline? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --
Aug 13, 10:53 pm 2008
Pavel Emelyanov Aug 14, 1:09 am 2008
Dave Hansen
Re: [RFC][PATCH 1/4] checkpoint-restart: general infrast ...
Heh, that's a good point. What was the other code where we kept coming up with deadlocks like that? Anyone remember? -- Dave --
Aug 14, 8:12 am 2008
Pavel Machek
Re: [linux-pm] [RFC][PATCH] PM: Rework disabling of user ...
Could this be moved into suspend_freeze_processes? It is related (usermode helper is disabled when no userland), and you will not have to call it from 3 places...? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --
Aug 13, 10:32 pm 2008
Jeremy Fitzhardinge
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
Ah, OK. I'd thought we started unlocked, but given that I've just been disassembling the kernel and looking at the lock prefixes, that's a bit of a braino on my part. BTW, using the ds prefix allows us to undo the hack of dealing with locked instructions with exception handlers. There was a bug where if we do lock->nop, then the address of a faulting instruction changes, so we need exception records for both the locked and unlocked forms. Using ds means the instruction size doesn't ...
Aug 14, 10:43 am 2008
Mathieu Desnoyers
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
A virtualized guest kernel could use that to limit its use of the overall machine CPU resources in different time periods. Policies can determine how many physical CPU a virtual machine can be tied to, and that may change depending on e.g. the workload or time of day. Having the ability to efficiently switch to UP for a long period of time seems important in this use-case. -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 --
Aug 13, 6:49 pm 2008
Mathieu Desnoyers
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
Nope, it's a custom-made machine from a company in the Montreal area. It has a Supermicro X7DAL-E motherboard and, well, I got 16GB of ram in it. Pretty useful to take large traces. Mathieu -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 --
Aug 14, 10:55 am 2008
Mathieu Desnoyers
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
Sure, here are the updated tables. Basically, they show no significant difference between the NOP and the DS segment selector prefix approaches. Xeon 2.0GHz Summary * replace smp lock prefixes with DS segment selector prefixes no lock prefix (s) with lock prefix (s) Speedup make -j1 kernel/ 33.94 +/- 0.07 34.91 +/- 0.27 2.8 % hackbench 50 2.99 +/- 0.01 3.74 +/- 0.01 25.1 % * replace smp lock prefixes with 0x90 ...
Aug 14, 9:58 am 2008
H. Peter Anvin
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
For reference, could you also compare replace smp lock with NOPs? -hpa --
Aug 14, 9:13 am 2008
Mathieu Desnoyers
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
I doubt it, because I made a "cache priming" run before the tests, which made sure the data was all populated in memory. But yeah, having different cpu clock calibration values/cpu clock frequency between reboots could also cause that kind of difference. -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 --
Aug 14, 11:09 am 2008
Roland McGrath
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
I agree, it only seems worthwhile to do this substitution when from the config+hardware it's determined at boot that nr_cpus_possible==1 (i.e. no CPU hotplug possibility). Thanks, Roland --
Aug 13, 6:26 pm 2008
Mathieu Desnoyers
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
I can't argue about the benefit of using VM CPU pinning to manage resources because I don't use it myself, but I ran some tests out of curiosity to find if uncontended locks were that cheap, and it turns out they aren't. Here are the results : Xeon 2.0GHz Summary no lock prefix (s) with lock prefix (s) Speedup make -j1 kernel/ 33.94 +/- 0.07 34.91 +/- 0.27 2.8 % hackbench 50 2.99 +/- 0.01 3.74 +/- 0.01 25.1 % Detail ...
Aug 14, 8:18 am 2008
Jeremy Fitzhardinge
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
I would say that comment is wrong. But we'd never put a lock prefix on a prefetch, so you won't be added a ds prefix either. J --
Aug 14, 2:46 pm 2008
Jeremy Fitzhardinge
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
Not very convinced. Unplugging cpus is a pretty coarse way to control resource use. There are lots of other mechanisms. And it's not like an uncontended lock is all that expensive these days... J --
Aug 13, 8:35 pm 2008
Jeremy Fitzhardinge
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
The kernel sets ds and ss to the same selector, so they're always going to have the same underlying descriptor. My only concern is whether there are any locked instructions which are explicitly using a cs: override for those odd corners of the kernel. I don't think so. That said, I wonder how useful it is to do the SMP->UP code transition. How often does a kernel go from being SMP to UP in a situation where we really care about the performance? And that won't be shortly be ...
Aug 13, 6:22 pm 2008
Mathieu Desnoyers
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
So should I wait a bit for more comments or straightforwardly submit this as a patch rather than RFC ? Mathieu -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 --
Aug 14, 11:53 am 2008
Mathieu Desnoyers
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
I did more runs (20 runs of each) to compare the nop case to the DS prefix case. Results in seconds. They actually does not seems to show a significant ...
Aug 14, 12:49 pm 2008
H. Peter Anvin
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
Using %ds: rather than nop really seems to solve a whole lot of problems, and might even be faster to boot. It really sounds like a no-brainer. -hpa --
Aug 14, 11:37 am 2008
H. Peter Anvin
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
He doesn't specify what kind of Xeon it is (there are three completely different CPUs under the Xeon brand name: P3 Xeon, P4 Xeon, and Core 2 Xeon), but I think it's a P4 Xeon. Netburst sucked in so many ways, and this is one of them. -hpa --
Aug 14, 10:18 am 2008
Jeremy Fitzhardinge
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
I've given up trying to remember what "E5405" might mean, but that feature list suggests a relatively modern microarchitecture. J --
Aug 14, 10:28 am 2008
Jeremy Fitzhardinge
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
Looks like all the relevant people have reviewed it now, so I don't think there's much more to say. J --
Aug 14, 12:29 pm 2008
Mathieu Desnoyers
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
Here are the specs. It's a brand new 64bits dual quad-core (Christmas in August) :-) None of the specs seems to talk about neither Core2 or Pentium 4 though. Those appellations seems to hold for desktop processors, not server processors... processor : 0 vendor_id : GenuineIntel cpu family : 6 model : 23 model name : Intel(R) Xeon(R) CPU E5405 @ 2.00GHz stepping : 6 cpu MHz : 2000.109 cache size : 6144 KB physical id : 0 siblings : 1 core id : 0 cpu cores : ...
Aug 14, 10:46 am 2008
H. Peter Anvin
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
Actually, unless I have blown my T-test completely, they show with a 80% and 74% confidence (respective for the two benchmarks) that the DS case is slightly *better* (0.26% and 0.20% better, respective), which makes it a no-brainer. Doing around 10 runs of each is likely to confirm this conclusion by pushing it into the 90+% interval. Note that since the difference is so small, and so can also be due to some kind of systematic error (lower ambient temperature during the DS run making ...
Aug 14, 10:17 am 2008
Jeremy Fitzhardinge
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
Is it a Dell thingy? Turns out my main test box has exactly the same processor. J --
Aug 14, 10:49 am 2008
H. Peter Anvin
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
E5405 is the 45 nm Core 2 Quad Xeon. -hpa --
Aug 14, 10:31 am 2008
H. Peter Anvin
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
Locking prefetches is definitely wrong :) I don't know if the comment is correct; I've certainly never heard of that myself. -hpa --
Aug 14, 3:26 pm 2008
H. Peter Anvin
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
They do not signal faults, there just aren't any base addresses behind them. Some AMD chips allow limits to be set on these segments -- apparently added on behalf of some hypervisor makers; I suspect that VMX/SVM is making that quickly obsolete. So it should be just fine. Acked-by: H. Peter Anvin <hpa@zytor.com> -hpa --
Aug 14, 1:39 pm 2008
Jeremy Fitzhardinge
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
OK, let me clarify my point a bit. If you've got a kernel which is switching between UP and SMP on a regular basis, you're going to be taking the hit for the locked instructions whenever you're in the SMP state anyway. It's only going to be a workload where you're mostly UP with occasional excursions into being SMP that patching out the lock prefixes is actually going to make a difference. And that just doesn't seem like a very likely use-case to me. Certainly I don't think it would ...
Aug 14, 10:04 am 2008
Jeremy Fitzhardinge
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
BTW, are you changing the initial prefix to DS too? Ie, are you doing a nop->lock->ds transition, or ds->lock->ds? J --
Aug 14, 10:05 am 2008
Mathieu Desnoyers
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
I guess some testing of this patch under an virtualized Linux would not hurt. Anyone have a setup ready ? The test case is simple : Run a kernel on a multi-CPU virtual guest. export NR_CPUS=... Reading the "Intel Architecture Optimizations Manual" for older Intels : http://developer.intel.com/design/pentium/manuals/242816.htm Chapter 3.7 Prefixed Opcodes The penality for instructions prefixed with other prefixes than 0x0f, 0x66 or 0x67 seems to be 1 added clock cycle to detect the ...
Aug 13, 6:13 pm 2008
Gregory Haskins Aug 14, 11:59 am 2008
Mathieu Desnoyers
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
Yeah, I thought about this case yesterday, good thing you ask. include/asm-x86/alternative.h defines LOCK_PREFIX as : #define LOCK_PREFIX \ ".section .smp_locks,\"a\"\n" \ _ASM_ALIGN "\n" \ _ASM_PTR "661f\n" /* address */ \ ".previous\n" \ "661:\n\tlock; " So we have the locked instructions built into the kernel, not the nop'd one. Therefore, the only transition I am doing ...
Aug 14, 10:30 am 2008
H. Peter Anvin
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
I believe this should be okay. In 32-bit mode some of the security and hypervisor frameworks want to set segment limits, but I don't believe they ever would set DS and SS inconsistently, or that we'd handle a #GP versus an #SS differently (segment violations on the stack segment are #SS, not #GP.) To be 100% sure we'd have to pick apart the modr/m byte to figure out what the base register is but I think that's total overkill. I have a vague notion that DS: prefixes came with a penalty ...
Aug 13, 5:01 pm 2008
Linus Torvalds
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
Absolutely. Locked ops show up not just in microbenchmarks looping over the instruction, they show up in "real" benchmarks too. We added a single locked instruction (maybe it was two) to the page fault handling code some time ago, and the reason I noticed it was that it actually made the page fault cost visibly more expensive in lmbench. That was a _single_ instruction in the hot path (or maybe two). And the page fault path is some of the most timing critical in the whole kernel ...
Aug 14, 9:10 am 2008
Mathieu Desnoyers
Re: [RFC PATCH] x86 alternatives : fix LOCK_PREFIX race ...
I'm just worried about this comment from Harvey Harrison : arch/x86/mm/fault.c : is_prefetch() * Values 0x26,0x2E,0x36,0x3E are valid x86 prefixes. * In X86_64 long mode, the CPU will signal invalid * opcode if some of these prefixes are present so * X86_64 will never get here anyway */ This comment refers to : 0x26 : ES segment override prefix 0x2E : CS segment ...
Aug 14, 1:31 pm 2008
Thomas Gleixner
Re: 2.6.27-rc0 Power Bugs with HP/Compaq Laptops
Matt, Can you please try 2.6.27-rc3 or Linus latest git ? Also please provide a full boot log. Thanks, tglx --
Aug 14, 5:02 am 2008
Jeff Garzik Aug 14, 1:44 am 2008
Alexander Huemer
Re: 2.6.27-rc1 mtrr fixes do not work
2.6.27_rc3 does not solve the problem either. what can i do to help? -- alex --
Aug 14, 7:09 am 2008
Yinghai Lu
Re: 2.6.27-rc1 mtrr fixes do not work
On Thu, Aug 14, 2008 at 7:09 AM, Alexander Huemer please send out you config YH --
Aug 14, 10:31 am 2008
Milan Broz
Re: 2.6.27-rc1: critical thermal shutdown on thinkpad x6 ...
(adding cc: stable, the bug is also in 2.6.26.2) yep, thanks. I am running my x60s with this patch now: -- Fix signed parameter in ACPI frequency notifier. static unsigned int ignore_ppc = -1; ... if (event == CPUFREQ_START && ignore_ppc <= 0) { ignore_ppc = 0; ... Signed-off-by: Milan Broz <mbroz@redhat.com> --- drivers/acpi/processor_perflib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: ...
Aug 14, 6:56 am 2008
Ingo Molnar
Re: 2.6.27rc1 cannot boot more than 8CPUs
could you post the full dmesg? And the modified patch that you've tested to both have 8 CPUs without bigsmp and which also shows the printk? Ingo --
Aug 14, 2:07 am 2008
Jeff Chua
Re: 2.6.27rc1 cannot boot more than 8CPUs
Ok, booted up and not hanged, but those messages below don't show up anywhere. I've tested with CONFIG_NR_CPUS=16 and 8 as well. Just got 8 cpus More than 8 CPUs detected - skipping them. Use CONFIG_X86_GENERICARCH and CONFIG_X86_BIGSMP. # cat /sys/devices/system/cpu/possible 0-7 CONFIG_X86_32=y CONFIG_X86_PC=y Looks like it's not going into this condition + if (def_to_bigsmp && nr_cpu_ids > 8) { Shall this be put back so that it'll show the message? - if ...
Aug 14, 12:16 am 2008
Yinghai Lu
Re: 2.6.27rc1 cannot boot more than 8CPUs
double checked on one 16 cores system got CPU: L1 I Cache: 64K (64 bytes/line), D cache 64K (64 bytes/line) CPU: L2 Cache: 512K (64 bytes/line) CPU 0(4) -> Core 0 Intel machine check architecture supported. Intel machine check reporting enabled on CPU#0. using C1E aware idle routine Checking 'hlt' instruction... OK. ACPI: Core revision 20080609 Parsing all Control Methods: Table [DSDT](id 0001) - 1289 Objects with 114 Devices 462 Methods 26 Regions Parsing all Control Methods: Table ...
Aug 14, 1:59 am 2008
Andi Kleen
Re: Btrfs v0.16 released
But without duplication they are basically free here at least in IO rate. Seems odd? Does it compute them twice in the duplication case perhaps? -Andi --
Aug 14, 2:17 pm 2008
Chris Mason
Re: Btrfs v0.16 released
I spent a bunch of time hammering on different ways to fix this without increasing nr_requests, and it was a mixture of needing better tuning in btrfs and needing to init mapping->writeback_index on inode allocation. So, today's numbers for creating 30 kernel trees in sequence: Btrfs defaults 57.41 MB/s Btrfs dup no csum 74.59 MB/s Btrfs no duplication 76.83 MB/s Btrfs no dup no csum no inline 76.85 MB/s Ext4 data=writeback, delalloc 60.50 ...
Aug 14, 2:00 pm 2008
Theodore Tso
Re: Btrfs v0.16 released
What sort of script are you using? Basically something like this? for i in `seq 1 30` do mkdir $i; cd $i tar xjf /usr/src/linux-2.6.28.tar.bz2 cd .. done - Ted --
Aug 14, 4:44 pm 2008
Joe Peterson
[PATCH] Re: tty: ctrl-c not always echoed, especially un ...
Attached is a patch that addresses the issue of lost character echos during program output and in a stopped tty. The patch adds an "echo buffer" to N_TTY that handles all ldisc-generated output (including echoed characters). The main thing this solves is the loss of characters when they cannot be immediately written to the tty driver. Highlights are: * ^C (and other chars) are no longer lost when write buffer is full - (often happens with continuous program output) * Character echoes are ...
Aug 14, 9:19 am 2008
Pavel Machek
Re: [malware-list] [RFC 0/5] [TALPA] Intro to a linuxint ...
Yes, there are about 5 suid binaries on typical linux system. Link That is does not work? (Neither does LD_PRELOAD; it still has the old mmap problem. Too bad, but at least you get 99.9% coverage of all the apps). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --
Aug 14, 5:56 am 2008
Press, Jonathan Aug 14, 11:37 am 2008
Pavel Machek
Re: [malware-list] [RFC 0/5] [TALPA] Intro to a linuxint ...
Hi! Okay, so goal of libmalware.so is to "not allow data in the black list to pass through Linux server". Threat model is windows machines trying to copy infected files through the server. Viruses are not expected to mmap problem: libmalware.so would not offer mmap() to applications (or maybe it would do copy of the file, then allow mmap on the copy). kernel NFS server is not handled; don't use it for serving Windows clients. Not that you need performance for that, anyway. Obviously ...
Aug 14, 5:54 am 2008
Pavel Machek
Re: [malware-list] [RFC 0/5] [TALPA] Intro to a linuxint ...
I think I acknowledged inability to handle knfsd... just don't use knfsd, then. Its not like nfs is critical for communicating with Windows, right? That is still better than proposed solution here -- TALPA breaks with mmap, or when someone does read too soon after write. Marketing "antivirus" system that is racy be design seems to deserve some manure. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) ...
Aug 14, 3:35 pm 2008
Pavel Machek
Re: [malware-list] [RFC 0/5] [TALPA] Intro to alinuxinte ...
Yes, that's the part libmalware.so proposal solves. Given scary number Yep, so... why don't you propose something better? I'm pretty sure 100% reliable scanning is impossible without modifying applications, but hey, you can prove me wrong. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --
Aug 14, 3:39 pm 2008
Alan Cox
Re: [malware-list] [RFC 0/5] [TALPA] Intro to a linuxint ...
And knfsd ? Oh yes you don't seem to have an answer just manure to throw --
Aug 14, 1:06 pm 2008
Peter Zijlstra
Re: [PATCH RFC] pm_qos_requirement might sleep
My suggestion was to keep the locking for the write side - so as to avoid stuff stomping on one another, but drop the read side as: spin_lock foo = var; spin_unlock return foo; is kinda useless, it doesn't actually serialize against the usage of foo, that is, once it gets used, var might already have acquired a new value. The only thing it would protect is reading var, but since that is a machine sized read, its atomic anyway (assuming its naturally aligned). So no need for ...
Aug 14, 10:48 am 2008
John Kacur
Re: [PATCH RFC] pm_qos_requirement might sleep
Thanks Peter. Mark, is the following patch ok with you? This should be applied to mainline, and then after that no special patches are necessary for real-time. Thanks John Kacur
Aug 14, 3:51 pm 2008
mark gross
Re: [PATCH RFC] pm_qos_requirement might sleep
I was confused about this point, as I thought I saw raw_spinlock defined thanks, This code is doing list deletions, insertions and walks / element updates in a multi threaded environment where many processes on many CPU's can be adding removing and updating PM_QOS request, a lot (tm). So I think I still need to locking for the list walking and list element updating code on face value. I'm not supper good with lists, perhaps there is a trick to protecting the lists better than the ...
Aug 14, 8:52 am 2008
David Brownell
Re: [PATCH] gpiolib: dump correct irq trigger type
I'll NAK this ... the trigger type is actually a bit problematic, it hasn't previously been maintained *anywhere* except possibly as platform-specific code. And if it were maintained, desc->status would be the right place: the flags for each action would otherwise need to be updated. However, given recent cleanups in handling of genirq triggering I think it's time for me to submit a patch to correct that little oversight. --
Aug 14, 3:24 pm 2008
Philip Langdale
Re: [PATCH 1/1] toshiba_acpi: Add support for bluetooth ...
Almost. Turns out there were two problems: 1) I was setting SW_RFKILL_ALL as a keybit instead of an swbit - so no events reported. Whoops. :-) 2) Maybe this shouldn't surprise me, but the expected switch semantics are that '1' means radios are on and 0 means they are killed - I thought it was the other way round. Now, when I release the kill switch, rfkill-input does indeed turn the radio on. Great. The remaining problem is that rfkill-input is setting it to soft-blocked when the switch ...
Aug 13, 11:58 pm 2008
Andrew Morton
Re: POSIX_FADV_DONTNEED
I assume you meant "whether", not "when". Not directly. I believe that the best way of obtaining that information remains mmap()ing the file then querying the presence of pages via mincore(). --
Aug 14, 9:15 am 2008
Trevor Woollacott [ ...
RE: POSIX_FADV_DONTNEED
Thanks for the response Andrew. Is there a way to check when the cached data has been freed after fadvise has been called? -----Original Message----- From: Andrew Morton [mailto:akpm@linux-foundation.org] Sent: Thursday, 14 August 2008 11:17 AM To: Trevor Woollacott [ MTN - Innovation Centre ] Cc: linux-kernel@vger.kernel.org Subject: Re: POSIX_FADV_DONTNEED On Fri, 1 Aug 2008 17:05:39 +0200 "Trevor Woollacott [ MTN - Innovation It tries to be nonblocking and will mostly succeed in ...
Aug 14, 3:26 am 2008
Andrew Morton
Re: POSIX_FADV_DONTNEED
It tries to be nonblocking and will mostly succeed in that. It might occasionally block on a metadata read or journal congestion or something, so it isn't guaranteed. --
Aug 14, 2:17 am 2008
Andrew Morton
Re: [PATCH] x86: pda_init: fix memory leak with CPU_HOTPLUG
It gives one the creeps seeing a trivially-triggerable panic() call in a non-__init codepath. And lo, one of pda_init's callers is __init and the other is __cpuinit. So this function can at least be made __cpuinit(). But if we can still panic the kernel if a GFP_ATOMIC allocation fails at cpu-hotplug time then that's still a problem. cpu_init() has the same shortcoming. --
Aug 14, 2:14 am 2008
Lukas Hejtmanek
Re: 2.6.27-rc1 oops when plugging USB disk
I'm unable to reproduce this any more with the current git head. -- Lukáš Hejtmánek --
Aug 14, 2:32 am 2008
Andrew Morton
Re: 2.6.27-rc1 oops when plugging USB disk
Is this still happening in 2.6.27-rc3? Thanks. --
Aug 14, 2:04 am 2008
Andrew Morton
Re: [patch 1/2] [PATCH 1/2] x86: Microcode patch loader ...
Needed a few fixups to apply against linux-next. While we're there, let's spell "matching" correctly. --- a/arch/x86/kernel/microcode.c~x86-microcode-patch-loader-style-corrections-fix +++ a/arch/x86/kernel/microcode.c @@ -264,7 +264,7 @@ static int microcode_sanity_check(void * * return 1 - found update * return < 0 - error */ -static int get_maching_microcode(void *mc, int cpu) +static int get_matching_microcode(void *mc, int cpu) { struct ucode_cpu_info *uci = ucode_cpu_info ...
Aug 13, 7:03 pm 2008
Andrew Morton
Re: [patch 2/2] [PATCH 2/2] x86: Fixed NULL function poi ...
The patch is no longer applicable to current sources. If the bug is sufficiently serious to warrant fixing in 2.6.25.x and in 2.6.26.x then please prepare patches against those kernels, including sufficient description to enable the -stable maintainers to understand why they need to merge it. Cc those patches to stable@kernel.org. Thanks. --
Aug 13, 7:05 pm 2008
Peter Oruba
Re: [patch 2/2] [PATCH 2/2] x86: Fixed NULL function poi ...
Andrew, that patch is only relevant in combination with the AMD microcode patch loader. Thanks, Peter -- | AMD Saxony Limited Liability Company & Co. KG Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany System | Register Court Dresden: HRA 4896 Research | General Partner authorized to represent: Center | AMD Saxony LLC (Wilmington, Delaware, US) | General Manager of AMD ...
Aug 14, 4:55 am 2008
Greg KH
Re: Core kernel parameters and /sys/parameters?
Did I write that comment? I sure don't remember it, sorry :) I don't have any plans on changing this, but I do know people use the /sys/module/MODULE_NAME/parameters interface today, why change it? thanks, greg k-h --
Aug 14, 3:25 pm 2008
Rusty Russell
Re: Core kernel parameters and /sys/parameters?
Well mainly that many of them aren't modules, so if a change was planned for some other reason I'd support it. And as I said, having core parameters (ie. converting things which are current __setup) appear in /sys/module/kernel/parameters/ is a bit strange. Cheers, Rusty. --
Aug 14, 4:32 pm 2008
Ingo Molnar
Re: [PATCH] Fix the race between walk_tg_tree and sched_ ...
applied to tip/sched/urgent - thanks. Ingo --
Aug 14, 1:46 am 2008
Peter Zijlstra Aug 14, 1:36 am 2008
David Miller
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator
From: Tom Tucker <tom@opengridcomputing.com> It's stateless because the full packet traverses the real networking stack and thus can be treated like any other packet. The data placement is a side effect that the networking stack can completely ignore if it chooses to. --
Aug 13, 6:37 pm 2008
Vladislav Bolkhovitin
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator
Also, there wasn't big difference between MTU 1500 and 9000, which is --
Aug 14, 11:30 am 2008
Vladislav Bolkhovitin
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator
Sure, I read what you wrote before writing (although, frankly, didn't get the idea). But I don't think that overall it would be as efficient The test used Myricom Myri-10G cards (myri10ge driver), which support LRO. And from ethtool -S output I conclude it was enabled. Just in case, I attached it, so you can recheck me. Thus, apparently, LRO doesn't make a fundamental difference. Maybe this particular implementation isn't too efficient, I don't know. I don't have enough information ...
Aug 14, 11:27 am 2008
David Miller
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator
From: Tom Tucker <tom@opengridcomputing.com> SKB's can be paged, in fact many devices already work by chopping up lists of pages that the driver gives to the card. NIU is one of several examples. The only difference between what a device like NIU is doing now and what I propose is smart determination of at what offset and into which buffers to do the demarcation. --
Aug 13, 7:07 pm 2008
Steve Wise
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator
How do you envision programming such a device? It will need TCP and iSCSI state to have any chance of doing useful and productive placement of data. The smarts about the iSCSI stateless offload hw will be in the device driver, probably the iscsi device driver. How will it gather the information from the TCP stack to insert the correct state for a flow into the hw cache? --
Aug 13, 6:52 pm 2008
Tom Tucker
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator
Is there any chance your could discuss exactly how a stateless adapter can determine if a network segment is in-order, next expected, minus productive ack, paws compliant, etc... without TCP state? I get how you can optimize "flows", but "flows" are a fancy name for a key (typically the four-tuple) that looks into a TCAM to get the "information" necessary to do header prediction. Can you explain how this "information" somehow doesn't qualify as "state". Doesn't the next expected ...
Aug 13, 6:26 pm 2008
David Miller
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator
From: Steve Wise <swise@opengridcomputing.com> The card can see the entire TCP stream, it doesn't need anything more than that. It can parse every packet header, see what kind of data transfer is being requested or responded to, etc. Look, I'm not going to design this whole friggin' thing for you guys. I've stated clearly what the base requirement is, which is that the packet is fully processed by the networking stack and that the card merely does data placement optimizations that the ...
Aug 13, 7:05 pm 2008
Tom Tucker
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator
Ok. Maybe we're getting somewhere here ... or at least I am :-) I'm not trying to be pedantic here but let me try and restate what I think you said above: - The "header" traverses the real networking stack - The "payload" is placed either by by the hardware if possible or by the native stack if on the exception path - The "header" may aggregate multiple PDU (RSO) - Data ready indications are controlled entirely by the software/real networking stack Thanks, Tom --
Aug 13, 6:57 pm 2008
David Miller
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator
From: Tom Tucker <tom@opengridcomputing.com> If you're getting packets out of order, data placement optimizations are the least of your concerns. In fact this is exactly where we want all of the advanced loss handling algorithms of the Linux TCP stack to get engaged. --
Aug 13, 7:09 pm 2008
Vladislav Bolkhovitin
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator
Sure, nobody is arguing against that. My points are: 1. All those are things not for near future. I don't think it can be implemented earlier than in a year time, but there is a huge demand for high speed and low CPU overhead iSCSI _now_. Nobody's satisfied by the fact that with the latest high end hardware he can saturate 10GbE link on only less than 50%(!). Additionally, for me, as an iSCSI target developer, it looks especially annoying that hardware requirements for _clients_ ...
Aug 14, 11:24 am 2008
Nicholas A. Bellinger
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator
Well, the first step wrt to this for us software folks is getting the Slicing by 8 algoritim CRC32C into the kernel.. This would be a great benefit for not just traditional iSCSI/TCP, but Linux/SCTP and I have always found this to be the historical case wrt iSCSI on x86 hardware. The rough estimate was that given identical hardware and network configuration, an iSCSI target talking to a SCSI subsystem layer would be able to handle 2x throughput compared to an iSCSI Initiator, Heh, I think ...
Aug 14, 2:59 pm 2008
Steve Wise
Re: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator
Thanks for finally stating it clearly. --
Aug 13, 7:44 pm 2008
Martin Schwidefsky
Re: [patch 1/3] kmsg: Kernel message catalog macros.
No, the kmsg-doc script will prevent that the kmsg message will become of of sync and it checks for duplicate numbers. The idea here is that the kmsg man pages are generated with the kernel compile (just try it Yes, and this has already happened with the s390 device driver messages. With the conversion to kmsg our developers removed a lot of crud from the code, this alone makes it worthwhile. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. --
Aug 14, 10:11 am 2008
Tim Hockin
Re: [patch 1/3] kmsg: Kernel message catalog macros.
On Thu, Aug 14, 2008 at 10:04 AM, Martin Schwidefsky We had talked internally about something like this: globally: // this is the actual implementation extern void send_kmsg(int level, const char *fmt, ...); // this is a convenience wrapper, maybe not needed as they get combinatoric #define kmsg_err(fmt, ...) \ send_kmsg(KERN_ERROR, fmt, ##__VA_ARGS__) inside a subsystem-specific header: #define mysubsys_kmsg_err(fmt, ...) \ kmsg_err("mysubsys:" ...
Aug 14, 11:50 am 2008
Tim Hockin
Re: [patch 1/3] kmsg: Kernel message catalog macros.
Oh, I agree with that. I personally don't care much for the msg ID part of this patch (I mean I don't care either way). It might be nice to have man pages, but I just see it becoming out of sync, duplicate numbers, etc. What I want to see is the elevation of these call-sites from "it's just a printk()" to "it's a report-worthy event and part of our user<->kernel API". I want people to add them when it's appropriate and then not change the strings later. I don't care if, in the end, they ...
Aug 14, 8:40 am 2008
Martin Schwidefsky
Re: [patch 1/3] kmsg: Kernel message catalog macros.
But what is the alternative to the #define to specify the base name of the message tag? KBUILD_MODNAME has been proposed but I don't think this is a good idea since I want the message tags to be independent of the Well the kmsg macros distinguish between id==0 and id>0 messages. For a id==0 message there is no documentation required and the kmsg prefix will be just the KMSG_COMPONENT. You could consider that to be "just another printk". For id>0 the kmsg macros will create the ...
Aug 14, 10:04 am 2008
Rusty Russell
Re: [patch 1/3] kmsg: Kernel message catalog macros.
Well, why would you do it with the preprocessor? It's simplest to spit it out at runtime. The (offline) catalogger will need to generate them, of course. Rusty. --
Aug 14, 4:22 pm 2008
Martin Schwidefsky
Re: [patch 1/3] kmsg: Kernel message catalog macros.
First, how do you do that with the C preprocessor? Second the kmsg-doc script will check that the message format strings match if a kmsg with a specific id is used in multiple locations. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. --
Aug 14, 10:07 am 2008
Rusty Russell
Re: [patch 1/3] kmsg: Kernel message catalog macros.
Well, if they're to be the same messages under the manual-numbering scheme, someone has to verify that they are really the same anyway. Not much more work to simply fix them in that case, is it? If it improves normal kernel messages, then everyone wins. Rusty. --
Aug 13, 6:53 pm 2008
Pavel Machek
Re: [PATCH 01/01][retry 3] x86: L3 cache index disable f ...
No, I meant we should check for permissions. Filesystem permissions are traditionaly not enough for stuff like this. if (capable(CAP_ADMIN)) or something? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --
Aug 14, 8:46 am 2008
Langsdorf, Mark
RE: [PATCH 01/01][retry 3] x86: L3 cache index disable f ...
I see what you mean. I'll add a check again capable(CAP_SYS_ADMIN). -Mark Langsdorf Operating System Research Center AMD --
Aug 14, 9:41 am 2008
Greg KH
Re: [PATCH 01/01][retry 3] x86: L3 cache index disable f ...
This should go into the header file and not the .c file right? It's best to keep #ifdef things in .h files. Also, you can drop the CONFIG_K8_NB test if you do that as well, as it's Trailing space, did you run this through scripts/checkpatch.pl? thanks, greg k-h --
Aug 14, 7:04 am 2008
Langsdorf, Mark
RE: [PATCH 01/01][retry 3] x86: L3 cache index disable f ...
The strlen can go - it's no longer necessary. If sscanf isn't safe in this context, there's a lot of code in drivers/cpufreq/cpufreq.c that I cribbed from that needs I don't think so. If it got this far, it is an AMD processor from family 0x10 or later, so it has wbinvd(). -Mark Langsdorf Operating System Research Center AMD --
Aug 14, 7:02 am 2008
Greg KH
Re: [PATCH 01/01][retry 5] x86: L3 cache index disable f ...
Why use an unsigned long for a single bit value? bool perhaps? thanks, greg k-h --
Aug 14, 10:10 am 2008
Mark Langsdorf
Re: [PATCH 01/01][retry 5] x86: L3 cache index disable f ...
New versions of AMD processors have support to disable parts of their L3 caches if too many MCEs are generated by the L3 cache.   This patch provides a /sysfs interface under the cache hierarchy to display which caches indices are disabled (if any) and to monitoring applications to disable a cache index. This patch does not set an automatic policy to disable the L3 cache.  Policy decisions would need to be made by a RAS handler.  This patch merely makes it easier to see what indices ...
Aug 14, 11:32 am 2008
Mark Langsdorf
Re: [PATCH 01/01][retry 4] x86: L3 cache index disable f ...
New versions of AMD processors have support to disable parts of their L3 caches if too many MCEs are generated by the L3 cache.   This patch provides a /sysfs interface under the cache hierarchy to display which caches indices are disabled (if any) and to monitoring applications to disable a cache index. This patch does not set an automatic policy to disable the L3 cache.  Policy decisions would need to be made by a RAS handler.  This patch merely makes it easier to see what indices are ...
Aug 14, 7:23 am 2008
Mark Langsdorf
Re: [PATCH 01/01][retry 5] x86: L3 cache index disable f ...
New versions of AMD processors have support to disable parts of their L3 caches if too many MCEs are generated by the L3 cache.   This patch provides a /sysfs interface under the cache hierarchy to display which caches indices are disabled (if any) and to monitoring applications to disable a cache index. This patch does not set an automatic policy to disable the L3 cache.  Policy decisions would need to be made by a RAS handler.  This patch merely makes it easier to see what indices ...
Aug 14, 9:48 am 2008
Pavel Machek
Re: [PATCH 01/01][retry 3] x86: L3 cache index disable f ...
Is it okay to strlen() on user-supplied data? Do they have to be Should it do if capable() test before doing such stuff? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --
Aug 14, 6:44 am 2008
Mark Langsdorf
Re: [PATCH 01/01][retry 3] x86: L3 cache index disable f ...
New versions of AMD processors have support to disable parts of their L3 caches if too many MCEs are generated by the L3 cache.   This patch provides a /sysfs interface under the cache hierarchy to display which caches indices are disabled (if any) and to monitoring applications to disable a cache index. This patch does not set an automatic policy to disable the L3 cache.  Policy decisions would need to be made by a RAS handler.  This patch merely makes it easier to see what indices are ...
Aug 14, 6:43 am 2008
Greg KH
Re: [PATCH] Intel Management Engine Interface
So you keep your employer in business :) Seriously, an ioctl for a hardware version number is total overkill here. Your other ioctls are also suspect, please repost with the description of why they are all needed, with documentation about the user/kernel interface you have created here. thanks, greg k-h --
Aug 13, 5:23 pm 2008
Greg KH
Re: [PATCH 1/7] dynamic debug v2 - infrastructure
<snip> Ok, I got the build problem with the usb-gadget drivers all worked out now, and added this to my driver-core tree. Very nice stuff, again, thanks for doing this. I'll work to clean up the USB drivers to all rely on this and not their separate CONFIG_USB_DEBUG option. Also, would it make sense to add a patch like the one below to this code? It might be nice to know when each module's debugging value is manually changed by the user for the log files. If you like it, I can merge ...
Aug 14, 7:53 am 2008
Greg KH
Re: [PATCH 1/7] dynamic debug v2 - infrastructure
Argh, that code is just horrible!!! I'll go split this up into separate sub-modules, like it really needs to be. That will solve this problem. Bah, why do people make things so hard... thanks, greg k-h --
Aug 13, 6:25 pm 2008
Jason Baron
Re: [PATCH 1/7] dynamic debug v2 - infrastructure
looks good. we might also want to add a message for the cases where are the modules are enabled/disabled too. thanks, -Jason --
Aug 14, 2:05 pm 2008
Greg KH
Re: [PATCH/RFC] pci: dynids.use_driver_data considered harmful
The technical reason was that this flag was needed to let some drivers work properly with the new_id file, right? It's pretty "trivial" to look to see if the field is set in the pci_id structure, that should be all that is needed, right? thanks, greg k-h --
Aug 14, 3:12 pm 2008
Paul Menage
Re: [PATCH][RFC] dirty balancing for cgroups
As well as deadlocks, in the case of cgroups a big advantage of dirty limits is that it makes it easier to "loan" memory to groups above and beyond what they have been guaranteed. As long as we limit the dirty/locked memory for a cgroup to its guarantee, and require any extra memory to be clean and unlocked, then we can reclaim it in a hurry if another cgroup (that had been guaranteed that memory) needs it. Paul --
Aug 14, 1:38 am 2008
Daniel Walker
Re: [PATCH 4/6] Replace inode flush semaphore with a com ...
I'm not suggesting anything concrete at this point, I'm just thinking about it. If you assume that most of the time your doing async flushing, you wouldn't often need to do blocking on the completion .. Another way of doing it would be drop the completion most of the time, and just use the flag. Then in the rare case that a function needs to block make a stack local completion, pass it as a pointer inside the xfs_inode_t, if it's non-null when the write is finished you would ...
Aug 13, 6:34 pm 2008
Dave Chinner
Re: [PATCH 4/6] Replace inode flush semaphore with a com ...
It's not really a flush lock at that point - it's a state lock. We've already got one of those, and a set of state flags that it protects. Basically you're suggesting that we keep external state to the completion that tracks whether a completion is in progress or not. You can't use a mutex like you suggested to protect state because you can't hold it while doing a wait_for_completion() and then use it to clear the state flag before calling complete(). We can use the internal inode state ...
Aug 13, 5:19 pm 2008
Dave Chinner
Re: [PATCH 4/6] Replace inode flush semaphore with a com ...
I don't think that will work, either - the internal completion counter must stay in sync so there must be a wait_for_completion() call for every complete() call. If we make the wait_for_completion() conditional, then we have to do the same thing for the complete() call, and that introduces complexity and potential races because the external flag and the completion cannot be updated atomically.... Cheers, Dave. -- Dave Chinner david@fromorbit.com --
Aug 13, 7:30 pm 2008
Alexander Beregalov
Re: 2.6.26-rc: SPARC: Sun Ultra 10 can not boot
Bogus migrate type 6 Usemap for section 0 corrupted paging_init+0xcac/0xd38[arch/sparc64/mm/init.c:1795] 1790 #ifndef CONFIG_NEED_MULTIPLE_NODES 1791 max_mapnr = last_valid_pfn; 1792 #endif 1793 sparse_validate_usemap(__FILE__, __LINE__); 1794 kernel_physical_mapping_init(); 1795 sparse_validate_usemap(__FILE__, __LINE__); 1796 1797 { 1798 unsigned long max_zone_pfns[MAX_NR_ZONES]; 1799 Ultra 10, ...
Aug 14, 3:19 am 2008
David Miller
Re: 2.6.26-rc: SPARC: Sun Ultra 10 can not boot
From: "Alexander Beregalov" <a.beregalov@gmail.com> Mikulas Patocka is seeing the same bug (see thread "Re: console handover badness") I just posted the following patch there that can help track this down. Please try it out on your machine too. BTW, how much ram is in your system? Thanks. diff --git a/arch/sparc64/mm/init.c b/arch/sparc64/mm/init.c index 217de3e..26b018f 100644 --- a/arch/sparc64/mm/init.c +++ b/arch/sparc64/mm/init.c @@ -1643,6 +1643,8 @@ void __init ...
Aug 13, 8:53 pm 2008
David Miller
Re: console handover badness
From: Mikulas Patocka <mpatocka@redhat.com> Thanks, I've tried a lot of things to try and reproduce this myself but to no avail. Let's try to track down exactly where the corruption happens. Please try the debug patch below on your box. It will spit out a message something like: [ 0.000000] BUG: Bogus migrate type 5 [ 0.000000] BUG: Usemap for section 0 corrupted at sparse_init+0x17c/0x218[mm/sparse.c:498] The theory is that some other piece of code is either not allocating a ...
Aug 13, 8:25 pm 2008
Johannes Weiner
Re: Bootmem allocator broken
Hi Mikulas, Yes, taking last_end_off into account when it's page-aligned is bogus as the whole merging thing is about partial pages. Acked-by: Johannes Weiner <hannes@saeurebad.de> --
Aug 14, 4:40 pm 2008
Mikulas Patocka
Bootmem allocator broken [was: console handover badness]
Hi So I tried the patch and found out that the corruption happens in setup_command_line --- the first strcpy call corrupted the migratetype map. Examining the problem further, it turned out that Johannes Weiner committed new bootmem allocator to 2.6.27-rc1 and the allocator is broken. This is the minimal sequence that jams the allocator: void *p, *q, *r; p = alloc_bootmem(PAGE_SIZE); q = alloc_bootmem(64); free_bootmem(p, PAGE_SIZE); p = alloc_bootmem(PAGE_SIZE); r = ...
Aug 14, 4:11 pm 2008
David Miller
Re: Bootmem allocator broken
From: Mikulas Patocka <mpatocka@redhat.com> Date: Thu, 14 Aug 2008 19:11:19 -0400 (EDT) [ Adding Alexander back to the CC: as he is seeing this same Ok, I was just looking at Alexander's debugging dump from my patch and in his case it pointed to kernel_physical_mapping_init() and I couldn't find any obvious problems there. --
Aug 14, 4:25 pm 2008
Eduard - Gabriel Mun ...
Re: [PATCH 1/3] relay: Fix 4 off-by-one errors occuring ...
Looks nice, as I had already implemented a way to turn off kmemtrace when logging. I'll get back to you in a few days, I'm not close to home right now. BTW, did the kmemtrace user app work for you? Pekka seemed to have issues with compiling it. Thanks, Eduard --
Aug 14, 9:35 am 2008
Christoph Lameter
Re: No, really, stop trying to delete slab until you've ...
Hmmm.. Then the issue may be different than we thought. Lock may be taken recursively in some situations. Can you enable lockdep? --
Aug 14, 7:45 am 2008
Christoph Lameter
Re: No, really, stop trying to delete slab until you've ...
This is a NUMA system right? Then we have another mechanism that will avoid off node memory references by allocating new slabs. Can you set the node_defrag parameter to 0? (Noted by Adrian). --
Aug 14, 12:44 pm 2008
Christoph Lameter
Re: No, really, stop trying to delete slab until you've ...
At that point we take the listlock and then the slab lock which is a lock inversion if we do not use a trylock here. Crap. Hmmm.. The code already goes to the next slab if an earlier one is already locked. So I do not see how the large partial lists could be generated. --
Aug 14, 8:06 am 2008
Pekka Enberg
Re: No, really, stop trying to delete slab until you've ...
Hi Christoph, This patch hard locks on my 2-way 64-bit x86 machine (sysrq doesn't respond) when I run hackbench. --
Aug 14, 12:15 am 2008
Udo van den Heuvel
Re: 2.6.25 hald trace?
Hello, Aug 14 19:11:01 recorder kernel: INFO: task hald-addon-stor:1522 blocked for more than 120 seconds. Aug 14 19:11:01 recorder kernel: "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. Aug 14 19:11:01 recorder kernel: hald-addon-st D c04581d8 0 1522 1475 Aug 14 19:11:01 recorder kernel: ef83bbb4 00000086 0000000c c04581d8 00000246 f6df6e40 f6df6fa8 f6df6fa8 Aug 14 19:11:01 recorder kernel: 00000004 c025c709 ef83bc2c 7fffffff ef83bc14 ...
Aug 14, 10:17 am 2008
Maciej W. Rozycki Aug 14, 12:44 pm 2008
Maciej W. Rozycki
Re: [patch 7/8] x86: apic - unify sync_Arb_IDs
On Thu, 1 Jan 1970, Cyrill Gorcunov wrote: [etc...] Well, I think this one is backwards... There are exceptions, but the general rule is to with within the width of the terminal. Maciej --
Aug 14, 12:41 pm 2008
Cyrill Gorcunov
Re: [patch 7/8] x86: apic - unify sync_Arb_IDs
That happend sendmail/quilt sent mail by past :(. I'll fix and resend tomorrow. thanks. --
Aug 14, 1:10 pm 2008
previous daytodaynext day
August 13, 2008August 14, 2008August 15, 2008