Re: [patch 2/2] [PATCH 2/2] x86: Fixed NULL function pointer dereference in AMD microcode patch loader.

Previous thread: [patch 0/2] x86: microcode patch loader cleanup and fix by Peter Oruba on Friday, August 1, 2008 - 3:46 am. (2 messages)

Next thread: [patch 1/2] [PATCH 1/2] x86: Microcode patch loader style corrections by Peter Oruba on Friday, August 1, 2008 - 3:46 am. (2 messages)
From: Peter Oruba
Date: Friday, August 1, 2008 - 3:46 am

Dereference took place in code part responsible for manual installation
of microcode patches through /dev/cpu/microcode.

Signed-off-by: Peter Oruba <peter.oruba@amd.com>
---
 arch/x86/kernel/microcode.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/microcode.c b/arch/x86/kernel/microcode.c
index 39961bb..ad136ad 100644
--- a/arch/x86/kernel/microcode.c
+++ b/arch/x86/kernel/microcode.c
@@ -127,7 +127,8 @@ static int do_microcode_update(void)
 	old = current->cpus_allowed;
 
 	while ((cursor = microcode_ops->get_next_ucode(&new_mc, cursor)) > 0) {
-		error = microcode_ops->microcode_sanity_check(new_mc);
+		if (microcode_ops->microcode_sanity_check != NULL)
+			error = microcode_ops->microcode_sanity_check(new_mc);
 		if (error)
 			goto out;
 		/*
-- 
1.5.4.5




--

From: Andrew Morton
Date: Wednesday, August 13, 2008 - 7:05 pm

The patch is no longer applicable to current sources.

If the bug is sufficiently serious to warrant fixing in 2.6.25.x and in
2.6.26.x then please prepare patches against those kernels, including
sufficient description to enable the -stable maintainers to understand
why they need to merge it.  Cc those patches to stable@kernel.org.

Thanks.

--

From: Peter Oruba
Date: Thursday, August 14, 2008 - 4:55 am

Andrew,

that patch is only relevant in combination with the AMD microcode patch loader.

Thanks,
Peter


-- 
            |           AMD Saxony Limited Liability Company & Co. KG
  Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
  System    |                  Register Court Dresden: HRA 4896
  Research  |              General Partner authorized to represent:
  Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
            | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy

--

Previous thread: [patch 0/2] x86: microcode patch loader cleanup and fix by Peter Oruba on Friday, August 1, 2008 - 3:46 am. (2 messages)

Next thread: [patch 1/2] [PATCH 1/2] x86: Microcode patch loader style corrections by Peter Oruba on Friday, August 1, 2008 - 3:46 am. (2 messages)