Home » Mailing list archives » linux-kernel » 2008 » August » 14

Re: [PATCH 4/6] Replace inode flush semaphore with a completion

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Daniel Walker
Subject: Re: [PATCH 4/6] Replace inode flush semaphore with a completion
Date: Wednesday, August 13, 2008 - 6:34 pm

On Thu, 2008-08-14 at 10:19 +1000, Dave Chinner wrote:

I'm not suggesting anything concrete at this point, I'm just thinking
about it.

If you assume that most of the time your doing async flushing, you
wouldn't often need to do blocking on the completion .. Another way of
doing it would be drop the completion most of the time, and just use the
flag. Then in the rare case that a function needs to block make a stack
local completion, pass it as a pointer inside the xfs_inode_t, if it's
non-null when the write is finished you would complete().

Daniel

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/6] Remove most users of semaphores from XFS V2., Dave Chinner, (Fri Jun 27, 1:44 am)
[PATCH 1/6] Clean up stale references to semaphores, Dave Chinner, (Fri Jun 27, 1:44 am)
[PATCH 2/6] Replace the XFS buf iodone semaphore with a co ..., Dave Chinner, (Fri Jun 27, 1:44 am)
[PATCH 3/6] Extend completions to provide XFS object flush ..., Dave Chinner, (Fri Jun 27, 1:44 am)
[PATCH 4/6] Replace inode flush semaphore with a completion, Dave Chinner, (Fri Jun 27, 1:44 am)
[PATCH 5/6] Replace dquot flush semaphore with a completion, Dave Chinner, (Fri Jun 27, 1:44 am)
[PATCH 6/6] Remove the sema_t from XFS., Dave Chinner, (Fri Jun 27, 1:44 am)
Re: [PATCH 4/6] Replace inode flush semaphore with a compl ..., Daniel Walker, (Tue Aug 12, 8:11 pm)
Re: [PATCH 4/6] Replace inode flush semaphore with a compl ..., Dave Chinner, (Wed Aug 13, 12:50 am)
Re: [PATCH 4/6] Replace inode flush semaphore with a compl ..., Daniel Walker, (Wed Aug 13, 8:34 am)
Re: [PATCH 4/6] Replace inode flush semaphore with a compl ..., Dave Chinner, (Wed Aug 13, 5:19 pm)
Re: [PATCH 4/6] Replace inode flush semaphore with a compl ..., Daniel Walker, (Wed Aug 13, 6:34 pm)
Re: [PATCH 4/6] Replace inode flush semaphore with a compl ..., Dave Chinner, (Wed Aug 13, 7:30 pm)