Home » Mailing list archives » linux-kernel » 2008 » August » 13

Re: [PATCH] kexec jump: fix compiling warning on xchg(&kexec_lock, 0) in kernel_kexec()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Linus Torvalds <torvalds@...>
To: Andrew Morton <akpm@...>
Cc: <ebiederm@...>, <ying.huang@...>, <pavel@...>, <nigel@...>, <rjw@...>, <vgoyal@...>, <mingo@...>, <linux-kernel@...>, <kexec@...>
Subject: Re: [PATCH] kexec jump: fix compiling warning on xchg(&amp;kexec_lock, 0) in kernel_kexec()
Date: Wednesday, August 13, 2008 - 4:31 pm

On Wed, 13 Aug 2008, Andrew Morton wrote:

I thought you said there were things that want to sleep in the region?

If so, spinlocks will work as long as you don't have CONFIG_PREEMPT or 
lock validation (there's no way to deadlock thanks to all the lock getters 
using the "trylock" variant), but will blow up because a successful 
trylock will obviously also disable preemption and/or trigger all the lock 
detection.

So if there are potential sleepers, you'd need the mutex instead.

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] kexec jump: fix compiling warning on xchg(&amp;kexec..., Huang Ying, (Wed Aug 13, 5:12 am)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&amp;k..., Linus Torvalds, (Wed Aug 13, 12:57 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&amp;k..., Eric W. Biederman, (Wed Aug 13, 2:12 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&amp;k..., Andrew Morton, (Wed Aug 13, 3:44 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&amp;k..., Trond Myklebust, (Wed Aug 13, 4:15 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&amp;k..., Linus Torvalds, (Wed Aug 13, 3:50 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&amp;k..., Andrew Morton, (Wed Aug 13, 4:07 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&amp;k..., Linus Torvalds, (Wed Aug 13, 4:13 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&amp;k..., Andrew Morton, (Wed Aug 13, 4:25 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&k..., Linus Torvalds, (Wed Aug 13, 4:31 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&amp;k..., Andrew Morton, (Wed Aug 13, 4:41 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&amp;k..., Linus Torvalds, (Wed Aug 13, 6:17 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&amp;k..., Vivek Goyal, (Wed Aug 13, 5:21 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&amp;k..., Vivek Goyal, (Wed Aug 13, 2:31 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&amp;k..., Andrew Morton, (Wed Aug 13, 5:27 am)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&amp;k..., Linus Torvalds, (Wed Aug 13, 1:01 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&amp;k..., Andrew Morton, (Wed Aug 13, 1:25 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&amp;k..., Ingo Molnar, (Wed Aug 13, 1:59 pm)