Home » Mailing list archives » linux-kernel » 2008 » August » 13

[patch 1/3] x86, xsave: remove the redundant access_ok() in setup_rt_frame()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Suresh Siddha <suresh.b.siddha@...>
To: <mingo@...>, <hpa@...>, <tglx@...>
Cc: <linux-kernel@...>, Suresh Siddha <suresh.b.siddha@...>
Subject: [patch 1/3] x86, xsave: remove the redundant access_ok() in setup_rt_frame()
Date: Wednesday, August 13, 2008 - 2:38 pm

save_i387_xstate() is already doing the required access_ok(). Remove
the redundant access_ok() before it.

Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
---

Index: tip/arch/x86/kernel/signal_64.c
===================================================================
--- tip.orig/arch/x86/kernel/signal_64.c	2008-08-11 15:26:47.000000000 -0700
+++ tip/arch/x86/kernel/signal_64.c	2008-08-11 15:28:52.000000000 -0700
@@ -208,9 +208,6 @@
 		frame = (void __user *)round_down(
 			(unsigned long)fp - sizeof(struct rt_sigframe), 16) - 8;
 
-		if (!access_ok(VERIFY_WRITE, fp, sizeof(struct _fpstate)))
-			goto give_sigsegv;
-
 		if (save_i387_xstate(fp) < 0)
 			err |= -1;
 	} else

-- 

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 1/3] x86, xsave: remove the redundant access_ok() in ..., Suresh Siddha, (Wed Aug 13, 2:38 pm)