login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
August
»
13
Re: [PATCH] kexec jump: fix compiling warning on xchg(&kexec_lock, 0) in kernel_kexec()
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Vivek Goyal
Subject:
Re: [PATCH] kexec jump: fix compiling warning on xchg(&kexec_lock, 0) in kernel_kexec()
Date: Wednesday, August 13, 2008 - 11:31 am
On Wed, Aug 13, 2008 at 11:12:48AM -0700, Eric W. Biederman wrote:
quoted text
> Linus Torvalds <torvalds@linux-foundation.org> writes: > > > On Wed, 13 Aug 2008, Huang Ying wrote: > >> > >> - xchg(&kexec_lock, 0); > >> + locked = xchg(&kexec_lock, 0); > >> + BUG_ON(!locked); > > > > Why do you want to do this at all? > > > > And why do you implement your locks with xchg() in the first place? That's > > total and utter crap. > > > > Hint: we have _real_ locking primitives in the kernel. > > This part certainly. > > The way the code should work, and the way it has in the past is: > image = xchg(&kexec_image, NULL) > if (!image) > return -EINVAL; > > Very simple and very obvious and very easy to get right, and it has > been that way for years. >
Hi Eric, Are there any issues with usage of test_and_set_bit() or usage of spinlock primitives? Thanks Vivek --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] kexec jump: fix compiling warning on xchg(&kexec_l ...
, Huang Ying
, (Wed Aug 13, 2:12 am)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&kex ...
, Andrew Morton
, (Wed Aug 13, 2:27 am)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&kex ...
, Linus Torvalds
, (Wed Aug 13, 9:57 am)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&kex ...
, Linus Torvalds
, (Wed Aug 13, 10:01 am)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&kex ...
, Andrew Morton
, (Wed Aug 13, 10:25 am)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&kex ...
, Ingo Molnar
, (Wed Aug 13, 10:59 am)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&kex ...
, Eric W. Biederman
, (Wed Aug 13, 11:12 am)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&kex ...
, Vivek Goyal
, (Wed Aug 13, 11:31 am)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&kex ...
, Andrew Morton
, (Wed Aug 13, 12:44 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&kex ...
, Linus Torvalds
, (Wed Aug 13, 12:50 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&kex ...
, Andrew Morton
, (Wed Aug 13, 1:07 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&kex ...
, Linus Torvalds
, (Wed Aug 13, 1:13 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&kex ...
, Trond Myklebust
, (Wed Aug 13, 1:15 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&kex ...
, Andrew Morton
, (Wed Aug 13, 1:25 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&kex ...
, Linus Torvalds
, (Wed Aug 13, 1:31 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&kex ...
, Andrew Morton
, (Wed Aug 13, 1:41 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&kex ...
, Vivek Goyal
, (Wed Aug 13, 2:21 pm)
Re: [PATCH] kexec jump: fix compiling warning on xchg(&kex ...
, Linus Torvalds
, (Wed Aug 13, 3:17 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Brandeburg, Jesse
RE: [regression] e1000e broke e1000 (was: Re: [ANNOUNCE] e1000 toe1000e migration ...
Robin Lee Powell
NFS hang + umount -f: better behaviour requested.
Linus Torvalds
Linux 2.6.34-rc4
Nick Piggin
Re: dealing with barriers (was Re: [PATCH] firewire: fw-core: enforce write order ...
Joe Perches
Re: [patch] checkpatch: putting the && or || on the wrong line
git
:
Fredrik Kuivinen
Re: fatal: unable to create '.git/index': File exists
Johannes Sixt
Re: How to pull remote branch with specified commit id?
Henrik Vendelbo
only accessing some git repos: Am I configuring daemon wrong?
Martin Langhoff
Re: CVS -> SVN -> Git
Rene Herman
"git pull . <branch>" versus "git merge <branch>"
linux-netdev
:
Jamie Lokier
Re: POHMELFS high performance network filesystem. Transactions, failover, performa...
Paulius Zaleckas
Re: [RFC] Patch to option HSO driver to the kernel
Timo Teräs
ip xfrm policy semantics
Ron Mercer
[net-next PATCH 2/2] qlge: Version change to v1.00.00.27
Maciej W. Rozycki
Re: [PATCH] flush_work_sync vs. flush_scheduled_work Re: [PATCH] PHYLIB: IRQ event...
openbsd-misc
:
Sevan / Venture37
Re: This is what Linus Torvalds calls openBSD crowd
Siju George
This is what Linus Torvalds calls openBSD crowd
new_guy
Longest Uptime?
Bryan
Re: What does your environment look like?
Bob Beck
Re: observed spamd behavior
git-commits-head
:
Linux Kernel Mailing List
powerpc/fsl_msi: enable msi allocation in all banks
Linux Kernel Mailing List
[ARM] mmp: avengers lite (pxa168) board bring up
Linux Kernel Mailing List
swiotlb: replace architecture-specific swiotlb.h with linux/swiotlb.h
Linux Kernel Mailing List
ASoC: fix registration of the SoC card in the Freescale MPC8610 drivers
Linux Kernel Mailing List
drivers/acpi: use kasprintf
Colocation donated by:
Syndicate