Re: invalidate caches before going into suspend

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Mark Langsdorf
Date: Wednesday, August 13, 2008 - 10:09 am

On Wednesday 13 August 2008, Ingo Molnar wrote:

AMD's diagnostic code for new CPUs was hanging when coming out of suspend,
so I presume it was hitting a bug check for not !CPU_DEAD.  I got the
debug lab reports second hand.  They traced the root cause to dirty data
being preserved in the cache and suggested relocating the wbinvd().



I don't think it's necessary.  I can submit a delta patch later if you
think it's really necessary.


Signed-off-by: Mark Langsdorf <mark.langsdorf@amd.com>

diff -r 1e74a821dd00 arch/x86/kernel/process_32.c
--- a/arch/x86/kernel/process_32.c	Tue Aug 12 12:04:12 2008 -0500
+++ b/arch/x86/kernel/process_32.c	Wed Aug 13 06:40:00 2008 -0500
@@ -95,11 +95,11 @@ static inline void play_dead(void)
 {
 	/* This must be done before dead CPU ack */
 	cpu_exit_clear();
-	wbinvd();
 	mb();
 	/* Ack it */
 	__get_cpu_var(cpu_state) = CPU_DEAD;
 
+	wbinvd();
 	/*
 	 * With physical CPU hotplug, we should halt the cpu
 	 */




--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
invalidate caches before going into suspend, Mark Langsdorf, (Wed Aug 13, 9:41 am)
Re: invalidate caches before going into suspend, Ingo Molnar, (Wed Aug 13, 9:47 am)
Re: invalidate caches before going into suspend, H. Peter Anvin, (Wed Aug 13, 9:53 am)
Re: invalidate caches before going into suspend, Ingo Molnar, (Wed Aug 13, 10:01 am)
Re: invalidate caches before going into suspend, Mark Langsdorf, (Wed Aug 13, 10:09 am)
Re: invalidate caches before going into suspend, Linus Torvalds, (Wed Aug 13, 10:17 am)
Re: invalidate caches before going into suspend, H. Peter Anvin, (Wed Aug 13, 10:28 am)
Re: invalidate caches before going into suspend, Mark Langsdorf, (Wed Aug 13, 10:30 am)
Re: invalidate caches before going into suspend, Ingo Molnar, (Wed Aug 13, 10:35 am)
Re: invalidate caches before going into suspend, H. Peter Anvin, (Wed Aug 13, 10:37 am)
Re: invalidate caches before going into suspend, Ingo Molnar, (Wed Aug 13, 10:38 am)
Re: invalidate caches before going into suspend, Ingo Molnar, (Wed Aug 13, 10:52 am)
Re: [PATCH](retry 2) Re: invalidate caches before going in ..., Arjan van de Ven, (Wed Aug 13, 11:42 am)
Re: invalidate caches before going into suspend, Andi Kleen, (Wed Aug 13, 12:39 pm)