On Wednesday 13 August 2008, Ingo Molnar wrote:AMD's diagnostic code for new CPUs was hanging when coming out of suspend, so I presume it was hitting a bug check for not !CPU_DEAD. I got the debug lab reports second hand. They traced the root cause to dirty data being preserved in the cache and suggested relocating the wbinvd(). I don't think it's necessary. I can submit a delta patch later if you think it's really necessary. Signed-off-by: Mark Langsdorf <mark.langsdorf@amd.com> diff -r 1e74a821dd00 arch/x86/kernel/process_32.c --- a/arch/x86/kernel/process_32.c Tue Aug 12 12:04:12 2008 -0500 +++ b/arch/x86/kernel/process_32.c Wed Aug 13 06:40:00 2008 -0500 @@ -95,11 +95,11 @@ static inline void play_dead(void) { /* This must be done before dead CPU ack */ cpu_exit_clear(); - wbinvd(); mb(); /* Ack it */ __get_cpu_var(cpu_state) = CPU_DEAD; + wbinvd(); /* * With physical CPU hotplug, we should halt the cpu */ --
| Artem Bityutskiy | [PATCH 10/44 take 2] [UBI] debug unit implementation |
| Greg Kroah-Hartman | [PATCH 004/196] Chinese: add translation of SubmittingPatches |
| Trent Piepho | [PATCH] [POWERPC] Improve (in|out)_beXX() asm code |
| Dave Young | Re: Linux v2.6.24-rc1 |
git: | |
| Gerrit Renker | [PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side) |
| Linus Torvalds | Re: [GIT]: Networking |
| David Miller | Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| Natalie Protasevich | [BUG] New Kernel Bugs |
