Re: [PATCH] [WATCHDOG] mpc8xxx_wdt: fix modular build

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Anton Vorontsov <avorontsov@...>
Cc: Dave Jones <davej@...>, Wim Van Sebroeck <wim@...>, Linus Torvalds <torvalds@...>, Andrew Morton <akpm@...>, LKML <linux-kernel@...>, Alan Cox <alan@...>
Date: Wednesday, August 13, 2008 - 10:31 am

On Wed, Aug 13, 2008 at 04:23:41PM +0400, Anton Vorontsov wrote:

In mpc8xxx_wdt_probe()?

Isn't mpc8xxx_wdt_init() the correct place?


Your #ifdef is correct, but "#ifdef MODULE" would express this better.


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[WATCHDOG] v2.6.27-rc patches, Wim Van Sebroeck, (Wed Aug 6, 4:29 pm)
Re: [WATCHDOG] v2.6.27-rc patches, Dave Jones, (Tue Aug 12, 11:10 pm)
[PATCH v2] [WATCHDOG] mpc8xxx_wdt: fix modular build, Anton Vorontsov, (Wed Aug 13, 2:34 pm)
[PATCH] [WATCHDOG] mpc8xxx_wdt: fix modular build, Anton Vorontsov, (Wed Aug 13, 8:23 am)
Re: [PATCH] [WATCHDOG] mpc8xxx_wdt: fix modular build, Adrian Bunk, (Wed Aug 13, 10:31 am)
Re: [PATCH] [WATCHDOG] mpc8xxx_wdt: fix modular build, Anton Vorontsov, (Wed Aug 13, 1:21 pm)
Re: [WATCHDOG] v2.6.27-rc patches, Florian Fainelli, (Thu Aug 7, 4:38 am)
Re: [WATCHDOG] v2.6.27-rc patches, Wim Van Sebroeck, (Thu Aug 7, 6:24 am)
Re: [WATCHDOG] v2.6.27-rc patches, Martin Michlmayr, (Thu Aug 7, 3:03 am)
Re: [WATCHDOG] v2.6.27-rc patches, Ben Dooks, (Thu Aug 7, 5:32 am)
Re: [WATCHDOG] v2.6.27-rc patches, Wim Van Sebroeck, (Thu Aug 7, 6:21 am)