Home » Mailing list archives » linux-kernel » 2008 » August » 13

Re: No, really, stop trying to delete slab until you've finished making slub perform as well

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Christoph Lameter <cl@...>
To: KOSAKI Motohiro <kosaki.motohiro@...>
Cc: KOSAKI Motohiro <m-kosaki@...>, Matthew Wilcox <matthew@...>, Pekka Enberg <penberg@...>, <akpm@...>, <linux-kernel@...>, <linux-fsdevel@...>, Mel Gorman <mel@...>, <andi@...>, Rik van Riel <riel@...>
Subject: Re: No, really, stop trying to delete slab until you've finished making slub perform as well
Date: Wednesday, August 13, 2008 - 9:10 am

KOSAKI Motohiro wrote:



Unreclaimable grew very big.



Argh. Most slabs contain a single object. Probably due to the conflict resolution.



And a similar but not so severe issue here.

The obvious fix is to avoid allocating another slab on conflict but how will
this impact performance?


Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c	2008-08-13 08:06:00.000000000 -0500
+++ linux-2.6/mm/slub.c	2008-08-13 08:07:59.000000000 -0500
@@ -1253,13 +1253,11 @@
 static inline int lock_and_freeze_slab(struct kmem_cache_node *n,
 							struct page *page)
 {
-	if (slab_trylock(page)) {
-		list_del(&page->lru);
-		n->nr_partial--;
-		__SetPageSlubFrozen(page);
-		return 1;
-	}
-	return 0;
+	slab_lock(page);
+	list_del(&page->lru);
+	n->nr_partial--;
+	__SetPageSlubFrozen(page);
+	return 1;
 }

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 00/19] Slab Fragmentation Reduction V13, Christoph Lameter, (Fri May 9, 10:21 pm)
No, really, stop trying to delete slab until you've finished..., Matthew Wilcox, (Sat Aug 2, 9:58 pm)
Re: No, really, stop trying to delete slab until you've fini..., Christoph Lameter, (Mon Aug 4, 9:43 am)
Re: No, really, stop trying to delete slab until you've fini..., KOSAKI Motohiro, (Mon Aug 4, 12:47 pm)
Re: No, really, stop trying to delete slab until you've fini..., Christoph Lameter, (Mon Aug 4, 1:19 pm)
Re: No, really, stop trying to delete slab until you've fini..., Christoph Lameter, (Mon Aug 4, 1:13 pm)
Re: No, really, stop trying to delete slab until you've fini..., KOSAKI Motohiro, (Tue Aug 5, 8:06 am)
Re: No, really, stop trying to delete slab until you've fini..., Christoph Lameter, (Tue Aug 5, 10:59 am)
Re: No, really, stop trying to delete slab until you've fini..., KOSAKI Motohiro, (Wed Aug 13, 6:46 am)
Re: No, really, stop trying to delete slab until you've fini..., Christoph Lameter, (Wed Aug 13, 9:10 am)
Re: No, really, stop trying to delete slab until you've fini..., Pekka Enberg, (Thu Aug 14, 3:15 am)
Re: No, really, stop trying to delete slab until you've fini..., Christoph Lameter, (Thu Aug 14, 11:06 am)
Re: No, really, stop trying to delete slab until you've fini..., Christoph Lameter, (Thu Aug 14, 10:45 am)
Re: No, really, stop trying to delete slab until you've fini..., KOSAKI Motohiro, (Wed Aug 13, 10:14 am)
Re: No, really, stop trying to delete slab until you've fini..., Christoph Lameter, (Wed Aug 13, 10:31 am)
Re: No, really, stop trying to delete slab until you've fini..., KOSAKI Motohiro, (Wed Aug 13, 11:05 am)
Re: No, really, stop trying to delete slab until you've fini..., Christoph Lameter, (Thu Aug 14, 3:44 pm)
Re: No, really, stop trying to delete slab until you've fini..., KOSAKI Motohiro, (Fri Aug 15, 12:44 pm)
Re: No, really, stop trying to delete slab until you've fini..., Christoph Lameter, (Fri Aug 15, 2:24 pm)
Re: No, really, stop trying to delete slab until you've fini..., Christoph Lameter, (Fri Aug 15, 3:42 pm)
Re: No, really, stop trying to delete slab until you've fini..., KOSAKI Motohiro, (Mon Aug 18, 6:08 am)
Re: No, really, stop trying to delete slab until you've fini..., KOSAKI Motohiro, (Mon Aug 18, 6:34 am)
Re: No, really, stop trying to delete slab until you've fini..., Christoph Lameter, (Mon Aug 18, 10:08 am)
Re: No, really, stop trying to delete slab until you've fini..., KOSAKI Motohiro, (Tue Aug 19, 6:34 am)
Re: No, really, stop trying to delete slab until you've fini..., Christoph Lameter, (Tue Aug 19, 9:51 am)
Re: No, really, stop trying to delete slab until you've fini..., KOSAKI Motohiro, (Wed Aug 20, 7:46 am)
Re: No, really, stop trying to delete slab until you've fini..., Pekka Enberg, (Wed Aug 13, 10:16 am)
Re: No, really, stop trying to delete slab until you've fini..., KOSAKI Motohiro, (Wed Aug 6, 8:36 am)
Re: No, really, stop trying to delete slab until you've fini..., Christoph Lameter, (Wed Aug 6, 10:24 am)
Re: No, really, stop trying to delete slab until you've fini..., Pekka Enberg, (Mon Aug 4, 1:20 pm)
Re: No, really, stop trying to delete slab until you've fini..., Rik van Riel, (Mon Aug 4, 11:11 am)
Re: No, really, stop trying to delete slab until you've fini..., Christoph Lameter, (Mon Aug 4, 12:02 pm)
Re: No, really, stop trying to delete slab until you've fini..., Jamie Lokier, (Mon Aug 4, 10:48 am)
Re: No, really, stop trying to delete slab until you've fini..., Jamie Lokier, (Mon Aug 4, 11:21 am)
Re: No, really, stop trying to delete slab until you've fini..., Christoph Lameter, (Mon Aug 4, 12:35 pm)
Re: No, really, stop trying to delete slab until you've fini..., Pekka Enberg, (Sun Aug 3, 5:25 pm)
Re: No, really, stop trying to delete slab until you've fini..., Rene Herman, (Sun Aug 3, 10:37 pm)
Re: No, really, stop trying to delete slab until you've fini..., Pekka Enberg, (Mon Aug 4, 5:22 pm)
Re: No, really, stop trying to delete slab until you've fini..., Christoph Lameter, (Mon Aug 4, 5:41 pm)
Re: No, really, stop trying to delete slab until you've fini..., Rene Herman, (Mon Aug 4, 7:09 pm)