Home » Mailing list archives » linux-kernel » 2008 » August » 13

Re: No, really, stop trying to delete slab until you've finished making slub perform as well

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Christoph Lameter
Subject: Re: No, really, stop trying to delete slab until you've finished making slub perform as well
Date: Wednesday, August 13, 2008 - 6:10 am

KOSAKI Motohiro wrote:



Unreclaimable grew very big.



Argh. Most slabs contain a single object. Probably due to the conflict resolution.



And a similar but not so severe issue here.

The obvious fix is to avoid allocating another slab on conflict but how will
this impact performance?


Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c	2008-08-13 08:06:00.000000000 -0500
+++ linux-2.6/mm/slub.c	2008-08-13 08:07:59.000000000 -0500
@@ -1253,13 +1253,11 @@
 static inline int lock_and_freeze_slab(struct kmem_cache_node *n,
 							struct page *page)
 {
-	if (slab_trylock(page)) {
-		list_del(&page->lru);
-		n->nr_partial--;
-		__SetPageSlubFrozen(page);
-		return 1;
-	}
-	return 0;
+	slab_lock(page);
+	list_del(&page->lru);
+	n->nr_partial--;
+	__SetPageSlubFrozen(page);
+	return 1;
 }

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 00/19] Slab Fragmentation Reduction V13, Christoph Lameter, (Fri May 9, 7:21 pm)
No, really, stop trying to delete slab until you've finish ..., Matthew Wilcox, (Sat Aug 2, 6:58 pm)
Re: No, really, stop trying to delete slab until you've fi ..., Pekka Enberg, (Sun Aug 3, 2:25 pm)
Re: No, really, stop trying to delete slab until you've fi ..., Rene Herman, (Sun Aug 3, 7:37 pm)
Re: No, really, stop trying to delete slab until you've fi ..., Christoph Lameter, (Mon Aug 4, 6:43 am)
Re: No, really, stop trying to delete slab until you've fi ..., Jamie Lokier, (Mon Aug 4, 7:48 am)
Re: No, really, stop trying to delete slab until you've fi ..., Rik van Riel, (Mon Aug 4, 8:11 am)
Re: No, really, stop trying to delete slab until you've fi ..., Jamie Lokier, (Mon Aug 4, 8:21 am)
Re: No, really, stop trying to delete slab until you've fi ..., Christoph Lameter, (Mon Aug 4, 9:02 am)
Re: No, really, stop trying to delete slab until you've fi ..., Christoph Lameter, (Mon Aug 4, 9:35 am)
Re: No, really, stop trying to delete slab until you've fi ..., KOSAKI Motohiro, (Mon Aug 4, 9:47 am)
Re: No, really, stop trying to delete slab until you've fi ..., Christoph Lameter, (Mon Aug 4, 10:13 am)
Re: No, really, stop trying to delete slab until you've fi ..., Christoph Lameter, (Mon Aug 4, 10:19 am)
Re: No, really, stop trying to delete slab until you've fi ..., Pekka Enberg, (Mon Aug 4, 10:20 am)
Re: No, really, stop trying to delete slab until you've fi ..., Pekka Enberg, (Mon Aug 4, 2:22 pm)
Re: No, really, stop trying to delete slab until you've fi ..., Christoph Lameter, (Mon Aug 4, 2:41 pm)
Re: No, really, stop trying to delete slab until you've fi ..., Rene Herman, (Mon Aug 4, 4:09 pm)
Re: No, really, stop trying to delete slab until you've fi ..., KOSAKI Motohiro, (Tue Aug 5, 5:06 am)
Re: No, really, stop trying to delete slab until you've fi ..., Christoph Lameter, (Tue Aug 5, 7:59 am)
Re: No, really, stop trying to delete slab until you've fi ..., KOSAKI Motohiro, (Wed Aug 6, 5:36 am)
Re: No, really, stop trying to delete slab until you've fi ..., Christoph Lameter, (Wed Aug 6, 7:24 am)
Re: No, really, stop trying to delete slab until you've fi ..., KOSAKI Motohiro, (Wed Aug 13, 3:46 am)
Re: No, really, stop trying to delete slab until you've fi ..., Christoph Lameter, (Wed Aug 13, 6:10 am)
Re: No, really, stop trying to delete slab until you've fi ..., KOSAKI Motohiro, (Wed Aug 13, 7:14 am)
Re: No, really, stop trying to delete slab until you've fi ..., Pekka Enberg, (Wed Aug 13, 7:16 am)
Re: No, really, stop trying to delete slab until you've fi ..., Christoph Lameter, (Wed Aug 13, 7:31 am)
Re: No, really, stop trying to delete slab until you've fi ..., KOSAKI Motohiro, (Wed Aug 13, 8:05 am)
Re: No, really, stop trying to delete slab until you've fi ..., Pekka Enberg, (Thu Aug 14, 12:15 am)
Re: No, really, stop trying to delete slab until you've fi ..., Christoph Lameter, (Thu Aug 14, 7:45 am)
Re: No, really, stop trying to delete slab until you've fi ..., Christoph Lameter, (Thu Aug 14, 8:06 am)
Re: No, really, stop trying to delete slab until you've fi ..., Christoph Lameter, (Thu Aug 14, 12:44 pm)
Re: No, really, stop trying to delete slab until you've fi ..., KOSAKI Motohiro, (Fri Aug 15, 9:44 am)
Re: No, really, stop trying to delete slab until you've fi ..., Christoph Lameter, (Fri Aug 15, 11:24 am)
Re: No, really, stop trying to delete slab until you've fi ..., Christoph Lameter, (Fri Aug 15, 12:42 pm)
Re: No, really, stop trying to delete slab until you've fi ..., KOSAKI Motohiro, (Mon Aug 18, 3:08 am)
Re: No, really, stop trying to delete slab until you've fi ..., KOSAKI Motohiro, (Mon Aug 18, 3:34 am)
Re: No, really, stop trying to delete slab until you've fi ..., Christoph Lameter, (Mon Aug 18, 7:08 am)
Re: No, really, stop trying to delete slab until you've fi ..., KOSAKI Motohiro, (Tue Aug 19, 3:34 am)
Re: No, really, stop trying to delete slab until you've fi ..., Christoph Lameter, (Tue Aug 19, 6:51 am)
Re: No, really, stop trying to delete slab until you've fi ..., KOSAKI Motohiro, (Wed Aug 20, 4:46 am)