Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or other GPEs) on Asus EeePC

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>
Cc: Alexey Starikovskiy <astarikovskiy@...>, <linux-acpi@...>, <linux-kernel@...>, <hmh@...>, Maximilian Engelhardt <maxi@...>, <linux-stable@...>
Date: Wednesday, August 13, 2008 - 6:21 am

Andrew Morton wrote:
That's correct.  I think this specific patch should go in 2.6.27 and
2.6.26-stable.  No objections have been raised so far.

I still need this patch to make my brightness and volume control keys
usable in 2.6.27-rc3.  (They auto-repeat fast enough to trigger the
bug).  This is true even after applying the latest patches from bug
10919 (#25 + #27).

I think the 10919 fix makes it harder to reproduce, but it definitely
still happens.  I guess this is because the polling-driven EC
transactions add 1ms delays between each byte.  The slower timings leave
a window where the buggy behaviour of my EC can make a difference.  (It
has been seen to clear the "pending event" bit after a single event is
read, despite having more events pending).

There are more serious consequences of this bug.  After a while it can
confuse the EC enough to cause lockups or reboots during boot, or after
pressing a single hotkey.  This bad state is preserved over reboots,
even into known good kernels.  Fortunately the badness clears when power
is removed for a long enough period.  For a while I was worried that
something had physically burnt out.

Thanks
Alan
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Alexey Starikovskiy, (Thu Jul 17, 10:35 am)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Alexey Starikovskiy, (Thu Jul 17, 12:45 pm)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Alexey Starikovskiy, (Thu Jul 17, 2:59 pm)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Alan Jenkins, (Wed Aug 13, 6:21 am)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Maximilian Engelhardt, (Wed Aug 13, 9:36 am)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Alexey Starikovskiy, (Thu Jul 17, 7:49 am)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Henrique de Moraes Holschuh..., (Thu Jul 17, 8:13 am)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Alexey Starikovskiy, (Thu Jul 17, 8:30 am)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Henrique de Moraes Holschuh..., (Thu Jul 17, 12:26 pm)
Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or oth..., Henrique de Moraes Holschuh..., (Thu Jul 17, 2:50 pm)
[PATCH 0/3] acpi: GPE fixes, Alan Jenkins, (Sat Jul 19, 7:37 am)
Re: [PATCH 0/3] acpi: GPE fixes, Vegard Nossum, (Sat Jul 19, 10:07 am)