Home » Mailing list archives » linux-kernel » 2008 » August » 13

[PATCH] vmscan: set try_to_release_page's gfp_mask to 0

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Hisashi Hifumi <hifumi.hisashi@...>
To: <akpm@...>
Cc: <linux-mm@...>, <linux-kernel@...>, <linux-ext4@...>
Subject: [PATCH] vmscan: set try_to_release_page's gfp_mask to 0
Date: Tuesday, August 12, 2008 - 10:21 pm

Hi.

shrink_page_list passes gfp_mask to try_to_release_page.
When shrink_page_list is called from kswapd or buddy system, gfp_mask is set
and (gfp_mask & __GFP_WAIT) and (gfp_mask & __GFP_FS) check is positive.
releasepage of jbd/jbd2(ext3/4, ocfs2) and XFS use this parameter. 
If try_to_free_page fails due to bh busy in jbd/jbd2, jbd/jbd2 lets a thread wait for 
committing transaction. I think this has big performance impacts for vmscan.
So I modified shrink_page_list not to pass gfp_mask to try_to_release_page
in ordered to improve vmscan performance.

Thanks.

Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>

diff -Nrup linux-2.6.27-rc2.org/mm/vmscan.c linux-2.6.27-rc2.vmscan/mm/vmscan.c
--- linux-2.6.27-rc2.org/mm/vmscan.c	2008-08-11 14:33:24.000000000 +0900
+++ linux-2.6.27-rc2.vmscan/mm/vmscan.c	2008-08-12 18:57:05.000000000 +0900
@@ -614,7 +614,7 @@ static unsigned long shrink_page_list(st
 		* Otherwise, leave the page on the LRU so it is swappable.
 		*/
 		if (PagePrivate(page)) {
-			if (!try_to_release_page(page, sc->gfp_mask))
+			if (!try_to_release_page(page, 0))
 				goto activate_locked;
 			if (!mapping && page_count(page) == 1) {
 				unlock_page(page);

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] vmscan: set try_to_release_page's gfp_mask to 0, Hisashi Hifumi, (Tue Aug 12, 10:21 pm)
Re: [PATCH] vmscan: set try_to_release_page's gfp_mask to 0, Andrew Morton, (Tue Aug 12, 11:21 pm)
Re: [PATCH] vmscan: set try_to_release_page's gfp_mask to 0, Hisashi Hifumi, (Wed Aug 13, 2:24 am)
Re: [PATCH] vmscan: set try_to_release_page's gfp_mask to 0, Andrew Morton, (Wed Oct 15, 6:36 pm)
Re: [PATCH] vmscan: set try_to_release_page's gfp_mask to 0, Hisashi Hifumi, (Wed Oct 15, 10:44 pm)
Re: [PATCH] vmscan: set try_to_release_page's gfp_mask to 0, Andrew Morton, (Wed Oct 15, 10:54 pm)
Re: [PATCH] vmscan: set try_to_release_page's gfp_mask to 0, Hisashi Hifumi, (Wed Oct 15, 11:06 pm)