Re: [PATCH 2/7] x86: add free_coherent dma_ops callback to GART driver

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: FUJITA Tomonori
Date: Tuesday, August 12, 2008 - 5:45 pm

On Tue, 12 Aug 2008 17:24:12 +0200
Joerg Roedel <joerg.roedel@amd.com> wrote:


It would be better to foil this to the first patch, I think. Any
reasonable reason to add alloc_coherent and free_coherent with two
separate patches?

I think that you can remove map_simple in gart (and please don't
forget to remove map_simple in struct dma_mapping_ops. I think only
GART uses that hook).
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/7] x86 dma_*_coherent rework patchset, Joerg Roedel, (Tue Aug 12, 8:24 am)
[PATCH 6/7] x86: cleanup dma_*_coherent functions, Joerg Roedel, (Tue Aug 12, 8:24 am)
Re: [PATCH 0/7] x86 dma_*_coherent rework patchset, Muli Ben-Yehuda, (Tue Aug 12, 9:06 am)
Re: [PATCH 0/7] x86 dma_*_coherent rework patchset, Joerg Roedel, (Tue Aug 12, 9:49 am)
Re: [PATCH 6/7] x86: cleanup dma_*_coherent functions, FUJITA Tomonori, (Tue Aug 12, 5:45 pm)
Re: [PATCH 2/7] x86: add free_coherent dma_ops callback to ..., FUJITA Tomonori, (Tue Aug 12, 5:45 pm)
Re: [PATCH 0/7] x86 dma_*_coherent rework patchset, FUJITA Tomonori, (Tue Aug 12, 5:51 pm)
Re: [PATCH 6/7] x86: cleanup dma_*_coherent functions, Joerg Roedel, (Wed Aug 13, 5:51 am)