Re: 2.6.27-rc1: critical thermal shutdown on thinkpad x60 (bisected)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Milan Broz
Date: Tuesday, August 12, 2008 - 8:48 am

>>>> yes. maybe some userspace tool controlling frequency is involved, no idea yet.
and this seems to fix it for me:
--

Do not use unsigned int if there is test for negative number...

See drivers/acpi/processor_perflib.c
  static unsigned int ignore_ppc = -1;
...
  if (event == CPUFREQ_START && ignore_ppc <= 0) {
       ignore_ppc = 0;
...

Signed-off-by: Milan Broz <mbroz@redhat.com>
---
 drivers/acpi/processor_perflib.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.26.y/drivers/acpi/processor_perflib.c
===================================================================
--- linux-2.6.26.y.orig/drivers/acpi/processor_perflib.c	2008-08-12 17:20:07.000000000 +0200
+++ linux-2.6.26.y/drivers/acpi/processor_perflib.c	2008-08-12 17:35:53.000000000 +0200
@@ -70,7 +70,7 @@ static DEFINE_MUTEX(performance_mutex);
  *  0 -> cpufreq low level drivers initialized -> consider _PPC values
  *  1 -> ignore _PPC totally -> forced by user through boot param
  */
-static unsigned int ignore_ppc = -1;
+static int ignore_ppc = -1;
 module_param(ignore_ppc, uint, 0644);
 MODULE_PARM_DESC(ignore_ppc, "If the frequency of your machine gets wrongly" \
 		 "limited by BIOS, this should help");


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.27-rc1: critical thermal shutdown on thinkpad x60, Pavel Machek, (Wed Aug 6, 2:02 am)
Re: 2.6.27-rc1: critical thermal shutdown on thinkpad x60, Yves-Alexis Perez, (Thu Aug 7, 7:41 am)
Re: 2.6.27-rc1: critical thermal shutdown on thinkpad x60, Rafael J. Wysocki, (Tue Aug 12, 7:34 am)
Re: 2.6.27-rc1: critical thermal shutdown on thinkpad x60, Matthew Garrett, (Tue Aug 12, 8:32 am)
Re: 2.6.27-rc1: critical thermal shutdown on thinkpad x60 ..., Milan Broz, (Tue Aug 12, 8:48 am)
Re: 2.6.27-rc1 and 2.6.26.1: critical thermal shutdown on ..., Thomas Renninger, (Tue Aug 12, 9:01 am)
Re: 2.6.27-rc1: critical thermal shutdown on thinkpad x60 ..., Dominik Brodowski, (Tue Aug 12, 11:30 am)
Re: 2.6.27-rc1: critical thermal shutdown on thinkpad x60 ..., Rafael J. Wysocki, (Tue Aug 12, 12:56 pm)
Re: 2.6.27-rc1: critical thermal shutdown on thinkpad x60, Rafael J. Wysocki, (Tue Aug 12, 12:57 pm)
Re: 2.6.27-rc1: critical thermal shutdown on thinkpad x60, Henrique de Moraes H ..., (Wed Aug 13, 1:13 pm)
Re: 2.6.27-rc1: critical thermal shutdown on thinkpad x60, Henrique de Moraes H ..., (Wed Aug 13, 1:42 pm)