login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
August
»
12
Re: [PATCH 2/3][reiser4] don't leave loop prematurely
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Edward Shishkin <edward.shishkin@...>
To: Ryan Hope <rmh3093@...>
Cc: LKML <linux-kernel@...>, Reiserfs mailing list <reiserfs-devel@...>, Andrew Morton <akpm@...>
Subject:
Re: [PATCH 2/3][reiser4] don't leave loop prematurely
Date: Tuesday, August 12, 2008 - 8:54 am
Ryan Hope wrote:
quoted text
> This was item #9 on the todo list for reiser4 inclusion in mainline: > > diff --git > a/52d76fde71070a6c4c8c581dd2bfe3c6ffa82ad7:fs/reiser4/page_cache.c > b/7f1ee1bb0c5a2948f5347646795afd088da30eaf:fs/reiser4/page_cache.c > index > edf0911dc8bb61398374ecf4f849aa30753fb274..fe713681b73d2a6c4214f5938f21794573d8607d > 100644 > --- a/52d76fde71070a6c4c8c581dd2bfe3c6ffa82ad7:fs/reiser4/page_cache.c > +++ b/7f1ee1bb0c5a2948f5347646795afd088da30eaf:fs/reiser4/page_cache.c > @@ -658,8 +658,7 @@ truncate_jnodes_range(struct inode *inode, pgoff_t > from, pgoff_t count) > unhash_unformatted_jnode(node); > truncated_jnodes++; > jput(node); > - } else > - break; > + }
No, this is wrong: if (node == NULL), then there is nothing to do in this loop. Edward.
quoted text
> } > if (i != taken || taken == 0) > break; > > > -Ryan >
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH 2/3][reiser4] don't leave loop prematurely
, Ryan Hope
, (Mon Aug 11, 6:38 pm)
Re: [PATCH 2/3][reiser4] don't leave loop prematurely
, Edward Shishkin
, (Tue Aug 12, 8:54 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Benjamin Herrenschmidt
Re: [PATCH] Remove process freezer from suspend to RAM pathway
Daniel Walker
Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]
Greg KH
[GIT PATCH] driver core patches against 2.6.24
Andrew Morton
-mm merge plans for 2.6.23
git
:
linux-netdev
:
David Miller
[GIT]: Networking
Hannes Eder
[PATCH 01/43] drivers/net/at1700.c: fix sparse warning: symbol shadows an earlier ...
Gerrit Renker
[PATCH 16/37] dccp: API to query the current TX/RX CCID
Herbert Xu
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
4 users
and
910 guests
online.
Online users
strcmp
maheshdm
howsellgold
honeyairtuz
Syndicate