[PATCH 01/17] checkpatch: square brackets -- exemption for array slices in braces

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andy Whitcroft
Date: Monday, August 11, 2008 - 1:12 pm

It is wholy reasonable to have square brackets representing array slices
in braces on the same line.  These should be spaced.

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
---
 scripts/checkpatch.pl |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index bc67793..6f821a0 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1493,11 +1493,13 @@ sub process {
 
 # check for spacing round square brackets; allowed:
 #  1. with a type on the left -- int [] a;
-#  2. at the beginning of a line for slice initialisers -- [0..10] = 5,
+#  2. at the beginning of a line for slice initialisers -- [0...10] = 5,
+#  3. inside a curly brace -- = { [0...10] = 5 }
 		while ($line =~ /(.*?\s)\[/g) {
 			my ($where, $prefix) = ($-[1], $1);
 			if ($prefix !~ /$Type\s+$/ &&
-			    ($where != 0 || $prefix !~ /^.\s+$/)) {
+			    ($where != 0 || $prefix !~ /^.\s+$/) &&
+			    $prefix !~ /{\s+$/) {
 				ERROR("space prohibited before open square bracket '['\n" . $herecurr);
 			}
 		}
-- 
1.6.0.rc1.258.g80295

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/17] checkpatch: update to version 0.22, Andy Whitcroft, (Mon Aug 11, 1:12 pm)
[PATCH 01/17] checkpatch: square brackets -- exemption for ..., Andy Whitcroft, (Mon Aug 11, 1:12 pm)
[PATCH 04/17] checkpatch: switch indent allow plain return, Andy Whitcroft, (Mon Aug 11, 1:12 pm)
[PATCH 16/17] checkpatch: perform indent checks on perl, Andy Whitcroft, (Mon Aug 11, 1:13 pm)
[PATCH 17/17] checkpatch: version: 0.22, Andy Whitcroft, (Mon Aug 11, 1:13 pm)
Re: [PATCH 09/17] checkpatch: include/asm checks should be ..., Geert Uytterhoeven, (Wed Oct 8, 6:39 am)