Re: Query: should 'Marvell SATA support' depend on PCI?

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Rafael J. Wysocki

Subject: Re: Query: should 'Marvell SATA support' depend on PCI?

Date: Sunday, August 10, 2008 - 5:26 am

On Sunday, 10 of August 2008, Alan Cox wrote:
quoted text> > > doesn't have 'depends on PCI && EXPERIMENTAL' like other drivers around 
> > > it, this is okay or should it also depend on PCI?
> > 
> > Well, I think so.  It obviously depends on PCI.
> 
> Obviously ? Try looking a bit harder
> 
> /**
>  *      mv_platform_probe - handle a positive probe of an soc Marvell
>  *      host
>  *      @pdev: platform device found
>  *
>  *      LOCKING:
>  *      Inherited from caller.
>  */
> static int mv_platform_probe(struct platform_device *pdev)

Sorry, I didn't notice the '#ifdef CONFIG_PCI' in there.

Rafael
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

Query: should 'Marvell SATA support' depend on PCI?, Grant Coady, (Sat Aug 9, 11:47 pm)

Re: Query: should 'Marvell SATA support' depend on PCI?, Alan Cox, (Sun Aug 10, 4:54 am)

Re: Query: should 'Marvell SATA support' depend on PCI?, Rafael J. Wysocki, (Sun Aug 10, 5:08 am)

Re: Query: should 'Marvell SATA support' depend on PCI?, Frans Pop, (Sun Aug 10, 5:24 am)

Re: Query: should 'Marvell SATA support' depend on PCI?, Rafael J. Wysocki, (Sun Aug 10, 5:26 am)


linux-kernel:
Michael Trimarchi	Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch
Miklos Szeredi	[patch 14/15] vfs: more path_permission() conversions
Serge E. Hallyn	Re: [RFC v5][PATCH 7/8] Infrastructure for shared objects
Bernd Schmidt	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Takashi Iwai	[PATCH 2/2] input: Add LED support to Synaptics device
git:
Junio C Hamano	Re: mingw, windows, crlf/lf, and git
Eyvind Bernhardsen	Re: Where has "git ls-remote" reference pattern matching gone?
Shawn O. Pearce	Re: Switching from CVS to GIT
Todd Zullinger	Re: [PATCH 2/2] send-email: rfc2047-quote subject lines with non-ascii characters
Santi Béjar	Re: How to use git-fmt-merge-msg?
linux-netdev:
Ramkrishna Vepa	[net-2.6 PATCH 1/10] Neterion: New driver: Driver help file
Mark Anthony	invitation / inquiry
Ingo Molnar	Re: [PATCH 08/16] dma-debug: add core checking functions
David Miller	Re: [PATCH 1/3] f_phonet: dev_kfree_skb instead of dev_kfree_skb_any in TX callback
Sascha Hauer	[PATCH 03/12] fec: do not typedef struct types
git-commits-head:
Linux Kernel Mailing List	amba: struct device - replace bus_id with dev_name(), dev_set_name()
Linux Kernel Mailing List	MIPS: Yosemite: Convert SMP startup lock to arch spinlock.
Linux Kernel Mailing List	ARM: S5PC100: IRQ and timer
Linux Kernel Mailing List	davinci: edma: clear interrupt status for interrupt enabled channels only
Linux Kernel Mailing List	x86, mm, kprobes: fault.c, simplify notify_page_fault()
openbsd-misc:
Daniel A. Ramaley	Re: [semi-OT] Can anyone recommend an OpenBSD-compatible colour laser printer?
Matthias Kilian	Re: can't get vesa @ 1280x800 or nv
Tobias Ulmer	Re: Problem after upgrade 4.5 to 4.6: ERR M
Philip Guenther	Re: SIGCHLD and libpthread.so
J.C. Roberts	Re: [semi-OT] Can anyone recommend an OpenBSD-compatible colour laser printer?