Home » Mailing list archives » linux-kernel » 2008 » August » 10

Re: [PATCH] sky2: Fix suspend/hibernation/shutdown regression with WOL enabled

Previous thread: [Regression] 2.6.27-rc2-git4: suspend and power off fails on Asus M3A32-MVP by Rafael J. Wysocki on Saturday, August 9, 2008 - 2:21 pm. (6 messages)

Next thread: [PATCH] WATCHDOG: don't auto-grab eurotechwdt. by Rene Herman on Saturday, August 9, 2008 - 2:42 pm. (9 messages)
[view original message]
From: Rafael J. Wysocki
Subject: [PATCH] sky2: Fix suspend/hibernation/shutdown regression with WOL enabled
Date: Saturday, August 9, 2008 - 2:32 pm

sky2: Fix suspend/hibernation/shutdown regression with WOL enabled

On my test box with the Asus M3A32-MVP main board there is a
regression from 2.6.26 related to suspend, hibernation and
shutdown.  Namely, if Wake-on-LAN is enabled with
'ethtool -s eth0 wol g', the box hangs solid during all of these
operations, while executing either sky2_suspend(), or
sky2_shutdown().  This patch fixes it for me.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 drivers/net/sky2.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux-2.6/drivers/net/sky2.c
===================================================================
--- linux-2.6.orig/drivers/net/sky2.c
+++ linux-2.6/drivers/net/sky2.c
@@ -665,7 +665,8 @@ static void sky2_phy_power_down(struct s
 		    GM_GPCR_FL_PASS | GM_GPCR_SPEED_100 | GM_GPCR_AU_ALL_DIS);
 
 	if (hw->chip_id != CHIP_ID_YUKON_EC) {
-		if (hw->chip_id == CHIP_ID_YUKON_EC_U) {
+		if (hw->chip_id == CHIP_ID_YUKON_EC_U
+		    && hw->chip_rev != CHIP_REV_YU_EC_U_B0) {
 			ctrl = gm_phy_read(hw, port, PHY_MARV_PHY_CTRL);
 
 			/* enable Power Down */
--


[ message continues ]
[view original message]
From: Stephen Hemminger
Subject: Re: [PATCH] sky2: Fix suspend/hibernation/shutdown regression with WOL enabled
Date: Saturday, August 9, 2008 - 11:57 pm

On Sat, 9 Aug 2008 23:32:28 +0200

The problem is not unique to your chip version, so patching out
the power down is not the correct solution.
--


[ message continues ]
[view original message]
From: Rafael J. Wysocki
Subject: Re: [PATCH] sky2: Fix suspend/hibernation/shutdown regression with WOL enabled
Date: Sunday, August 10, 2008 - 5:14 am

Sure.
--


[ message continues ]
[view original message]
From: Rafael J. Wysocki
Subject: [PATCH] sky2: Fix suspend/hibernation/shutdown regression with WOL enabled (rev. 2)
Date: Sunday, August 10, 2008 - 10:30 am

But, shouldn't we switch to page 2 before selecting PHY_MARV_PHY_CTRL?  Things
work correctly if this is done (patch below).

Thanks,
Rafael


---
On my test box with the Asus M3A32-MVP main board there is a
regression from 2.6.26 related to suspend, hibernation and
shutdown.  Namely, if Wake-on-LAN is enabled with
'ethtool -s eth0 wol g', the box hangs solid during all of these
operations, while executing either sky2_suspend(), or
sky2_shutdown().  This patch fixes it for me.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 drivers/net/sky2.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Index: linux-2.6/drivers/net/sky2.c
===================================================================
--- linux-2.6.orig/drivers/net/sky2.c
+++ linux-2.6/drivers/net/sky2.c
@@ -666,11 +666,16 @@ static void sky2_phy_power_down(struct s
 
 	if (hw->chip_id != CHIP_ID_YUKON_EC) {
 		if (hw->chip_id == CHIP_ID_YUKON_EC_U) {
-			ctrl = gm_phy_read(hw, port, PHY_MARV_PHY_CTRL);
+			/* select page 2 to access MAC control register */
+			gm_phy_write(hw, port, PHY_MARV_EXT_ADR, 2);
 
+			ctrl = gm_phy_read(hw, port, PHY_MARV_PHY_CTRL);
 			/* enable Power Down */
 			ctrl |= PHY_M_PC_POW_D_ENA;
 			gm_phy_write(hw, port, PHY_MARV_PHY_CTRL, ctrl);
+
+			/* set page register back to 0 */
+			gm_phy_write(hw, port, PHY_MARV_EXT_ADR, 0);
 		}
 
 		/* set IEEE compatible Power Down Mode (dev. #4.99) */
--


[ message continues ]
[view original message]
From: Stephen Hemminger
Subject: Re: [PATCH] sky2: Fix suspend/hibernation/shutdown regression with WOL enabled (rev. 2)
Date: Monday, August 11, 2008 - 7:57 pm

On Sun, 10 Aug 2008 19:30:28 +0200

Yes, that's better.

Acked-by: Stephen Hemminger <shemminger@vyatta.com>
--


[ message continues ]
[view original message]
From: Jeff Garzik
Subject: Re: [PATCH] sky2: Fix suspend/hibernation/shutdown regression with WOL enabled (rev. 2)
Date: Thursday, August 14, 2008 - 1:29 am

applied


--


[ message continues ]
Previous thread: [Regression] 2.6.27-rc2-git4: suspend and power off fails on Asus M3A32-MVP by Rafael J. Wysocki on Saturday, August 9, 2008 - 2:21 pm. (6 messages)

Next thread: [PATCH] WATCHDOG: don't auto-grab eurotechwdt. by Rene Herman on Saturday, August 9, 2008 - 2:42 pm. (9 messages)