login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
August
»
10
Re: [PATCH] sky2: Fix suspend/hibernation/shutdown regression with WOL enabled
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Rafael J. Wysocki
Subject:
Re: [PATCH] sky2: Fix suspend/hibernation/shutdown regression with WOL enabled
Date: Sunday, August 10, 2008 - 5:14 am
On Sunday, 10 of August 2008, Stephen Hemminger wrote:
quoted text
> On Sat, 9 Aug 2008 23:32:28 +0200 > "Rafael J. Wysocki" <rjw@sisk.pl> wrote: > > > sky2: Fix suspend/hibernation/shutdown regression with WOL enabled > > > > On my test box with the Asus M3A32-MVP main board there is a > > regression from 2.6.26 related to suspend, hibernation and > > shutdown. Namely, if Wake-on-LAN is enabled with > > 'ethtool -s eth0 wol g', the box hangs solid during all of these > > operations, while executing either sky2_suspend(), or > > sky2_shutdown(). This patch fixes it for me. > > > > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> > > --- > > drivers/net/sky2.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > Index: linux-2.6/drivers/net/sky2.c > > =================================================================== > > --- linux-2.6.orig/drivers/net/sky2.c > > +++ linux-2.6/drivers/net/sky2.c > > @@ -665,7 +665,8 @@ static void sky2_phy_power_down(struct s > > GM_GPCR_FL_PASS | GM_GPCR_SPEED_100 | GM_GPCR_AU_ALL_DIS); > > > > if (hw->chip_id != CHIP_ID_YUKON_EC) { > > - if (hw->chip_id == CHIP_ID_YUKON_EC_U) { > > + if (hw->chip_id == CHIP_ID_YUKON_EC_U > > + && hw->chip_rev != CHIP_REV_YU_EC_U_B0) { > > ctrl = gm_phy_read(hw, port, PHY_MARV_PHY_CTRL); > > > > /* enable Power Down */ > > The problem is not unique to your chip version,
Well, that's the part I wasn't sure of.
quoted text
> so patching out the power down is not the correct solution.
Sure. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] sky2: Fix suspend/hibernation/shutdown regression ...
, Rafael J. Wysocki
, (Sat Aug 9, 2:32 pm)
Re: [PATCH] sky2: Fix suspend/hibernation/shutdown regress ...
, Stephen Hemminger
, (Sat Aug 9, 11:57 pm)
Re: [PATCH] sky2: Fix suspend/hibernation/shutdown regress ...
, Rafael J. Wysocki
, (Sun Aug 10, 5:14 am)
[PATCH] sky2: Fix suspend/hibernation/shutdown regression ...
, Rafael J. Wysocki
, (Sun Aug 10, 10:30 am)
Re: [PATCH] sky2: Fix suspend/hibernation/shutdown regress ...
, Stephen Hemminger
, (Mon Aug 11, 7:57 pm)
Re: [PATCH] sky2: Fix suspend/hibernation/shutdown regress ...
, Jeff Garzik
, (Thu Aug 14, 1:29 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Stefan Richter
Re: sata & scsi suggestion for make menuconfig
Rafael J. Wysocki
[Bug #11409] build issue #564 for v2.6.27-rc4 : undefined reference to `NS8390p_in...
Greg Kroah-Hartman
[PATCH 20/36] Driver core: Call device_pm_add() after bus_add_device() in device_a...
Marcin Slusarz
Re: [PATCH] ufs: [bl]e*_add_cpu conversion
Andrew Morton
2.6.23-rc6-mm1
git
:
Junio C Hamano
Re: git-svnimport
Anuj Gakhar
Git Architecture Question
Johannes Schindelin
Re: [PATCH] Fix approxidate("never") to always return 0
A Large Angry SCM
Re: [RFC] origin link for cherry-pick and revert
Petr Baudis
Re: [RFC] origin link for cherry-pick and revert, and more about porcelain-level m...
git-commits-head
:
Linux Kernel Mailing List
ath9k_htc: Allocate URBs properly
Linux Kernel Mailing List
[ARM] dma: use new dmabounce_sync_for_xxx() for dma_sync_single_xxx()
Linux Kernel Mailing List
MIPS: Cavium: Remove unused watchdog code.
Linux Kernel Mailing List
V4L/DVB (8976): af9015: Add USB ID for AVerMedia A309
Linux Kernel Mailing List
ARM: 5670/1: bcmring: add default configuration for bcmring arch
linux-netdev
:
Gerrit Renker
v2 [PATCH 1/4] dccp: Limit feature negotiation to connection setup phase
Daniel Lezcano
getsockopt(TCP_DEFER_ACCEPT) value change
David Miller
Re: 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a seco...
Ingo Molnar
Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference
Gerrit Renker
[PATCH 37/37] dccp: Debugging functions for feature negotiation
openbsd-misc
:
Jason Dixon
Re: any web management gui for pf ?
Christophe Rioux
Implementation example of snmp
Nick Holland
Re: booting openbsd on eee without cd-rom
Bryan Irvine
Re: OpenBSD 4.7 Released, May 19 2010
Marco Peereboom
Re: Singularity OS
Colocation donated by:
Syndicate