[PATCH 42/43] x86_64: make /proc/interrupts works with dyn irq_desc

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Yinghai Lu
Date: Sunday, August 10, 2008 - 12:36 am

loop with irq_desc list

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
---
 arch/x86/kernel/irq_64.c |   31 ++++++++++++++++++++++++-------
 fs/proc/proc_misc.c      |   28 ++++++++++++++++++++++++----
 2 files changed, 48 insertions(+), 11 deletions(-)

diff --git a/arch/x86/kernel/irq_64.c b/arch/x86/kernel/irq_64.c
index 4ebf884..f7dabe8 100644
--- a/arch/x86/kernel/irq_64.c
+++ b/arch/x86/kernel/irq_64.c
@@ -70,9 +70,27 @@ static inline void stack_overflow_check(struct pt_regs *regs)
 
 int show_interrupts(struct seq_file *p, void *v)
 {
-	int i = *(loff_t *) v, j;
+	int i, j;
 	struct irqaction * action;
 	unsigned long flags;
+	unsigned int entries;
+	struct irq_desc *desc;
+	int tail = 0;
+
+#ifdef CONFIG_HAVE_SPARSE_IRQ
+	desc = (struct irq_desc *)v;
+	entries = -1U;
+	i = desc->irq;
+	if (!desc->next)
+		tail = 1;
+#else
+	entries = nr_irqs - 1;
+	i = *(loff_t *) v;
+	if (i == nr_irqs)
+		tail = 1;
+	else
+		desc = irq_desc(i);
+#endif
 
 	if (i == 0) {
 		seq_printf(p, "           ");
@@ -81,12 +99,8 @@ int show_interrupts(struct seq_file *p, void *v)
 		seq_putc(p, '\n');
 	}
 
-	if (i < nr_irqs) {
+	if (i <= entries) {
 		unsigned any_count = 0;
-		struct irq_desc *desc = irq_desc(i);
-
-		if (!desc)
-			return 0;
 
 		spin_lock_irqsave(&desc->lock, flags);
 #ifndef CONFIG_SMP
@@ -116,7 +130,9 @@ int show_interrupts(struct seq_file *p, void *v)
 		seq_putc(p, '\n');
 skip:
 		spin_unlock_irqrestore(&desc->lock, flags);
-	} else if (i == nr_irqs) {
+	}
+
+	if (tail) {
 		seq_printf(p, "NMI: ");
 		for_each_online_cpu(j)
 			seq_printf(p, "%10u ", cpu_pda(j)->__nmi_count);
@@ -155,6 +171,7 @@ skip:
 		seq_printf(p, "  Spurious interrupts\n");
 		seq_printf(p, "ERR: %10u\n", atomic_read(&irq_err_count));
 	}
+
 	return 0;
 }
 
diff --git a/fs/proc/proc_misc.c b/fs/proc/proc_misc.c
index 1131f07..4cf6fdf 100644
--- a/fs/proc/proc_misc.c
+++ b/fs/proc/proc_misc.c
@@ -638,15 +638,36 @@ static const struct file_operations proc_stat_operations = {
  */
 static void *int_seq_start(struct seq_file *f, loff_t *pos)
 {
+#ifdef CONFIG_HAVE_SPARSE_IRQ
+	struct irq_desc *desc;
+	int irq;
+	int count = *pos;
+
+	for_each_irq_desc(irq, desc) {
+		if (count-- == 0)
+			return desc;
+	}
+
+	return NULL;
+#else
 	return (*pos <= nr_irqs) ? pos : NULL;
+#endif
 }
 
+
 static void *int_seq_next(struct seq_file *f, void *v, loff_t *pos)
 {
+#ifdef CONFIG_HAVE_SPARSE_IRQ
+	struct irq_desc *desc;
+
+	desc = ((struct irq_desc *)v)->next;
 	(*pos)++;
-	if (*pos > nr_irqs)
-		return NULL;
-	return pos;
+
+	return desc;
+#else
+	(*pos)++;
+	return (*pos <= nr_irqs) ? pos : NULL;
+#endif
 }
 
 static void int_seq_stop(struct seq_file *f, void *v)
@@ -654,7 +675,6 @@ static void int_seq_stop(struct seq_file *f, void *v)
 	/* Nothing to do */
 }
 
-
 static const struct seq_operations int_seq_ops = {
 	.start = int_seq_start,
 	.next  = int_seq_next,
-- 
1.5.4.5

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/43] dyn_array/nr_irqs/sparse_irq support v7, Yinghai Lu, (Sun Aug 10, 12:35 am)
[PATCH 02/43] 8250: Remove NR_IRQ usage, Yinghai Lu, (Sun Aug 10, 12:35 am)
[PATCH 03/43] x86: add after_bootmem for 32bit, Yinghai Lu, (Sun Aug 10, 12:35 am)
[PATCH 04/43] x86: remove irq_vectors_limits, Yinghai Lu, (Sun Aug 10, 12:35 am)
[PATCH 05/43] add dyn_array support, Yinghai Lu, (Sun Aug 10, 12:35 am)
[PATCH 06/43] add per_cpu_dyn_array support, Yinghai Lu, (Sun Aug 10, 12:35 am)
[PATCH 07/43] x86: alloc dyn_array all alltogether, Yinghai Lu, (Sun Aug 10, 12:35 am)
[PATCH 08/43] x86: enable dyn_array support, Yinghai Lu, (Sun Aug 10, 12:35 am)
[PATCH 09/43] introduce nr_irqs, Yinghai Lu, (Sun Aug 10, 12:35 am)
[PATCH 10/43] x86: using nr_irqs, Yinghai Lu, (Sun Aug 10, 12:35 am)
[PATCH 11/43] drivers/char to use nr_irqs, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 12/43] drivers/net to use nr_irqs, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 13/43] drivers intr remapping to use nr_irqs, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 14/43] drivers/pcmcia to use nr_irqs, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 15/43] drivers/rtc to use nr_irqs, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 16/43] drivers/scsi to use nr_irqs, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 17/43] drivers/serial to use nr_irqs, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 18/43] drivers proc to use nr_irqs, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 19/43] drivers xen events to use nr_irqs, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 20/43] make irq_timer_state to use dyn_array, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 21/43] make irq2_iommu to use dyn_array, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 22/43] make irq_desc to use dyn_array, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 24/43] x86: use dyn_array in io_apic_xx.c, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 25/43] x86: get mp_irqs from madt, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 26/43] x86: remove nr_irq_vectors, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 28/43] x86: add irq_cfg in io_apic_64.c, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 29/43] x86: put irq_2_pin pointer into irq_cfg, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 32/43] add irq_desc_without_new, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 34/43] replace loop with nr_irqs for proc/stat, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 40/43] seperate irq_descX with irq_descX_free, Yinghai Lu, (Sun Aug 10, 12:36 am)
[PATCH 42/43] x86_64: make /proc/interrupts works with dyn ..., Yinghai Lu, (Sun Aug 10, 12:36 am)