login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
August
»
1
Re: [PATCH 03/10] fs-enet: remove code associated with !CONFIG_PPC_MERGE
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Scott Wood <scottwood@...>
To: Kumar Gala <galak@...>
Cc: <linuxppc-dev@...>, <netdev@...>, <jgarzik@...>, <linux-kernel@...>
Subject:
Re: [PATCH 03/10] fs-enet: remove code associated with !CONFIG_PPC_MERGE
Date: Friday, August 1, 2008 - 2:57 pm
On Fri, Aug 01, 2008 at 11:44:13AM -0500, Kumar Gala wrote:
quoted text
> diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c > index 9a51ec8..e54d003 100644 > --- a/drivers/net/fs_enet/fs_enet-main.c > +++ b/drivers/net/fs_enet/fs_enet-main.c > @@ -669,7 +669,6 @@ static int fs_request_irq(struct net_device *dev, int irq, const char *name, > { > struct fs_enet_private *fep = netdev_priv(dev); > > - (*fep->ops->pre_request_irq)(dev, irq); > return request_irq(irq, irqf, IRQF_SHARED, name, dev); > }
This makes "fep" an unused variable. Eliminate this function entirely, and call request_irq directly from the caller.
quoted text
> > @@ -678,7 +677,6 @@ static void fs_free_irq(struct net_device *dev, int irq) > struct fs_enet_private *fep = netdev_priv(dev); > > free_irq(irq, dev); > - (*fep->ops->post_free_irq)(dev, irq); > }
Likewise. -Scott --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 00/10] powerpc: Remove use of CONFIG_PPC_MERGE
, Kumar Gala
, (Fri Aug 1, 12:44 pm)
Re: [PATCH 00/10] powerpc: Remove use of CONFIG_PPC_MERGE
, Paul Mackerras
, (Fri Aug 1, 7:53 pm)
[PATCH 01/10] powerpc: Remove use of CONFIG_PPC_MERGE
, Kumar Gala
, (Fri Aug 1, 12:44 pm)
Re: [PATCH 01/10] powerpc: Remove use of CONFIG_PPC_MERGE
, Michael Ellerman
, (Fri Aug 1, 10:38 pm)
[PATCH 02/10] usb: remove code associated with !CONFIG_PPC_M...
, Kumar Gala
, (Fri Aug 1, 12:44 pm)
[PATCH 03/10] fs-enet: remove code associated with !CONFIG_P...
, Kumar Gala
, (Fri Aug 1, 12:44 pm)
Re: [PATCH 03/10] fs-enet: remove code associated with !CONF...
, Scott Wood
, (Fri Aug 1, 2:57 pm)
[PATCH 04/10] netdev: drop CONFIG_PPC_MERGE from Kconfig
, Kumar Gala
, (Fri Aug 1, 12:44 pm)
[PATCH 05/10] rtc: use CONFIG_PPC instead of CONFIG_PPC_MERGE
, Kumar Gala
, (Fri Aug 1, 12:44 pm)
[PATCH 06/10] serial/mpc52xx_uart: remove code associated wi...
, Kumar Gala
, (Fri Aug 1, 12:44 pm)
[PATCH 07/10] mpc52xx_psc_spi: remove code associated with !...
, Kumar Gala
, (Fri Aug 1, 12:44 pm)
[PATCH 08/10] powerpc: convert CONFIG_PPC_MERGE to CONFIG_PP...
, Kumar Gala
, (Fri Aug 1, 12:44 pm)
[PATCH 09/10] pata_sil680: convert CONFIG_PPC_MERGE to CONFI...
, Kumar Gala
, (Fri Aug 1, 12:44 pm)
[PATCH 10/10] mtd: remove code associated with !CONFIG_PPC_M...
, Kumar Gala
, (Fri Aug 1, 12:44 pm)
Re: [PATCH 10/10] mtd: remove code associated with !CONFIG_P...
, Josh Boyer
, (Fri Aug 1, 1:49 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
FUJITA Tomonori
Re: Integration of SCST in the mainstream Linux kernel
David Newall
Re: Slow DOWN, please!!!
Dave Hansen
Re: [RFC/PATCH] Documentation of kernel messages
Greg Kroah-Hartman
[PATCH 005/196] Chinese: add translation of SubmittingDrivers
git
:
Sander
'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1)
openbsd-misc
:
linux-netdev
:
David Miller
Re: [GIT]: Networking
Gerrit Renker
[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
Jarek Poplawski
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Evgeniy Polyakov
Re: [BUG] New Kernel Bugs
Colocation donated by:
Who's online
There are currently
0 users
and
468 guests
online.
Syndicate