[PATCH 08/16] serial: change remove NR_IRQS in 8250.c v2

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>, Thomas Gleixner <tglx@...>, hpa <hpa@...>, Eric Biederman <ebiederm@...>, Dhaval Giani <dhaval@...>, Mike Travis <travis@...>, Andrew Morton <akpm@...>
Cc: <linux-kernel@...>, Yinghai Lu <yhlu.kernel@...>
Date: Friday, August 1, 2008 - 5:37 am

replace
	[PATCH] serial: change irq_lists to use dyn_array
use small array with index to handle irq locking for serial port
hope 32 slot is enough

v2: according to Eric, move irq_no into irq_info, and not clean irq_no

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>

---
 drivers/serial/8250.c |   45 +++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 41 insertions(+), 4 deletions(-)

Index: linux-2.6/drivers/serial/8250.c
===================================================================
--- linux-2.6.orig/drivers/serial/8250.c
+++ linux-2.6/drivers/serial/8250.c
@@ -147,9 +147,39 @@ struct uart_8250_port {
 struct irq_info {
 	spinlock_t		lock;
 	struct list_head	*head;
+	int irq_no;
 };
 
-static struct irq_info irq_lists[NR_IRQS];
+#define NR_IRQ_INFO	32
+
+static struct irq_info irq_lists[NR_IRQ_INFO] = {
+	[0 ... NR_IRQ_INFO-1] = {
+		.irq_no = -1,
+	}
+};
+
+static struct irq_info *get_irq_info(int irq, int with_free)
+{
+	int i, first_free = -1;
+
+	for (i = 0; i < NR_IRQ_INFO; i++) {
+		if (irq_lists[i].irq_no == irq)
+			return &irq_lists[i];
+		if (irq_lists[i].irq_no == -1 && first_free == -1)
+			first_free = i;
+	}
+	if (!with_free)
+		return NULL;
+
+	if (first_free != -1) {
+		irq_lists[first_free].irq_no = irq;
+		return &irq_lists[first_free];
+	}
+
+	WARN_ON("NR_IRQ_INFO too small");
+
+	return NULL;
+}
 
 /*
  * Here we define the default xmit fifo size used for each type of UART.
@@ -1541,9 +1571,12 @@ static void serial_do_unlink(struct irq_
 
 static int serial_link_irq_chain(struct uart_8250_port *up)
 {
-	struct irq_info *i = irq_lists + up->port.irq;
+	struct irq_info *i = get_irq_info(up->port.irq, 1);
 	int ret, irq_flags = up->port.flags & UPF_SHARE_IRQ ? IRQF_SHARED : 0;
 
+	if (!i)
+		return -1;
+
 	spin_lock_irq(&i->lock);
 
 	if (i->head) {
@@ -1567,7 +1600,11 @@ static int serial_link_irq_chain(struct
 
 static void serial_unlink_irq_chain(struct uart_8250_port *up)
 {
-	struct irq_info *i = irq_lists + up->port.irq;
+	int irq_no = up->port.irq;
+	struct irq_info *i = get_irq_info(irq_no, 0);
+
+	if (!i)
+		return;
 
 	BUG_ON(i->head == NULL);
 
@@ -2951,7 +2988,7 @@ static int __init serial8250_init(void)
 		"%d ports, IRQ sharing %sabled\n", nr_uarts,
 		share_irqs ? "en" : "dis");
 
-	for (i = 0; i < nr_irqs; i++)
+	for (i = 0; i < NR_IRQ_INFO; i++)
 		spin_lock_init(&irq_lists[i].lock);
 
 	ret = uart_register_driver(&serial8250_reg);
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/16] dyn_array and nr_irqs support v2, Yinghai Lu, (Fri Aug 1, 5:37 am)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Eric W. Biederman, (Fri Aug 1, 4:46 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Yinghai Lu, (Fri Aug 1, 10:58 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Mike Travis, (Fri Aug 1, 5:47 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Yinghai Lu, (Fri Aug 1, 5:30 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Eric W. Biederman, (Fri Aug 1, 6:38 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Yinghai Lu, (Fri Aug 1, 9:09 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Eric W. Biederman, (Fri Aug 1, 9:41 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Mike Travis, (Mon Aug 4, 8:57 am)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, H. Peter Anvin, (Mon Aug 4, 10:38 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Eric W. Biederman, (Mon Aug 4, 11:40 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, H. Peter Anvin, (Mon Aug 4, 11:48 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Yinghai Lu, (Fri Aug 1, 10:01 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, H. Peter Anvin, (Fri Aug 1, 10:03 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Eric W. Biederman, (Fri Aug 1, 10:39 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, H. Peter Anvin, (Fri Aug 1, 11:28 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Eric W. Biederman, (Sat Aug 2, 12:42 am)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, H. Peter Anvin, (Sat Aug 2, 11:41 am)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Eric W. Biederman, (Sat Aug 2, 4:20 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, H. Peter Anvin, (Fri Aug 1, 9:36 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Yinghai Lu, (Fri Aug 1, 6:10 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Yinghai Lu, (Fri Aug 1, 5:57 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Eric W. Biederman, (Fri Aug 1, 6:45 pm)
[PATCH 01/16] x86: 64bit support more than 256 irq, Yinghai Lu, (Fri Aug 1, 5:37 am)
[PATCH 02/16] x86: introduce nr_irqs for 64bit v3, Yinghai Lu, (Fri Aug 1, 5:37 am)
[PATCH 03/16] add dyn_array support, Yinghai Lu, (Fri Aug 1, 5:37 am)
[PATCH 04/16] make irq_timer_state to use dyn_array, Yinghai Lu, (Fri Aug 1, 5:37 am)
[PATCH 05/16] make irq2_iommu to use dyn_array, Yinghai Lu, (Fri Aug 1, 5:37 am)
[PATCH 06/16] make irq_desc to use dyn_array, Yinghai Lu, (Fri Aug 1, 5:37 am)
[PATCH 07/16] x86: make 64bit support dyn_array, Yinghai Lu, (Fri Aug 1, 5:37 am)
[PATCH 08/16] serial: change remove NR_IRQS in 8250.c v2, Yinghai Lu, (Fri Aug 1, 5:37 am)
[PATCH 09/16] add per_cpu_dyn_array support, Yinghai Lu, (Fri Aug 1, 5:37 am)