[PATCH 01/16] x86: 64bit support more than 256 irq

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>, Thomas Gleixner <tglx@...>, hpa <hpa@...>, Eric Biederman <ebiederm@...>, Dhaval Giani <dhaval@...>, Mike Travis <travis@...>, Andrew Morton <akpm@...>
Cc: <linux-kernel@...>, Yinghai Lu <yhlu.kernel@...>
Date: Friday, August 1, 2008 - 5:37 am

Dhaval Giani got:
kernel BUG at arch/x86/kernel/io_apic_64.c:357!
invalid opcode: 0000 [1] SMP
CPU 24
...

his system (x3950) has 8 ioapic, irq > 256

caused by
        commit 9b7dc567d03d74a1fbae84e88949b6a60d922d82
        Author: Thomas Gleixner <tglx@linutronix.de>
        Date:   Fri May 2 20:10:09 2008 +0200

           x86: unify interrupt vector defines

           The interrupt vector defines are copied 4 times around with minimal
           differences. Move them all into asm-x86/irq_vectors.h

because 64bit allow same vector for different cpu to serve different irq

need to create that array dynamically later

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
Tested-by: Dhaval Giani <dhaval@linux.vnet.ibm.com>

---
 include/asm-x86/irq_vectors.h |   14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)
Index: linux-2.6/include/asm-x86/irq_vectors.h
===================================================================
--- linux-2.6.orig/include/asm-x86/irq_vectors.h
+++ linux-2.6/include/asm-x86/irq_vectors.h
@@ -113,28 +113,26 @@
 
 # if defined(CONFIG_X86_IO_APIC) || defined(CONFIG_PARAVIRT) || defined(CONFIG_X86_VISWS)
 
+#ifdef CONFIG_X86_64
+#  define NR_IRQS		(32 * NR_CPUS + 224)
+#else
 #  define NR_IRQS		224
-
-#  if (224 >= 32 * NR_CPUS)
-#   define NR_IRQ_VECTORS	NR_IRQS
-#  else
-#   define NR_IRQ_VECTORS	(32 * NR_CPUS)
-#  endif
+#endif
 
 # else /* IO_APIC || PARAVIRT */
 
 #  define NR_IRQS		16
-#  define NR_IRQ_VECTORS	NR_IRQS
 
 # endif
 
 #else /* !VISWS && !VOYAGER */
 
 # define NR_IRQS		224
-# define NR_IRQ_VECTORS		NR_IRQS
 
 #endif /* VISWS */
 
+#define NR_IRQ_VECTORS		NR_IRQS
+
 /* Voyager specific defines */
 /* These define the CPIs we use in linux */
 #define VIC_CPI_LEVEL0			0
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/16] dyn_array and nr_irqs support v2, Yinghai Lu, (Fri Aug 1, 5:37 am)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Eric W. Biederman, (Fri Aug 1, 4:46 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Yinghai Lu, (Fri Aug 1, 10:58 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Mike Travis, (Fri Aug 1, 5:47 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Yinghai Lu, (Fri Aug 1, 5:30 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Eric W. Biederman, (Fri Aug 1, 6:38 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Yinghai Lu, (Fri Aug 1, 9:09 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Eric W. Biederman, (Fri Aug 1, 9:41 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Mike Travis, (Mon Aug 4, 8:57 am)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, H. Peter Anvin, (Mon Aug 4, 10:38 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Eric W. Biederman, (Mon Aug 4, 11:40 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, H. Peter Anvin, (Mon Aug 4, 11:48 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Yinghai Lu, (Fri Aug 1, 10:01 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, H. Peter Anvin, (Fri Aug 1, 10:03 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Eric W. Biederman, (Fri Aug 1, 10:39 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, H. Peter Anvin, (Fri Aug 1, 11:28 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Eric W. Biederman, (Sat Aug 2, 12:42 am)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, H. Peter Anvin, (Sat Aug 2, 11:41 am)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Eric W. Biederman, (Sat Aug 2, 4:20 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, H. Peter Anvin, (Fri Aug 1, 9:36 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Yinghai Lu, (Fri Aug 1, 6:10 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Yinghai Lu, (Fri Aug 1, 5:57 pm)
Re: [PATCH 00/16] dyn_array and nr_irqs support v2, Eric W. Biederman, (Fri Aug 1, 6:45 pm)
[PATCH 01/16] x86: 64bit support more than 256 irq, Yinghai Lu, (Fri Aug 1, 5:37 am)
[PATCH 02/16] x86: introduce nr_irqs for 64bit v3, Yinghai Lu, (Fri Aug 1, 5:37 am)
[PATCH 03/16] add dyn_array support, Yinghai Lu, (Fri Aug 1, 5:37 am)
[PATCH 04/16] make irq_timer_state to use dyn_array, Yinghai Lu, (Fri Aug 1, 5:37 am)
[PATCH 05/16] make irq2_iommu to use dyn_array, Yinghai Lu, (Fri Aug 1, 5:37 am)
[PATCH 06/16] make irq_desc to use dyn_array, Yinghai Lu, (Fri Aug 1, 5:37 am)
[PATCH 07/16] x86: make 64bit support dyn_array, Yinghai Lu, (Fri Aug 1, 5:37 am)
[PATCH 09/16] add per_cpu_dyn_array support, Yinghai Lu, (Fri Aug 1, 5:37 am)