Re: [PATCH] bnx2 - use request_firmware()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Miller
Date: Monday, July 7, 2008 - 3:05 pm

From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Mon, 7 Jul 2008 22:19:50 +0100


The firmware needs to be reloaded every time the chip resets.
You're not saving anything.

Or do you want a request_firmware() call failure to hose your
ethernet device when it gets a TX timeout?

<sarcasm>
Sounds like a real error resiliant system to me...
</sarcasm>

Distribution vendors can just as easily ship the driver itself
seperately to get the firmware update.  And by getting it together the
user knows they are receiving something the driver maintainer tested
as a unit.


Distribution vendors just want the separation so that they don't have
to keep patching the fimrware out of the tg3.c driver source every
single release, as some do :-)


See above, you aren't saving anything.  The firmware needs to stay
around so it can be reloaded into the card during exceptions.

That is, unless you want a more failure prone system.


They (actually, more specifically the maintainers) to a certain extent
are, because they are the ones who eat doo-doo when something explodes.

 There are other important considerations, but

So in your "firmware updated seperately" argument above how in the
world does this work?  How can you update the firmware seperately if
the MD5sum check is in the driver itself?
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] bnx2 - use request_firmware(), David Woodhouse, (Sat Jul 5, 2:44 am)
Re: [PATCH] bnx2 - use request_firmware(), Michael Chan, (Sun Jul 6, 9:21 pm)
Re: [PATCH] bnx2 - use request_firmware(), Bastian Blank, (Mon Jul 7, 12:53 am)
Re: [PATCH] bnx2 - use request_firmware(), David Woodhouse, (Mon Jul 7, 2:03 am)
Re: [PATCH] bnx2 - use request_firmware(), Michael Chan, (Mon Jul 7, 11:56 am)
Re: [PATCH] bnx2 - use request_firmware(), Alan Cox, (Mon Jul 7, 2:19 pm)
Re: [PATCH] bnx2 - use request_firmware(), David Miller, (Mon Jul 7, 2:38 pm)
Re: [PATCH] bnx2 - use request_firmware(), David Miller, (Mon Jul 7, 3:05 pm)
Re: [PATCH] bnx2 - use request_firmware(), Jeff Garzik, (Mon Jul 7, 3:08 pm)
Re: [PATCH] bnx2 - use request_firmware(), David Miller, (Mon Jul 7, 4:01 pm)
Re: [PATCH] bnx2 - use request_firmware(), david, (Mon Jul 7, 8:30 pm)
Re: [PATCH] bnx2 - use request_firmware(), Alan Cox, (Mon Jul 7, 11:39 pm)
Re: [PATCH] bnx2 - use request_firmware(), Alan Cox, (Mon Jul 7, 11:41 pm)
Re: [PATCH] bnx2 - use request_firmware(), Alan Cox, (Mon Jul 7, 11:49 pm)
Re: [PATCH] bnx2 - use request_firmware(), David Miller, (Tue Jul 8, 1:58 am)
Re: [PATCH] bnx2 - use request_firmware(), David Miller, (Tue Jul 8, 2:00 am)