On Mon, 7 Jul 2008, Rafael J. Wysocki wrote:

quoted text
> >  Ingo, from the sequence above, I gather this code is currently in the 
> > tree:
> > 
> > -	replace_pin_at_irq(0, 0, 0, apic1, pin1);
> > -	apic1 = 0;
> > -	pin1 = 0;
> > 
> > Please revert the change which introduced it.  While I recall posting a
> > patch which added code like this, I clearly stated it was solely for
> > diagnostics of Rafael's system and not to apply to any tree.
> 
> Shouldn't the setup_timer_IRQ0_pin(apic1, pin1, cfg->vector) be removed as
> well?

 Yes.  The whole commit should be reverted as mentioned in the other
e-mail (it didn't even bear my sign-off mark).  This would include the
line you are referring to as well.  I have submitted a patch to add a
64-bit variation of replace_pin_at_irq() separately.

  Maciej
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/