[PATCH 19/20] security: fix return of void-valued expressions

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: James Morris
Date: Monday, July 7, 2008 - 9:42 am

Fix several warnings generated by sparse of the form
"returning void-valued expression".

Signed-off-by: James Morris <jmorris@namei.org>
Acked-by: Casey Schaufler <casey@schaufler-ca.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
---
 security/security.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/security/security.c b/security/security.c
index c4507ce..2c0a587 100644
--- a/security/security.c
+++ b/security/security.c
@@ -895,7 +895,7 @@ EXPORT_SYMBOL(security_secctx_to_secid);
 
 void security_release_secctx(char *secdata, u32 seclen)
 {
-	return security_ops->release_secctx(secdata, seclen);
+	security_ops->release_secctx(secdata, seclen);
 }
 EXPORT_SYMBOL(security_release_secctx);
 
@@ -1012,12 +1012,12 @@ int security_sk_alloc(struct sock *sk, int family, gfp_t priority)
 
 void security_sk_free(struct sock *sk)
 {
-	return security_ops->sk_free_security(sk);
+	security_ops->sk_free_security(sk);
 }
 
 void security_sk_clone(const struct sock *sk, struct sock *newsk)
 {
-	return security_ops->sk_clone_security(sk, newsk);
+	security_ops->sk_clone_security(sk, newsk);
 }
 
 void security_sk_classify_flow(struct sock *sk, struct flowi *fl)
-- 
1.5.5.1

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
SELinux patches for 2.6.26, James Morris, (Mon Jul 7, 9:42 am)
[PATCH 08/20] selinux: simplify ioctl checking, James Morris, (Mon Jul 7, 9:42 am)
[PATCH 10/20] SELinux: open code policy_rwlock, James Morris, (Mon Jul 7, 9:42 am)
[PATCH 11/20] SELinux: open code load_mutex, James Morris, (Mon Jul 7, 9:42 am)
[PATCH 12/20] SELinux: open code sidtab lock, James Morris, (Mon Jul 7, 9:42 am)
[PATCH 19/20] security: fix return of void-valued expressions, James Morris, (Mon Jul 7, 9:42 am)
Re: SELinux patches for 2.6.26, Theodore Tso, (Mon Jul 7, 11:23 am)
Re: SELinux patches for 2.6.26, James Morris, (Mon Jul 7, 3:49 pm)