Re: [PATCH 2/2] acpi: Disable IRQ 0 through I/O APIC for some HP systems

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Maciej W. Rozycki
Date: Monday, July 7, 2008 - 7:01 am

On Mon, 7 Jul 2008, Rafael J. Wysocki wrote:


 Well, it is the very intent of the DMI quirk to set apic1 and pin1 both
to -1, as a result of IRQ0 being absent from our I/O APIC interrupt
routing table.  Therefore if the quirk did indeed work, a call to
clear_IO_APIC_pin() is useless and likely harmful as its callees don't do
range checking (my understanding of code is it results in random poking at
the local APIC through the FIX_APIC_BASE fixmap).  There should be nothing
to clear too, as interrupt redirection entries for all the I/O APIC inputs
are cleared (the mask is set to 1 and the remaining fields zeroed) when
clear_IO_APIC() is called from enable_IO_APIC() upon initialization and
all the unused ones (not referred to from anywhere in the interrupt
routing table) are never touched afterwards.

  Maciej
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 2/2] acpi: Disable IRQ 0 through I/O APIC for some ..., Maciej W. Rozycki, (Mon Jun 30, 5:12 pm)
Re: [PATCH 2/2] acpi: Disable IRQ 0 through I/O APIC for s ..., Rafael J. Wysocki, (Tue Jul 1, 12:58 pm)
Re: [PATCH 2/2] acpi: Disable IRQ 0 through I/O APIC for s ..., Maciej W. Rozycki, (Mon Jul 7, 7:01 am)
Re: [PATCH 2/2] acpi: Disable IRQ 0 through I/O APIC for s ..., Maciej W. Rozycki, (Mon Jul 7, 10:10 am)
Re: [PATCH 2/2] acpi: Disable IRQ 0 through I/O APIC for s ..., Rafael J. Wysocki, (Mon Jul 7, 11:03 am)
Re: [PATCH 2/2] acpi: Disable IRQ 0 through I/O APIC for s ..., Rafael J. Wysocki, (Mon Jul 7, 11:09 am)
Re: [PATCH 2/2] acpi: Disable IRQ 0 through I/O APIC for s ..., Maciej W. Rozycki, (Mon Jul 7, 12:59 pm)