Re: pata_it821x completely broken

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ondrej Zary <linux@...>
Cc: <alan@...>, LKML <linux-kernel@...>, <linux-ide@...>
Date: Sunday, July 6, 2008 - 3:37 pm

> When I force the pass-through mode, it oopses (haven't captured it yet as it's 

Couldn't reproduce that yet but the HPA case should be fixed by the
following patch:

pata_it821x: With newer firmware we see HPA flags

From: Alan Cox <alan@redhat.com>

We don't want HPA flags set at this point as we don't allow the issuing of
HPA operations via the 'smart' firmware interface. It could be 1.7 firmware
supports this but for the moment the blunt hammer is appealing (one reason
being right now we don't actually know how to peek at the firmware rev!)
---

 drivers/ata/pata_it821x.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)


diff --git a/drivers/ata/pata_it821x.c b/drivers/ata/pata_it821x.c
index e108169..977e5f8 100644
--- a/drivers/ata/pata_it821x.c
+++ b/drivers/ata/pata_it821x.c
@@ -80,7 +80,7 @@
 
 
 #define DRV_NAME "pata_it821x"
-#define DRV_VERSION "0.3.8"
+#define DRV_VERSION "0.3.9"
 
 struct it821x_dev
 {
@@ -519,6 +519,8 @@ static void it821x_dev_config(struct ata_device *adev)
 	/* This is a controller firmware triggered funny, don't
 	   report the drive faulty! */
 	adev->horkage &= ~ATA_HORKAGE_DIAGNOSTIC;
+	/* No HPA in 'smart' mode */
+	adev->horkage |= ATA_HORKAGE_BROKEN_HPA;
 }
 
 /**
@@ -546,7 +548,9 @@ static int it821x_ident_hack(struct ata_port *ap)
 			adev->id[76] = 0;		/* No NCQ/AN etc */
 		}
 	}
-	return ata_cable_unknown(ap);
+	/* This is actually meaningless, but reporting 80 wire avoids
+	   warnings about cable types */
+	return ata_cable_80wire(ap);
 }
 
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
pata_it821x completely broken, Ondrej Zary, (Fri Jul 4, 3:53 pm)
Re: pata_it821x completely broken, Alan Cox, (Fri Jul 4, 4:22 pm)
Re: pata_it821x completely broken, Ondrej Zary, (Fri Jul 4, 5:39 pm)
Re: pata_it821x completely broken, Alan Cox, (Fri Jul 4, 5:46 pm)
Re: pata_it821x completely broken, Ondrej Zary, (Sat Jul 5, 6:41 am)
Re: pata_it821x completely broken, Alan Cox, (Sun Jul 6, 3:37 pm)
Re: pata_it821x completely broken, Ondrej Zary, (Sun Jul 6, 5:50 pm)
Re: pata_it821x completely broken, Alan Cox, (Sun Jul 6, 7:01 pm)
Re: pata_it821x completely broken, Ondrej Zary, (Thu Jul 10, 4:35 pm)
Re: pata_it821x completely broken, Ondrej Zary, (Fri Jul 11, 2:43 pm)
Re: pata_it821x completely broken, Alan Cox, (Fri Jul 11, 4:14 pm)
Re: pata_it821x completely broken, Ondrej Zary, (Sat Jul 12, 5:42 pm)
Re: pata_it821x completely broken, Ondrej Zary, (Sun Jul 13, 7:47 am)
Re: pata_it821x completely broken, Ondrej Zary, (Tue Jul 22, 1:59 pm)
Re: pata_it821x completely broken, Alan Cox, (Tue Jul 22, 2:10 pm)
Re: pata_it821x completely broken, Ondrej Zary, (Tue Jul 22, 3:16 pm)
Re: pata_it821x completely broken, Rene Herman, (Tue Jul 22, 3:35 pm)
Re: pata_it821x completely broken, Alan Cox, (Tue Jul 22, 4:39 pm)
Re: pata_it821x completely broken, Alan Cox, (Sun Jul 13, 7:35 am)
Re: pata_it821x completely broken, Ondrej Zary, (Sun Jul 13, 8:10 am)
Re: pata_it821x completely broken, Alan Cox, (Sun Jul 13, 10:08 am)
Re: pata_it821x completely broken, Ondrej Zary, (Mon Jul 7, 2:07 pm)
Re: pata_it821x completely broken, Alan Cox, (Sat Jul 5, 11:49 am)
Re: pata_it821x completely broken, Ondrej Zary, (Sun Jul 6, 5:03 pm)
Re: pata_it821x completely broken, Alan Cox, (Sun Jul 6, 4:51 pm)
Re: pata_it821x completely broken, Ondrej Zary, (Sun Jul 6, 5:46 pm)