Home » Mailing list archives » linux-kernel » 2008 » July » 5

[PATCH 19/52] ext4: Make ext4_ext_find_extent fills ext_path completely

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Theodore Ts'o <tytso@...>
To: Ext4 Developers List <linux-ext4@...>, Linux Kernel Developers List <linux-kernel@...>
Cc: Shen Feng <shen@...>, Mingming Cao <cmm@...>, Theodore Ts'o <tytso@...>
Subject: [PATCH 19/52] ext4: Make ext4_ext_find_extent fills ext_path completely
Date: Saturday, July 5, 2008 - 1:35 pm

From: Shen Feng <shen@cn.fujitsu.com>

When pos=0 or depth, the fields of ext4_ext_path is are not
completely filled.  This patch also removes some unnecessary code.

Signed-off-by: Shen Feng <shen@cn.fujitsu.com>
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
 fs/ext4/extents.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index bc17ed7..3e966da 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -524,6 +524,7 @@ ext4_ext_find_extent(struct inode *inode, ext4_lblk_t block,
 		alloc = 1;
 	}
 	path[0].p_hdr = eh;
+	path[0].p_bh = NULL;
 
 	i = depth;
 	/* walk through the tree */
@@ -552,12 +553,14 @@ ext4_ext_find_extent(struct inode *inode, ext4_lblk_t block,
 	}
 
 	path[ppos].p_depth = i;
-	path[ppos].p_hdr = eh;
 	path[ppos].p_ext = NULL;
 	path[ppos].p_idx = NULL;
 
 	/* find extent */
 	ext4_ext_binsearch(inode, path + ppos, block);
+	/* if not an empty leaf */
+	if (path[ppos].p_ext)
+		path[ppos].p_block = ext_pblock(path[ppos].p_ext);
 
 	ext4_ext_show_path(inode, path);
 
-- 
1.5.6.rc3.1.g36b7.dirty

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 08/52] ext4: miscellaneous error checks and coding cl..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 09/52] ext4: remove double definitions of xattr macros, Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 10/52] ext4: Rename read_block_bitmap() to ext4_read_..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 11/52] ext4: Remove unused variable from ext4_show_op..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 12/52] jbd2: Add commit time into the commit block, Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 13/52] ext4: New inode allocation for FLEX_BG meta-da..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 14/52] jbd2: fix race between jbd2_journal_try_to_fre..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 15/52] ext4: remove redundant code in ext4_fill_super(), Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 16/52] ext4: remove quota allocation when ext4_mb_new..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 17/52] ext4: Update i_disksize properly when allocati..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 18/52] ext4: return error when calling ext4_ext_split..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 19/52] ext4: Make ext4_ext_find_extent fills ext_path..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)