Home » Mailing list archives » linux-kernel » 2008 » July » 5

[PATCH 29/52] ext4: use atomic functions to set bh_state

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Theodore Ts'o <tytso@...>
To: Ext4 Developers List <linux-ext4@...>, Linux Kernel Developers List <linux-kernel@...>
Cc: Eric Sandeen <sandeen@...>, Mingming Cao <cmm@...>, Theodore Ts'o <tytso@...>
Subject: [PATCH 29/52] ext4: use atomic functions to set bh_state
Date: Saturday, July 5, 2008 - 1:35 pm

From: Eric Sandeen <sandeen@redhat.com>

Use the BUFFER_FNS functions (set_buffer_foo) to set buffer
head state atomically instead of nonatomic __set_bit().

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
 fs/ext4/extents.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 555155d..bb36a28 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2622,8 +2622,7 @@ int ext4_ext_get_blocks(handle_t *handle, struct inode *inode,
 				 */
 				if (allocated > max_blocks)
 					allocated = max_blocks;
-				/* mark the buffer unwritten */
-				__set_bit(BH_Unwritten, &bh_result->b_state);
+				set_buffer_unwritten(bh_result);
 				goto out2;
 			}
 
@@ -2729,7 +2728,7 @@ outnew:
 	if (extend_disksize && inode->i_size > EXT4_I(inode)->i_disksize)
 		EXT4_I(inode)->i_disksize = inode->i_size;
 
-	__set_bit(BH_New, &bh_result->b_state);
+	set_buffer_new(bh_result);
 
 	/* Cache only when it is _not_ an uninitialized extent */
 	if (create != EXT4_CREATE_UNINITIALIZED_EXT)
@@ -2739,7 +2738,7 @@ out:
 	if (allocated > max_blocks)
 		allocated = max_blocks;
 	ext4_ext_show_leaf(inode, path);
-	__set_bit(BH_Mapped, &bh_result->b_state);
+	set_buffer_mapped(bh_result);
 	bh_result->b_bdev = inode->i_sb->s_bdev;
 	bh_result->b_blocknr = newblock;
 out2:
-- 
1.5.6.rc3.1.g36b7.dirty

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 27/52] ext4: mballoc avoid use root reserved blocks f..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 28/52] ext4: Set journal pointer to NULL when journal..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 29/52] ext4: use atomic functions to set bh_state, Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 30/52] ext4: Add missing unlock to an error path in e..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 31/52] ext4: fix online resize with mballoc, Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 32/52] ext4: Documentation updates., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 33/52] ext4: Use page_mkwrite vma_operations to get m..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 34/52] vfs: Move mark_inode_dirty() from under page l..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 35/52] ext4: Invert the locking order of page_lock an..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 36/52] ext4: Fix lock inversion in ext4_ext_truncate(), Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 37/52] vfs: export filemap_fdatawrite_range(), Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 38/52] jbd2: Implement data=ordered mode handling via..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 39/52] ext4: Use new framework for data=ordered mode ..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 40/52] jbd2: Remove data=ordered mode support using j..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 41/52] vfs: add basic delayed allocation support, Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 42/52] ext4: Add basic delayed allocation support, Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 43/52] percpu_counter: new function percpu_counter_su..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 44/52] ext4: delayed allocation ENOSPC handling, Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 45/52] mm: Add range_cont mode for writeback, Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 46/52] ext4: Invert lock ordering of page_lock and tr..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 47/52] ext4: Add ordered mode support for delalloc, Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 48/52] ext4: Handle page without buffers in ext4_*_wr..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 49/52] ext4: fix delalloc i_disksize early update issue, Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 50/52] ext4: Enable delalloc by default., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 51/52] ext4: Don't allow nonextenst mount option for ..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 52/52] ext4: Documention update for new ordered mode ..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)