Home » Mailing list archives » linux-kernel » 2008 » July » 5

[PATCH 15/52] ext4: remove redundant code in ext4_fill_super()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Theodore Ts'o <tytso@...>
To: Ext4 Developers List <linux-ext4@...>, Linux Kernel Developers List <linux-kernel@...>
Cc: Li Zefan <lizf@...>, Mingming Cao <cmm@...>, Theodore Ts'o <tytso@...>
Subject: [PATCH 15/52] ext4: remove redundant code in ext4_fill_super()
Date: Saturday, July 5, 2008 - 1:35 pm

From: Li Zefan <lizf@cn.fujitsu.com>

The previous sb_min_blocksize() has already set the block size.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
 fs/ext4/super.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 0d560fc..b1166a9 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1899,11 +1899,6 @@ static int ext4_fill_super (struct super_block *sb, void *data, int silent)
 		goto out_fail;
 	}
 
-	if (!sb_set_blocksize(sb, blocksize)) {
-		printk(KERN_ERR "EXT4-fs: bad blocksize %d.\n", blocksize);
-		goto out_fail;
-	}
-
 	/*
 	 * The ext4 superblock will not be buffer aligned for other than 1kB
 	 * block sizes.  We need to calculate the offset from buffer start.
-- 
1.5.6.rc3.1.g36b7.dirty

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 08/52] ext4: miscellaneous error checks and coding cl..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 09/52] ext4: remove double definitions of xattr macros, Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 10/52] ext4: Rename read_block_bitmap() to ext4_read_..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 11/52] ext4: Remove unused variable from ext4_show_op..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 12/52] jbd2: Add commit time into the commit block, Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 13/52] ext4: New inode allocation for FLEX_BG meta-da..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 14/52] jbd2: fix race between jbd2_journal_try_to_fre..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 15/52] ext4: remove redundant code in ext4_fill_super(), Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 16/52] ext4: remove quota allocation when ext4_mb_new..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 17/52] ext4: Update i_disksize properly when allocati..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 18/52] ext4: return error when calling ext4_ext_split..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 19/52] ext4: Make ext4_ext_find_extent fills ext_path..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)