Home » Mailing list archives » linux-kernel » 2008 » July » 5

[PATCH 30/52] ext4: Add missing unlock to an error path in ext4_quota_write()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Theodore Ts'o <tytso@...>
To: Ext4 Developers List <linux-ext4@...>, Linux Kernel Developers List <linux-kernel@...>
Cc: Jan Kara <jack@...>, Mingming Cao <cmm@...>, Theodore Ts'o <tytso@...>
Subject: [PATCH 30/52] ext4: Add missing unlock to an error path in ext4_quota_write()
Date: Saturday, July 5, 2008 - 1:35 pm

From: Jan Kara <jack@suse.cz>

Add missing unlock of i_mutex in the error path of ext4_quota_write().

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
 fs/ext4/super.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index e239af3..1b330cd 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -3390,8 +3390,10 @@ static ssize_t ext4_quota_write(struct super_block *sb, int type,
 		blk++;
 	}
 out:
-	if (len == towrite)
+	if (len == towrite) {
+		mutex_unlock(&inode->i_mutex);
 		return err;
+	}
 	if (inode->i_size < off+len-towrite) {
 		i_size_write(inode, off+len-towrite);
 		EXT4_I(inode)->i_disksize = inode->i_size;
-- 
1.5.6.rc3.1.g36b7.dirty

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 27/52] ext4: mballoc avoid use root reserved blocks f..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 28/52] ext4: Set journal pointer to NULL when journal..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 29/52] ext4: use atomic functions to set bh_state, Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 30/52] ext4: Add missing unlock to an error path in e..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 31/52] ext4: fix online resize with mballoc, Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 32/52] ext4: Documentation updates., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 33/52] ext4: Use page_mkwrite vma_operations to get m..., Theodore Ts'o, (Sat Jul 5, 1:35 pm)
[PATCH 34/52] vfs: Move mark_inode_dirty() from under page l..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 35/52] ext4: Invert the locking order of page_lock an..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 36/52] ext4: Fix lock inversion in ext4_ext_truncate(), Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 37/52] vfs: export filemap_fdatawrite_range(), Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 38/52] jbd2: Implement data=ordered mode handling via..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 39/52] ext4: Use new framework for data=ordered mode ..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 40/52] jbd2: Remove data=ordered mode support using j..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 41/52] vfs: add basic delayed allocation support, Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 42/52] ext4: Add basic delayed allocation support, Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 43/52] percpu_counter: new function percpu_counter_su..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 44/52] ext4: delayed allocation ENOSPC handling, Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 45/52] mm: Add range_cont mode for writeback, Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 46/52] ext4: Invert lock ordering of page_lock and tr..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 47/52] ext4: Add ordered mode support for delalloc, Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 48/52] ext4: Handle page without buffers in ext4_*_wr..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 49/52] ext4: fix delalloc i_disksize early update issue, Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 50/52] ext4: Enable delalloc by default., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 51/52] ext4: Don't allow nonextenst mount option for ..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)
[PATCH 52/52] ext4: Documention update for new ordered mode ..., Theodore Ts'o, (Sat Jul 5, 1:36 pm)